On Wed, 5 Apr 2023 21:00:55 GMT, Kevin Walls wrote:
> Removal of the Permission information from the jcmd man page.
>
> This information is not useful in the way it is presented, and is not used in
> connection with jcmd, so should be removed from that man page.
>
> The Permissions can be rele
On Thu, 6 Apr 2023 03:35:17 GMT, Chris Plummer wrote:
>> The real purpose of this PR is to add virtual thread support to
>> ThreadMemoryLeakTest.java, but this exposed bugs in both the debug agent and
>> in TestScaffold, so those are being fixed also (and the debug agent bug is
>> the CR being
On Wed, 5 Apr 2023 16:17:44 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Wed, 5 Apr 2023 10:40:54 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Thu, 6 Apr 2023 03:35:17 GMT, Chris Plummer wrote:
>> The real purpose of this PR is to add virtual thread support to
>> ThreadMemoryLeakTest.java, but this exposed bugs in both the debug agent and
>> in TestScaffold, so those are being fixed also (and the debug agent bug is
>> the CR being
On Tue, 4 Apr 2023 20:15:41 GMT, Leonid Mesnik wrote:
> Some tests set debugee name which is set by startUp() method.
>
> The test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java set
> classpath which is not required.
This pull request has now been integrated.
Changeset: 35d22930
A
> The real purpose of this PR is to add virtual thread support to
> ThreadMemoryLeakTest.java, but this exposed bugs in both the debug agent and
> in TestScaffold, so those are being fixed also (and the debug agent bug is
> the CR being used).
>
> The debug agent bug is due to a race condition
On Wed, 5 Apr 2023 21:36:57 GMT, Glavo wrote:
>> src/java.base/share/classes/jdk/internal/util/Architecture.java line 77:
>>
>>> 75: */
>>> 76: @ForceInline
>>> 77: public static boolean isARM() {
>>
>> It should define what’s the difference to aarch64 for example will aarch64
>>
On Wed, 5 Apr 2023 19:20:08 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
> Some tests set debugee name which is set by startUp() method.
>
> The test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java set
> classpath which is not required.
Leonid Mesnik has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev exc
On Wed, 5 Apr 2023 22:48:45 GMT, Chris Plummer wrote:
>> Removal of the Permission information from the jcmd man page.
>>
>> This information is not useful in the way it is presented, and is not used
>> in connection with jcmd, so should be removed from that man page.
>>
>> The Permissions can
On Tue, 4 Apr 2023 20:33:46 GMT, Serguei Spitsyn wrote:
> This is a follow-up to
> [JDK-8302615](https://bugs.openjdk.org/browse/JDK-8302615) where
> GetCurrentThreadCpuTime and GetThreadCpuTime were changed from being not
> supported to optional, when called from/with a virtual thread. There
On Thu, 6 Apr 2023 00:01:05 GMT, Leonid Mesnik wrote:
>> Currently, VMConnection run debugee using "test.classes" as a classpath. It
>> cause test failures when virtual thread factory (wrapper) is enabled and
>> test is not located the same directory as TestScaffold.
>
> Leonid Mesnik has updat
On Thu, 6 Apr 2023 00:01:05 GMT, Leonid Mesnik wrote:
>> Currently, VMConnection run debugee using "test.classes" as a classpath. It
>> cause test failures when virtual thread factory (wrapper) is enabled and
>> test is not located the same directory as TestScaffold.
>
> Leonid Mesnik has updat
> Currently, VMConnection run debugee using "test.classes" as a classpath. It
> cause test failures when virtual thread factory (wrapper) is enabled and test
> is not located the same directory as TestScaffold.
Leonid Mesnik has updated the pull request incrementally with one additional
commit
On Wed, 5 Apr 2023 21:18:43 GMT, Glavo wrote:
>> There should be no difference; I was hesitant to drop the ADDRESS_SIZE check
>> without knowing more about the foreign api dependencies. ADDRESS_SIZE is
>> computed (I think) from `UNSAFE.ADDRESS_SIZE * 8`.
>> But I can't think of how it can be
On Wed, 5 Apr 2023 19:20:08 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Wed, 5 Apr 2023 21:00:55 GMT, Kevin Walls wrote:
> Removal of the Permission information from the jcmd man page.
>
> This information is not useful in the way it is presented, and is not used in
> connection with jcmd, so should be removed from that man page.
>
> The Permissions can be rele
On Wed, 5 Apr 2023 21:00:55 GMT, Kevin Walls wrote:
> Removal of the Permission information from the jcmd man page.
>
> This information is not useful in the way it is presented, and is not used in
> connection with jcmd, so should be removed from that man page.
>
> The Permissions can be rele
On Wed, 5 Apr 2023 21:00:55 GMT, Kevin Walls wrote:
> Removal of the Permission information from the jcmd man page.
>
> This information is not useful in the way it is presented, and is not used in
> connection with jcmd, so should be removed from that man page.
>
> The Permissions can be rele
On Wed, 5 Apr 2023 21:37:46 GMT, Leonid Mesnik wrote:
>> I think the CR should explain this test.classes vs test.class.path
>> difference, and also explain why the classpath requirements are different
>> when using virtual threads. You say that "TestScaffold should be also in
>> classpath", bu
On Tue, 4 Apr 2023 20:15:41 GMT, Leonid Mesnik wrote:
> Some tests set debugee name which is set by startUp() method.
>
> The test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java set
> classpath which is not required.
Marked as reviewed by cjplummer (Reviewer).
-
PR Re
On Wed, 5 Apr 2023 20:09:38 GMT, Chris Plummer wrote:
>> I'd prefer to always use the "test.class.path" as it is a complete classpath
>> required to run test.
>>
>>> The better comment would be
>>> // When we run jtreg with plugin, the full classpath including testlibrary
>>> is required to us
On Wed, 5 Apr 2023 20:28:17 GMT, Bernd wrote:
> It should define what’s the difference to aarch64 for example will aarch64
> also be arm, but arm32 wont? (Or remove)
I think x86 and ARM are a bit confusing in this regard, as they can refer to
32-bit architectures in a narrow sense and 32-bit o
On Wed, 5 Apr 2023 21:24:16 GMT, Chris Plummer wrote:
> What about the permissions references in the jcmd help output:
>
> ```
> $ jcmd 32228 help VM.version
> 32228:
> VM.version
> Print JVM version information.
>
> Impact: Low
>
> Permission: java.util.PropertyPermission(java.vm.version, rea
On Wed, 5 Apr 2023 19:51:00 GMT, Chris Plummer wrote:
> Do I understand correctly that this bug just caused the debuggee to appear
> twice in the arguments, leading to output like the following:
>
> [2ms] run args: [RefTypes, RefTypes]
>
> In this case it was harmless because the 2nd "RefTypes
On Wed, 5 Apr 2023 21:12:14 GMT, Daniel D. Daugherty wrote:
> Trivial fixes to ProblemList a couple of tests:
> [JDK-8305678](https://bugs.openjdk.org/browse/JDK-8305678) ProblemList
> serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp
> [JDK-8305679](https://bugs.openjdk.org/browse/JD
On Wed, 5 Apr 2023 21:18:28 GMT, Mikael Vidstedt wrote:
>> Trivial fixes to ProblemList a couple of tests:
>> [JDK-8305678](https://bugs.openjdk.org/browse/JDK-8305678) ProblemList
>> serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp
>> [JDK-8305679](https://bugs.openjdk.org/browse/JD
On Wed, 5 Apr 2023 21:12:14 GMT, Daniel D. Daugherty wrote:
> Trivial fixes to ProblemList a couple of tests:
> [JDK-8305678](https://bugs.openjdk.org/browse/JDK-8305678) ProblemList
> serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp
> [JDK-8305679](https://bugs.openjdk.org/browse/JD
Trivial fixes to ProblemList a couple of tests:
[JDK-8305678](https://bugs.openjdk.org/browse/JDK-8305678) ProblemList
serviceability/sa/ClhsdbInspect.java on windows-x64 in Xcomp
[JDK-8305679](https://bugs.openjdk.org/browse/JDK-8305679) ProblemList
java/util/concurrent/locks/Lock/OOMEInAQS.java
On Wed, 5 Apr 2023 21:00:55 GMT, Kevin Walls wrote:
> Removal of the Permission information from the jcmd man page.
>
> This information is not useful in the way it is presented, and is not used in
> connection with jcmd, so should be removed from that man page.
>
> The Permissions can be rele
On Tue, 4 Apr 2023 20:15:41 GMT, Leonid Mesnik wrote:
> Some tests set debugee name which is set by startUp() method.
>
> The test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java set
> classpath which is not required.
Marked as reviewed by amenkov (Reviewer).
-
PR Revi
On Wed, 5 Apr 2023 20:40:32 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/jdk/internal/foreign/CABI.java line 48:
>>
>>> 46: // might be running in a 32-bit VM on a 64-bit platform.
>>> 47: // addressSize will be correctly 32
>>> 48: if (Architecture.isX64() && A
Removal of the Permission information from the jcmd man page.
This information is not useful in the way it is presented, and is not used in
connection with jcmd, so should be removed from that man page.
The Permissions can be relevant when connecting remotely to JMX with a Security
Manager in p
On Wed, 5 Apr 2023 20:25:39 GMT, Chris Plummer wrote:
>> Alex Menkov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> aree -> are
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/FollowReferences/VThreadStackRefTest.java
> line 43:
>
> The fix updates JVMTI FollowReferences implementation to report references
> from virtual threads:
> - added heap scanning to report unmounted vthreads;
> - stacks of mounted vthreads are splitted into 2 parts (vittual thread stack
> and carrier thread stack), references are reported with corre
On Wed, 5 Apr 2023 20:31:43 GMT, Bernd wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct spelling of isAARCH64 in WIndows AttachProviderImpl
>
> test/jdk/jdk/internal/util/ArchTest.java line 58:
>
>> 56:
On Wed, 5 Apr 2023 20:25:43 GMT, Bernd wrote:
>> Roger Riggs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Correct spelling of isAARCH64 in WIndows AttachProviderImpl
>
> src/java.base/share/classes/jdk/internal/foreign/CABI.java line
On Wed, 5 Apr 2023 16:17:44 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Thu, 30 Mar 2023 22:58:12 GMT, Alex Menkov wrote:
> The fix updates JVMTI FollowReferences implementation to report references
> from virtual threads:
> - added heap scanning to report unmounted vthreads;
> - stacks of mounted vthreads are splitted into 2 parts (vittual thread stack
> and ca
On Wed, 5 Apr 2023 19:20:08 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
On Mon, 3 Apr 2023 23:11:49 GMT, Chris Plummer wrote:
>> The fix updates JVMTI FollowReferences implementation to report references
>> from virtual threads:
>> - added heap scanning to report unmounted vthreads;
>> - stacks of mounted vthreads are splitted into 2 parts (vittual thread stack
>>
On Thu, 30 Mar 2023 22:58:12 GMT, Alex Menkov wrote:
> The fix updates JVMTI FollowReferences implementation to report references
> from virtual threads:
> - added heap scanning to report unmounted vthreads;
> - stacks of mounted vthreads are splitted into 2 parts (vittual thread stack
> and ca
The fix updates JVMTI FollowReferences implementation to report references from
virtual threads:
- added heap scanning to report unmounted vthreads;
- stacks of mounted vthreads are splitted into 2 parts (vittual thread stack
and carrier thread stack), references are reported with correct thread
On Wed, 5 Apr 2023 01:05:44 GMT, Serguei Spitsyn wrote:
>> The "test.class.path" is complete classpath required to run test. It
>> included test.classes as well as testlibrary and some other classes. The
>> tests located in com/sun/jdi/ uses 'com/sun/jdi' as a
>> testlibrary.
>> The better com
On Tue, 4 Apr 2023 20:15:41 GMT, Leonid Mesnik wrote:
> Some tests set debugee name which is set by startUp() method.
>
> The test/jdk/com/sun/jdi/RedefineNestmateAttr/TestNestmateAttr.java set
> classpath which is not required.
Do I understand correctly that this bug just caused the debuggee
On Wed, 5 Apr 2023 16:17:44 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X,
> PPC64LE`
> Note
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X,
> PPC64LE`
> Note
On Wed, 5 Apr 2023 18:53:12 GMT, Roger Riggs wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X8
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X,
> PPC64LE`
> Note
On Wed, 5 Apr 2023 17:15:13 GMT, Roger Riggs wrote:
> Yes, the capitalization names should be disciplined. In the enum, there are
> all uppercase, following the style of manifest constants and enums. In the
> build they are always lower case. Camel case is usually used for method
> names. Usin
On Wed, 5 Apr 2023 16:23:08 GMT, Glavo wrote:
>> Define an internal jdk.internal.util.Architecture enumeration and static
>> methods to replace uses of the system property `os.arch`.
>> The enumeration values are defined to match those used in the build.
>> The initial values are: `X64, X86, IA6
Define an internal jdk.internal.util.Architecture enumeration and static
methods to replace uses of the system property `os.arch`.
The enumeration values are defined to match those used in the build.
The initial values are: `X64, X86, IA64, ARM, AARCH64, RISCV64, S390X, PPC64LE`
Note that `amd64`
On Wed, 5 Apr 2023 16:17:44 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
On Wed, 5 Apr 2023 15:58:08 GMT, Roger Riggs wrote:
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, I
On Wed, 5 Apr 2023 15:58:08 GMT, Roger Riggs wrote:
> Define an internal jdk.internal.util.Architecture enumeration and static
> methods to replace uses of the system property `os.arch`.
> The enumeration values are defined to match those used in the build.
> The initial values are: `X64, X86, I
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
On Wed, 5 Apr 2023 10:40:54 GMT, Roman Kennke wrote:
>> This change adds a fast-locking scheme as an alternative to the current
>> stack-locking implementation. It retains the advantages of stack-locking
>> (namely fast locking in uncontended code-paths), while avoiding the overload
>> of the
A trivial fix to ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual
threads.
-
Commit messages:
- Fix the bugID to the proper one.
- 8305659: ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual threads
Changes: https://git.openjdk.org/jdk/pull/13351/files
Webrev: h
On Wed, 5 Apr 2023 13:51:59 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual
> threads.
Looks good with now updated bug id.
-
Marked as reviewed by thartmann (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/13351
On Wed, 5 Apr 2023 14:00:25 GMT, Tobias Hartmann wrote:
>> A trivial fix to ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual
>> threads.
>
> Looks good with now updated bug id.
@TobiHartmann - Thanks for the fast review!
-
PR Comment: https://git.openjdk.org/jdk/pull/133
On Wed, 5 Apr 2023 13:51:59 GMT, Daniel D. Daugherty wrote:
> A trivial fix to ProblemList com/sun/jdi/PopAndInvokeTest.java with virtual
> threads.
This pull request has now been integrated.
Changeset: 2e59d21e
Author:Daniel D. Daugherty
URL:
https://git.openjdk.org/jdk/commit/2e5
On Tue, 4 Apr 2023 07:44:40 GMT, Adam Sotona wrote:
> CommandProcessor command "dumpclass" produces classes with invalid field
> descriptors.
>
> Proposed patch fixes
> `sun.jvm.hotspot.oops.InstanceKlass::getFieldSignatureIndex` to return
> correct `getSignatureIndex` instead of invalid `ge
> This change adds a fast-locking scheme as an alternative to the current
> stack-locking implementation. It retains the advantages of stack-locking
> (namely fast locking in uncontended code-paths), while avoiding the overload
> of the mark word. That overloading causes massive problems with Li
On Wed, 5 Apr 2023 01:48:19 GMT, David Holmes wrote:
> Renamings look good to me.
Thank you for your review!
-
PR Comment: https://git.openjdk.org/jdk/pull/12923#issuecomment-1497209787
On Wed, 5 Apr 2023 06:55:16 GMT, Serguei Spitsyn wrote:
>> I changed the names because I found it very hard to understand what the old
>> names represented: "AgentLibrary" vs "Library"? "add_init_agent" vs
>> "add_instrumentation_agent", or even "add_loaded_agent"? Also a bit
>> confusing that
> C11 has been stable for a long time on all platforms, so native code can use
> the standard alignas operator for alignment requirements
Julian Waters has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought i
On Fri, 31 Mar 2023 06:07:39 GMT, Julian Waters wrote:
> C11 has been stable for a long time on all platforms, so native code can use
> the standard alignas operator for alignment requirements
Hmm, right I'll link that issue into this one as well then
-
PR Comment: https://git.ope
On Tue, 4 Apr 2023 20:33:46 GMT, Serguei Spitsyn wrote:
> This is a follow-up to
> [JDK-8302615](https://bugs.openjdk.org/browse/JDK-8302615) where
> GetCurrentThreadCpuTime and GetThreadCpuTime were changed from being not
> supported to optional, when called from/with a virtual thread. There
On Tue, 4 Apr 2023 03:18:37 GMT, Leonid Mesnik wrote:
> Test com/sun/jdi/PopAndInvokeTest.java has
> @ignore 6951287
> bug 6951287 is closed as a dup for 6417053 which is closed as not reproduced.
The test fails in tier5 in our CI.
-
PR Comment: https://git.openjdk.org/jdk/pull/13
On Mon, 3 Apr 2023 12:59:12 GMT, Markus Grönlund wrote:
>> src/hotspot/share/prims/agentList.cpp line 204:
>>
>>> 202:
>>> 203: // Invokes Agent_OnAttach for agents loaded dynamically during runtime.
>>> 204: jint AgentList::load_agent(const char* agent_name, const char*
>>> absParam,
>>
>> I
72 matches
Mail list logo
