Re: RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-10 Thread Roger Riggs
On Wed, 8 Mar 2023 11:30:27 GMT, Daniel Jeliński wrote: > This patch modifies the `getLastErrorString` method to return a `jstring`. > Thanks to that we can avoid unnecessary back and forth conversions between > Unicode and other charsets on Windows. > > Other changes include: > - the Windows

Re: RFR: 8303963: Replace various encodings of UINT/SIZE_MAX in gc code

2023-03-10 Thread Kim Barrett
On Fri, 10 Mar 2023 12:58:42 GMT, Thomas Schatzl wrote: > Hi all, > > please review this refactoring that replaces various casts in GC and > more-or-less related to get all bits set in an uint/size_t with the available > constants from cstdint. > The ones in ZGC files were skipped on request

Integrated: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode

2023-03-10 Thread Daniel D . Daugherty
On Fri, 10 Mar 2023 19:53:31 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in > -Xcomp mode This pull request has now been integrated. Changeset: d7f4221b Author:Daniel D. Daugherty URL:

Re: Integrated: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode

2023-03-10 Thread Daniel D . Daugherty
On Fri, 10 Mar 2023 20:01:43 GMT, Roger Riggs wrote: >> A trivial fix to ProblemList >> serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 >> in -Xcomp mode > > Marked as reviewed by rriggs (Reviewer). @RogerRiggs - Thanks for the fast review. - PR: https:

Re: Integrated: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode

2023-03-10 Thread Roger Riggs
On Fri, 10 Mar 2023 19:53:31 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in > -Xcomp mode Marked as reviewed by rriggs (Reviewer). - PR: https://git.openjdk.org/jdk/pull/12983

Integrated: 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode

2023-03-10 Thread Daniel D . Daugherty
A trivial fix to ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in -Xcomp mode - Commit messages: - 8304005: ProblemList serviceability/AsyncGetCallTrace/MyPackage/ASGCTBaseTest.java on linux-x64 in Xcomp mode Changes: https://git.openjdk.

Re: RFR: 8303908: Add missing check in VTMS_transition_disable_for_all() for suspend mode

2023-03-10 Thread Patricio Chilano Mateo
On Fri, 10 Mar 2023 04:34:13 GMT, David Holmes wrote: >> Please review this small fix. A suspender is a JvmtiVTMSTransitionDisabler >> monopolist, meaning VTMS_transition_disable_for_all() should not return >> while there is any active jvmtiVTMSTransitionDisabler. The code though is >> checkin

Re: RFR: 8303908: Add missing check in VTMS_transition_disable_for_all() for suspend mode

2023-03-10 Thread Patricio Chilano Mateo
On Fri, 10 Mar 2023 03:51:05 GMT, Serguei Spitsyn wrote: > This looks good. Thank you for catching and taking care about it! Serguei > Thanks for the review Serguei! - PR: https://git.openjdk.org/jdk/pull/12956

Re: RFR: 8292818: replace 96-bit representation for field metadata with variable-sized streams

2023-03-10 Thread Frederic Parain
On Wed, 8 Mar 2023 16:25:07 GMT, Coleen Phillimore wrote: >> Please review this change re-implementing the FieldInfo data structure. >> >> The FieldInfo array is an old data structure storing fields metadata. It has >> poor extension capabilities, a complex management code because of lack of >

Re: RFR: 8303963: Replace various encodings of UINT/SIZE_MAX in gc code

2023-03-10 Thread Albert Mingkun Yang
On Fri, 10 Mar 2023 12:58:42 GMT, Thomas Schatzl wrote: > Hi all, > > please review this refactoring that replaces various casts in GC > more-or-less related to get all bits set in an uint/size_t with the available > constants from cstdint. > The ones in ZGC files were skipped on request. >

RFR: 8303963: Replace various encodings of UINT/SIZE_MAX in gc code

2023-03-10 Thread Thomas Schatzl
Hi all, please review this refactoring that replaces various casts in GC more-or-less related to get all bits set in an uint/size_t with the available constants from cstdint. The ones in ZGC files were skipped on request. Testing: local compilation, gha Thanks, Thomas - Commi

Re: RFR: 8291555: Implement alternative fast-locking scheme [v21]

2023-03-10 Thread Roman Kennke
> This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mark word. That overloading causes massive problems with Li

Re: RFR: 8291555: Implement alternative fast-locking scheme [v20]

2023-03-10 Thread Roman Kennke
> This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mark word. That overloading causes massive problems with Li

Re: RFR: 8291555: Implement alternative fast-locking scheme [v19]

2023-03-10 Thread Roman Kennke
> This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mark word. That overloading causes massive problems with Li

Re: RFR: 8257967: JFR: Events for loaded agents [v10]

2023-03-10 Thread Markus Grönlund
> Greetings, > > We are adding support to let JFR report on Agents. > > Design > > An Agent is a library that uses any instrumentation or profiling APIs. Most > agents are started and initialized on the command line, but agents can also > be loaded dynamically during runtime. Because comm

Re: RFR: 8291555: Implement alternative fast-locking scheme [v18]

2023-03-10 Thread Roman Kennke
> This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mark word. That overloading causes massive problems with Li

Re: RFR: 8291555: Implement alternative fast-locking scheme [v16]

2023-03-10 Thread Roman Kennke
On Thu, 9 Mar 2023 23:17:39 GMT, Daniel D. Daugherty wrote: >> Roman Kennke has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 99 commits: >> >> - Merge branch 'master' into JDK-8291555-v2 >> - Various small fixes and improvements

Re: RFR: 8291555: Implement alternative fast-locking scheme [v17]

2023-03-10 Thread Roman Kennke
> This change adds a fast-locking scheme as an alternative to the current > stack-locking implementation. It retains the advantages of stack-locking > (namely fast locking in uncontended code-paths), while avoiding the overload > of the mark word. That overloading causes massive problems with Li

Re: RFR: 8303814: getLastErrorString should avoid charset conversions

2023-03-10 Thread Daniel Jeliński
On Thu, 9 Mar 2023 00:17:42 GMT, Naoto Sato wrote: >> This patch modifies the `getLastErrorString` method to return a `jstring`. >> Thanks to that we can avoid unnecessary back and forth conversions between >> Unicode and other charsets on Windows. >> >> Other changes include: >> - the Windows