Integrated: 8303242: ThreadMXBean issues with virtual threads

2023-03-03 Thread Alan Bateman
On Mon, 27 Feb 2023 12:23:09 GMT, Alan Bateman wrote: > This PR covers a number of issues with j.l.management.ThreadMXBean, and the > JDK-specific extension c.s.management.ThreadMXBean, when there are virtual > threads in use. > > As background, ThreadMXBean was re-specified in Java 19 to supp

RFR: 8289765: JDI EventSet/resume/resume008 failed with "ERROR: suspendCounts don't match for : VirtualThread-unparker"

2023-03-03 Thread Chris Plummer
The test failure is caused by the arrival of unexpected ThreadStartEvents, which mess up the debugger side. The events are for threads we normally only see getting created when using virtual threads, such as carrier threads and the VirtualThread-unparker thread. Theoretically this issue could ha

Integrated: JDK-8303587 Remove VMOutOfMemoryError001 test from the problem list after 8303198

2023-03-03 Thread Roger Riggs
On Fri, 3 Mar 2023 16:40:41 GMT, Roger Riggs wrote: > Remove VMOutOfMemoryException001.java from the problem list, after > JDK-8303198. > > The logging of Runtime.exit interfered with out-of-memory exception handling > in this test. > Making the logging more robust in JDK-8303198 by handling e

Re: RFR: 8303527: update for deprecated sprintf for jdk.hotspot.agent [v3]

2023-03-03 Thread Xue-Lei Andrew Fan
On Fri, 3 Mar 2023 18:18:02 GMT, Chris Plummer wrote: > @XueleiFan In the future please get two reviews for all hotspot (and > serviceability) changes. Thanks. Thank you for pointing it out, and the review. - PR: https://git.openjdk.org/jdk/pull/12837

Re: RFR: 8303527: update for deprecated sprintf for jdk.hotspot.agent [v3]

2023-03-03 Thread Chris Plummer
On Fri, 3 Mar 2023 04:19:47 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns. The >> issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building >> failu

Integrated: 8303527: update for deprecated sprintf for jdk.hotspot.agent

2023-03-03 Thread Xue-Lei Andrew Fan
On Thu, 2 Mar 2023 19:17:40 GMT, Xue-Lei Andrew Fan wrote: > Hi, > > May I have this update reviewed? > > The sprintf is deprecated in Xcode 14 because of security concerns. The issue > was addressed in [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) > for building failure, and >

Re: RFR: 8303489: Add a test to verify classes in vmStruct have unique vtables [v3]

2023-03-03 Thread Chris Plummer
On Fri, 3 Mar 2023 02:28:32 GMT, Alex Menkov wrote: >> Unique vtables for classes in vmStruct data is a requirement for SA to >> correctly detect hotspot classes. >> The fix adds test to verify this requirement. >> >> The test fails as expected on Windows if VM is built without RTTI (see >> JD

Integrated: 8303523: Cleanup problem listing of nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java

2023-03-03 Thread Chris Plummer
On Thu, 2 Mar 2023 17:30:07 GMT, Chris Plummer wrote: > attach002a is problem listed under > [JDK-8277812](https://bugs.openjdk.org/browse/JDK-8277812), which has been > closed as a dup of > [JDK-8277573](https://bugs.openjdk.org/browse/JDK-8277573), so its problem > list entry should be upda

Re: RFR: 8303534: Merge CompactibleSpace into ContiguousSpace [v2]

2023-03-03 Thread Chris Plummer
On Fri, 3 Mar 2023 12:30:38 GMT, Albert Mingkun Yang wrote: >> Simple refactoring of merging two types. >> >> Test: tier1-5 > > Albert Mingkun Yang has updated the pull request incrementally with one > additional commit since the last revision: > > copyright-year SA changes look good.

Re: RFR: 8303527: update for deprecated sprintf for jdk.hotspot.agent [v3]

2023-03-03 Thread Chris Plummer
On Fri, 3 Mar 2023 04:19:47 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> May I have this update reviewed? >> >> The sprintf is deprecated in Xcode 14 because of security concerns. The >> issue was addressed in >> [JDK-8296812](https://bugs.openjdk.org/browse/JDK-8296812) for building >> failu

Re: RFR: 8303242: ThreadMXBean issues with virtual threads [v4]

2023-03-03 Thread Patricio Chilano Mateo
On Thu, 2 Mar 2023 08:18:03 GMT, Alan Bateman wrote: >> This PR covers a number of issues with j.l.management.ThreadMXBean, and the >> JDK-specific extension c.s.management.ThreadMXBean, when there are virtual >> threads in use. >> >> As background, ThreadMXBean was re-specified in Java 19 to

Re: RFR: JDK-8303587 Remove VMOutOfMemoryError001 test from the problem list after 8303198

2023-03-03 Thread Chris Plummer
On Fri, 3 Mar 2023 16:40:41 GMT, Roger Riggs wrote: > Remove VMOutOfMemoryException001.java from the problem list, after > JDK-8303198. > > The logging of Runtime.exit interfered with out-of-memory exception handling > in this test. > Making the logging more robust in JDK-8303198 by handling e

RFR: JDK-8303587 Remove VMOutOfMemoryError001 test from the problem list after 8303198

2023-03-03 Thread Roger Riggs
Remove VMOutOfMemoryException001.java from the problem list, after JDK-8303198. The logging of Runtime.exit interfered with out-of-memory exception handling in this test. Making the logging more robust in JDK-8303198 by handling exceptions restores the conditions expected by this test.

Re: RFR: 8303151: DCmd framework cleanups

2023-03-03 Thread Johan Sjölen
On Fri, 3 Mar 2023 04:59:44 GMT, David Holmes wrote: > Whilst working on the DCmd code I noticed two items that could be cleaned up: > > 1. The `NMTDCmd` is registered after the call to `register_dcmds()` instead > of inside it. > > 2. The "extension" mechanism to define external DCmds (as add

Re: RFR: 8303534: Merge CompactibleSpace into ContiguousSpace [v2]

2023-03-03 Thread Albert Mingkun Yang
> Simple refactoring of merging two types. > > Test: tier1-5 Albert Mingkun Yang has updated the pull request incrementally with one additional commit since the last revision: copyright-year - Changes: - all: https://git.openjdk.org/jdk/pull/12841/files - new: https://git.op

Re: RFR: 8303523: Cleanup problem listing of nsk/jvmti/AttachOnDemand/attach002a/TestDescription.java

2023-03-03 Thread Kevin Walls
On Thu, 2 Mar 2023 17:30:07 GMT, Chris Plummer wrote: > attach002a is problem listed under > [JDK-8277812](https://bugs.openjdk.org/browse/JDK-8277812), which has been > closed as a dup of > [JDK-8277573](https://bugs.openjdk.org/browse/JDK-8277573), so its problem > list entry should be upda

Re: RFR: 8298966: Deprecate JMX Subject Delegation and the method JMXConnector.getMBeanServerConnection(Subject) for removal.

2023-03-03 Thread Kevin Walls
On Fri, 6 Jan 2023 12:02:37 GMT, Kevin Walls wrote: > Deprecate the Java Management Extension (JMX) Subject Delegation feature for > removal in a future release. > > Given no known usage, there is no replacement feature for JMX Subject > Delegation. > > CSR is https://bugs.openjdk.org/browse/

Re: RFR: 8298966: Deprecate JMX Subject Delegation and the method JMXConnector.getMBeanServerConnection(Subject) for removal. [v2]

2023-03-03 Thread Kevin Walls
> Deprecate the Java Management Extension (JMX) Subject Delegation feature for > removal in a future release. > > Given no known usage, there is no replacement feature for JMX Subject > Delegation. > > CSR is https://bugs.openjdk.org/browse/JDK-8298967 Kevin Walls has updated the pull request

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Alexey Ivanov
On Fri, 3 Mar 2023 10:09:27 GMT, Claes Redestad wrote: > Yes, iff means if-and-only-if and is used for extra precision in formal > logic, mathematics. I've never come across it before. With your explanations, it makes perfect sense. - PR: https://git.openjdk.org/jdk/pull/12826

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Claes Redestad
On Fri, 3 Mar 2023 09:38:13 GMT, Pavel Rappo wrote: >> src/java.base/share/classes/java/lang/invoke/BootstrapMethodInvoker.java >> line 257: >> >>> 255: >>> 256: /** >>> 257: * @return true iff the BSM method type exactly matches >> >> I assume “iff” should “if”? > > Here and elsewhe

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Pavel Rappo
On Fri, 3 Mar 2023 08:15:49 GMT, Alexey Ivanov wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Pavel Rappo
On Thu, 2 Mar 2023 16:23:17 GMT, Alexey Ivanov wrote: >> Please review this superficial documentation cleanup that was triggered by >> unrelated analysis of doc comments in JDK API. >> >> The only effect that this multi-area PR has on the JDK API Documentation >> (i.e. the observable effect on

Re: RFR: 8303480: Miscellaneous fixes to mostly invisible doc comments

2023-03-03 Thread Alexey Ivanov
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote: > Please review this superficial documentation cleanup that was triggered by > unrelated analysis of doc comments in JDK API. > > The only effect that this multi-area PR has on the JDK API Documentation > (i.e. the observable effect on the ge