On Thu, 2 Mar 2023 02:41:12 GMT, Alex Menkov wrote:
> Unique vtables for classes in vmStruct data is a requirement for SA to
> correctly detect hotspot classes.
> The fix adds test to verify this requirement.
>
> The test fails as expected on Windows if VM is built without RTTI (see
> JDK-8302
On Fri, 21 Oct 2022 21:45:30 GMT, Bill Huang wrote:
> The current non local registry tests require a manual process that runs
> rmiregitrty on a different machine and changes the -Dregistry.host property
> in the source before running the tests on the local machine. This task is
> created to i
Unique vtables for classes in vmStruct data is a requirement for SA to
correctly detect hotspot classes.
The fix adds test to verify this requirement.
The test fails as expected on Windows if VM is built without RTTI (see
JDK-8302817)
-
Commit messages:
- UniqueVtableTest
Changes
> While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765),
> I ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so much
> so that the changes distract from the actual bug fix, so I decided it would
> be best to first push them with a separate CR. Changes in
On Wed, 1 Mar 2023 21:35:34 GMT, Chris Plummer wrote:
>> Well, I am not going to insist.
>
> The following doc (and I have no idea how "official" it is since it is 25
> years old):
>
> https://www.oracle.com/technetwork/java/codeconventions-150003.pdf
>
> Says to indent the 2nd and 3rd lines b
On Wed, 1 Mar 2023 12:39:52 GMT, Alan Bateman wrote:
>> This PR covers a number of issues with j.l.management.ThreadMXBean, and the
>> JDK-specific extension c.s.management.ThreadMXBean, when there are virtual
>> threads in use.
>>
>> As background, ThreadMXBean was re-specified in Java 19 to
On Wed, 1 Mar 2023 11:40:26 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/management/ThreadMXBean/VirtualThreads.java line 258:
>>
>>> 256: long tid = Thread.currentThread().threadId();
>>> 257: long cpuTime = bean.getThreadCpuTime(tid);
>>> 258: assertEquals
On Wed, 1 Mar 2023 12:39:52 GMT, Alan Bateman wrote:
>> This PR covers a number of issues with j.l.management.ThreadMXBean, and the
>> JDK-specific extension c.s.management.ThreadMXBean, when there are virtual
>> threads in use.
>>
>> As background, ThreadMXBean was re-specified in Java 19 to
On Wed, 1 Mar 2023 21:12:20 GMT, Leonid Mesnik wrote:
>> I find that much less readable since the 2nd and 3rd lines of the `if`
>> expression are indented the same as the first statement that follows.
>> Previously they had added a blank line to resolve this, but I don't like
>> that either. Y
On Wed, 1 Mar 2023 21:02:50 GMT, Chris Plummer wrote:
>> Just as it was before.
>> if (event instanceof ExceptionEvent &&
>> defaultExceptionRequest != null &&
>> defaultExceptionRequest.equals(event.request())) {
>
> I find that much less readable since the 2nd and 3rd lines of the `
On Wed, 15 Feb 2023 00:13:22 GMT, Chris Plummer wrote:
> While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765),
> I ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so much
> so that the changes distract from the actual bug fix, so I decided it would
>
On Wed, 1 Mar 2023 20:57:24 GMT, Leonid Mesnik wrote:
>> How would you recommend doing it? Is there a style guide that covers this (I
>> can never find it when I need it).
>
> Just as it was before.
> if (event instanceof ExceptionEvent &&
> defaultExceptionRequest != null &&
> defau
On Wed, 1 Mar 2023 19:48:36 GMT, Chris Plummer wrote:
>> test/hotspot/jtreg/vmTestbase/nsk/share/jdi/EventHandler.java line 336:
>>
>>> 334: defaultExceptionRequest != null &&
>>> 335: defaultExceptionRequest.equals(event.request()))
>>> 336:
On Wed, 1 Mar 2023 15:59:57 GMT, Leonid Mesnik wrote:
>> While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765),
>> I ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so
>> much so that the changes distract from the actual bug fix, so I decided it
>> wou
On Wed, 15 Feb 2023 00:13:22 GMT, Chris Plummer wrote:
> While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765),
> I ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so much
> so that the changes distract from the actual bug fix, so I decided it would
>
On Wed, 15 Feb 2023 00:13:22 GMT, Chris Plummer wrote:
> While working on [JDK-8289765](https://bugs.openjdk.org/browse/JDK-8289765),
> I ended up doing a lot of cleanup of nsk/share/jdi/EventHandler.java, so much
> so that the changes distract from the actual bug fix, so I decided it would
>
On Tue, 28 Feb 2023 20:49:51 GMT, Mandy Chung wrote:
>> Alan Bateman has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update isXXXThreadCpuTimeSupported descriptions
>
> src/java.management/share/classes/java/lang/management/ThreadMXBean.
> This PR covers a number of issues with j.l.management.ThreadMXBean, and the
> JDK-specific extension c.s.management.ThreadMXBean, when there are virtual
> threads in use.
>
> As background, ThreadMXBean was re-specified in Java 19 to support the
> monitoring and management of platform threads
On Tue, 28 Feb 2023 21:06:19 GMT, Mandy Chung wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits
> This PR covers a number of issues with j.l.management.ThreadMXBean, and the
> JDK-specific extension c.s.management.ThreadMXBean, when there are virtual
> threads in use.
>
> As background, ThreadMXBean was re-specified in Java 19 to support the
> monitoring and management of platform threads
20 matches
Mail list logo
