Re: RFR: 8302870: More information needed from failures in vmTestbase ThreadUtils.waitThreadState [v2]

2023-02-21 Thread David Holmes
On Tue, 21 Feb 2023 09:09:43 GMT, Kevin Walls wrote: >> Test update to make failures such as JDK-8076494 more informative. >> >> Waiting for a thread to change state: give more time (to distinguish a real >> deadlock from some other delay), and log the thread stackframes when the >> expected s

Integrated: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint

2023-02-21 Thread Serguei Spitsyn
On Tue, 14 Feb 2023 05:37:51 GMT, Serguei Spitsyn wrote: > The rank of JvmtiVTMSTransition_lock is better to be safepoint instead of > nosafepoint. > The fix includes removal of the function > `check_vthread_and_suspend_at_safepoint` which is not needed anymore. > > Testing: > mach5 jobs are i

Re: RFR: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint [v2]

2023-02-21 Thread Serguei Spitsyn
> The rank of JvmtiVTMSTransition_lock is better to be safepoint instead of > nosafepoint. > The fix includes removal of the function > `check_vthread_and_suspend_at_safepoint` which is not needed anymore. > > Testing: > mach5 jobs are in progress: > Kitchensink, tiers1-6 (all JVMTI, JDWP, JDI

Re: RFR: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint

2023-02-21 Thread Serguei Spitsyn
On Tue, 21 Feb 2023 17:57:36 GMT, Patricio Chilano Mateo wrote: >> The rank of JvmtiVTMSTransition_lock is better to be safepoint instead of >> nosafepoint. >> The fix includes removal of the function >> `check_vthread_and_suspend_at_safepoint` which is not needed anymore. >> >> Testing: >> m

Re: RFR: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint

2023-02-21 Thread Serguei Spitsyn
On Tue, 21 Feb 2023 14:45:13 GMT, Coleen Phillimore wrote: >> src/hotspot/share/prims/jvmtiEnv.cpp line 932: >> >>> 930: JavaThread* current = JavaThread::current(); >>> 931: HandleMark hm(current); >>> 932: Handle self_tobj = Handle(current, nullptr); >> >> This doesn't have to have the

Re: RFR: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint

2023-02-21 Thread Serguei Spitsyn
On Tue, 14 Feb 2023 05:37:51 GMT, Serguei Spitsyn wrote: > The rank of JvmtiVTMSTransition_lock is better to be safepoint instead of > nosafepoint. > The fix includes removal of the function > `check_vthread_and_suspend_at_safepoint` which is not needed anymore. > > Testing: > mach5 jobs are i

Re: RFR: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint

2023-02-21 Thread Patricio Chilano Mateo
On Tue, 14 Feb 2023 05:37:51 GMT, Serguei Spitsyn wrote: > The rank of JvmtiVTMSTransition_lock is better to be safepoint instead of > nosafepoint. > The fix includes removal of the function > `check_vthread_and_suspend_at_safepoint` which is not needed anymore. > > Testing: > mach5 jobs are i

Re: RFR: 8300575: JVMTI support when using alternative virtual thread implementation [v7]

2023-02-21 Thread Patricio Chilano Mateo
On Sat, 18 Feb 2023 07:56:25 GMT, Alan Bateman wrote: >>> Thanks for dropping is_bound_vthread, I think it's much better now. What >>> would you think about changing it to test the thread type is_a >>> vmClasses::BaseVirtualThread_klass() so the VM doesn't need to know about >>> ThreadBuilders

Re: RFR: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint

2023-02-21 Thread Coleen Phillimore
On Tue, 21 Feb 2023 14:38:21 GMT, Coleen Phillimore wrote: >> The rank of JvmtiVTMSTransition_lock is better to be safepoint instead of >> nosafepoint. >> The fix includes removal of the function >> `check_vthread_and_suspend_at_safepoint` which is not needed anymore. >> >> Testing: >> mach5 j

Re: RFR: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint

2023-02-21 Thread Coleen Phillimore
On Tue, 14 Feb 2023 05:37:51 GMT, Serguei Spitsyn wrote: > The rank of JvmtiVTMSTransition_lock is better to be safepoint instead of > nosafepoint. > The fix includes removal of the function > `check_vthread_and_suspend_at_safepoint` which is not needed anymore. > > Testing: > mach5 jobs are i

Integrated: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test

2023-02-21 Thread Johannes Bechberger
On Mon, 13 Feb 2023 14:39:00 GMT, Johannes Bechberger wrote: > Extends the existing AsyncGetCallTrace test case and fixes the issue. This pull request has now been integrated. Changeset: db483a38 Author:Johannes Bechberger Committer: Jorn Vernee URL: https://git.openjdk.org/jdk/com

Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v6]

2023-02-21 Thread Jorn Vernee
On Tue, 21 Feb 2023 08:58:50 GMT, Johannes Bechberger wrote: >> Extends the existing AsyncGetCallTrace test case and fixes the issue. > > Johannes Bechberger has updated the pull request incrementally with one > additional commit since the last revision: > > Update full name Testing looks go

Re: RFR: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint

2023-02-21 Thread Serguei Spitsyn
On Tue, 14 Feb 2023 05:37:51 GMT, Serguei Spitsyn wrote: > The rank of JvmtiVTMSTransition_lock is better to be safepoint instead of > nosafepoint. > The fix includes removal of the function > `check_vthread_and_suspend_at_safepoint` which is not needed anymore. > > Testing: > mach5 jobs are i

Re: RFR: 8302870: More information needed from failures in vmTestbase ThreadUtils.waitThreadState [v2]

2023-02-21 Thread Kevin Walls
On Tue, 21 Feb 2023 09:09:43 GMT, Kevin Walls wrote: >> Test update to make failures such as JDK-8076494 more informative. >> >> Waiting for a thread to change state: give more time (to distinguish a real >> deadlock from some other delay), and log the thread stackframes when the >> expected s

Re: RFR: 8302870: More information needed from failures in vmTestbase ThreadUtils.waitThreadState [v2]

2023-02-21 Thread Kevin Walls
> Test update to make failures such as JDK-8076494 more informative. > > Waiting for a thread to change state: give more time (to distinguish a real > deadlock from some other delay), and log the thread stackframes when the > expected state change is not observed. Kevin Walls has updated the pu

Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v6]

2023-02-21 Thread Johannes Bechberger
> Extends the existing AsyncGetCallTrace test case and fixes the issue. Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Update full name - Changes: - all: https://git.openjdk.org/jdk/pull/12535/files - new: ht