Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v5]

2023-02-20 Thread Richard Reingruber
On Mon, 20 Feb 2023 09:18:46 GMT, Johannes Bechberger wrote: >> Extends the existing AsyncGetCallTrace test case and fixes the issue. > > Johannes Bechberger has updated the pull request incrementally with one > additional commit since the last revision: > > Improve condition again Looks goo

Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v5]

2023-02-20 Thread David Holmes
On Mon, 20 Feb 2023 09:18:46 GMT, Johannes Bechberger wrote: >> Extends the existing AsyncGetCallTrace test case and fixes the issue. > > Johannes Bechberger has updated the pull request incrementally with one > additional commit since the last revision: > > Improve condition again The lates

Re: RFR: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint

2023-02-20 Thread David Holmes
On Sat, 18 Feb 2023 01:33:16 GMT, Serguei Spitsyn wrote: >> Thank you for looking at this PR, David! >> Please, note a disabler at L938. A safepont can be reached in its destructor. >> Also, see the comment at L952: >> >> 937 { >> 938 JvmtiVTMSTransitionDisabler disabler(true); >> 939

Re: RFR: 8299240: rank of JvmtiVTMSTransition_lock can be safepoint

2023-02-20 Thread David Holmes
On Tue, 14 Feb 2023 05:37:51 GMT, Serguei Spitsyn wrote: > The rank of JvmtiVTMSTransition_lock is better to be safepoint instead of > nosafepoint. > The fix includes removal of the function > `check_vthread_and_suspend_at_safepoint` which is not needed anymore. > > Testing: > mach5 jobs are i

Re: RFR: 8302870: More information needed from failures in vmTestbase ThreadUtils.waitThreadState

2023-02-20 Thread David Holmes
On Mon, 20 Feb 2023 22:30:30 GMT, David Holmes wrote: >> Test update to make failures such as JDK-8076494 more informative. >> >> Waiting for a thread to change state: give more time (to distinguish a real >> deadlock from some other delay), and log the thread stackframes when the >> expected

Re: RFR: 8302870: More information needed from failures in vmTestbase ThreadUtils.waitThreadState

2023-02-20 Thread David Holmes
On Mon, 20 Feb 2023 12:54:06 GMT, Kevin Walls wrote: > Test update to make failures such as JDK-8076494 more informative. > > Waiting for a thread to change state: give more time (to distinguish a real > deadlock from some other delay), and log the thread stackframes when the > expected state

Integrated: 8299234: JMX Repository.query performance

2023-02-20 Thread Alexey Bakhtin
On Wed, 21 Dec 2022 18:50:52 GMT, Alexey Bakhtin wrote: > Please find a patch to improve JMX Repository.query performance > > Using ObjectName.apply() allows significantly decrease memory usage and the > number of GC cycles: > Before: > > $ java test 100 100 > Test PASSED in 8943169791

Re: RFR: 8299234: JMX Repository.query performance [v6]

2023-02-20 Thread Daniel Fuchs
On Fri, 17 Feb 2023 18:25:10 GMT, Alexey Bakhtin wrote: >> Please find a patch to improve JMX Repository.query performance >> >> Using ObjectName.apply() allows significantly decrease memory usage and the >> number of GC cycles: >> Before: >> >> $ java test 100 100 >> Test PASSED in 89

RFR: 8302870: More information needed from failures in vmTestbase ThreadUtils.waitThreadState

2023-02-20 Thread Kevin Walls
Test update to make failures such as JDK-8076494 more informative. Waiting for a thread to change state: give more time (to distinguish a real deadlock from some other delay), and log the thread stackframes when the expected state change is not observed. - Commit messages: - impor

Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v5]

2023-02-20 Thread Jorn Vernee
On Mon, 20 Feb 2023 09:18:46 GMT, Johannes Bechberger wrote: >> Extends the existing AsyncGetCallTrace test case and fixes the issue. > > Johannes Bechberger has updated the pull request incrementally with one > additional commit since the last revision: > > Improve condition again The new c

Re: RFR: 8299234: JMX Repository.query performance [v5]

2023-02-20 Thread Serguei Spitsyn
On Fri, 17 Feb 2023 17:33:19 GMT, Kevin Walls wrote: >> Alexey Bakhtin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Optimize ObjectName.matchDomains > > Yes, I think it looks good. > I looked a while ago but it was somewhat unfamiliar

Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v3]

2023-02-20 Thread Johannes Bechberger
On Mon, 20 Feb 2023 09:11:38 GMT, Johannes Bechberger wrote: >> Probably it's better to adapt the limit though (sorry). >> Problem with this version is that it allows `unextended_sp` outside the >> address range reserved for the stack. Let's see what other reviewers think. >> Suggestion: >> >>

Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v5]

2023-02-20 Thread Johannes Bechberger
> Extends the existing AsyncGetCallTrace test case and fixes the issue. Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Improve condition again - Changes: - all: https://git.openjdk.org/jdk/pull/12535/files -

Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v3]

2023-02-20 Thread Johannes Bechberger
On Mon, 20 Feb 2023 09:08:59 GMT, Richard Reingruber wrote: >> ... and no regression in the other serviceability tests. > > Probably it's better to adapt the limit though (sorry). > Problem with this version is that it allows `unextended_sp` outside the > address range reserved for the stack. Le

Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v3]

2023-02-20 Thread Richard Reingruber
On Mon, 20 Feb 2023 09:04:39 GMT, Johannes Bechberger wrote: >> The sanity test worked :) > > ... and no regression in the other serviceability tests. Probably it's better to adapt the limit though (sorry). Problem with this version is that it allows `unextended_sp` outside the address range re

Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v3]

2023-02-20 Thread Johannes Bechberger
On Mon, 20 Feb 2023 09:00:28 GMT, Johannes Bechberger wrote: >> src/hotspot/cpu/x86/frame_x86.cpp line 75: >> >>> 73: // interpreted -> interpreted calls that go through a method handle >>> linker, >>> 74: // since those pop the last argument (the appendix) from the stack. >>> 75: if (!th

Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v4]

2023-02-20 Thread Johannes Bechberger
> Extends the existing AsyncGetCallTrace test case and fixes the issue. Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision: Improve condition - Changes: - all: https://git.openjdk.org/jdk/pull/12535/files - new: h

Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v3]

2023-02-20 Thread Johannes Bechberger
On Mon, 20 Feb 2023 08:46:43 GMT, Richard Reingruber wrote: >> Johannes Bechberger has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Revert previous change > > src/hotspot/cpu/x86/frame_x86.cpp line 75: > >> 73: // interpreted -> interp

Re: RFR: JDK-8302320: AsyncGetCallTrace obtains too few frames in sanity test [v3]

2023-02-20 Thread Richard Reingruber
On Fri, 17 Feb 2023 14:47:56 GMT, Johannes Bechberger wrote: >> Extends the existing AsyncGetCallTrace test case and fixes the issue. > > Johannes Bechberger has updated the pull request incrementally with one > additional commit since the last revision: > > Revert previous change src/hotspo

Re: RFR: 8299234: JMX Repository.query performance [v5]

2023-02-20 Thread Alexey Bakhtin
On Fri, 17 Feb 2023 17:33:19 GMT, Kevin Walls wrote: >> Alexey Bakhtin has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Optimize ObjectName.matchDomains > > Yes, I think it looks good. > I looked a while ago but it was somewhat unfamiliar