On Wed, 8 Feb 2023 04:22:16 GMT, Chris Plummer wrote:
>> A number of tests that use JDI invokeMethod() support occasionally fail when
>> run using virtual threads. The tests fail with:
>>
>>
>> # ERROR: TEST FAILED: wrong invocation:
>> # ERROR: invoking debuggee thread instance of
>> java.la
On Sat, 24 Dec 2022 04:14:07 GMT, Serguei Spitsyn wrote:
>> Now the `JvmtiVTMSTransitionDisabler` mechanism supports disabling VTMS
>> transitions for all virtual threads only. It should also support disabling
>> transitions for any specific virtual thread as well. This will improve
>> scalabi
On Wed, 8 Feb 2023 11:57:21 GMT, Kevin Walls wrote:
> NotifReconnectDeadlockTest.java has been problemlisted for a long time
> (although 8042215 is the wrong bug id).
>
> The originally reported problem ("No reconnection happened") cannot be
> reproduced, although there are occasional failures
On Fri, 6 Jan 2023 13:11:41 GMT, Kevin Walls wrote:
> Exceptions during setup of these tests could leave e.g. JMXConnector cs as
> null.
> But, we call cs.close() during a finally block and fail with an NPE,
> obscuring the real failure.
> We must only call close if this is not null.
Marked as
On Sat, 4 Feb 2023 08:59:29 GMT, Alan Bateman wrote:
> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
> We'd like to convert these JUnit in the main line in advance of other updates
> to these tests in 21. The changes are mostly mechanical and trivial:
>
> - Befor
On Fri, 6 Jan 2023 13:11:41 GMT, Kevin Walls wrote:
> Exceptions during setup of these tests could leave e.g. JMXConnector cs as
> null.
> But, we call cs.close() during a finally block and fail with an NPE,
> obscuring the real failure.
> We must only call close if this is not null.
Yes, that
On Wed, 8 Feb 2023 12:25:30 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 12:19:02 GMT, Alan Bateman wrote:
>> test/jdk/java/lang/Thread/virtual/HoldsLock.java line 131:
>>
>>> 129: assertEquals(vthread.getClass().getName(),
>>> info.getLockInfo().getClassName());
>>> 130: assertTrue(info.getLockInfo().getIdentityHas
NotifReconnectDeadlockTest.java has been problemlisted for a long time
(although 8042215 is the wrong bug id).
The originally reported problem ("No reconnection happened") cannot be
reproduced, although there are occasional failures when the test is run.
Those failures are more like the connect
On Wed, 8 Feb 2023 12:18:12 GMT, Alan Bateman wrote:
> note that it impacts 45+ usages and I had hoped to avoid changing the tests
> too much.
I hadn't realized this construct was used in multiple other places. I see that
you already fixed them in a newer commit in this PR; thank you.
---
On Wed, 8 Feb 2023 09:39:21 GMT, Jaikiran Pai wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Merge
>> - Merge
>> - Fix typos in comments
>> - GetStackTrace.java test missing @requi
> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
> We'd like to convert these JUnit in the main line in advance of other updates
> to these tests in 21. The changes are mostly mechanical and trivial:
>
> - BeforeClass/AfterClass changed to static BeforeAll/AfterAll
On Wed, 8 Feb 2023 09:47:00 GMT, Alan Bateman wrote:
> as the alternative implementation of virtual threads (used on x86_32 and a
> few other ports) don't allow custom schedulers.
Thank you for that detail.
-
PR: https://git.openjdk.org/jdk/pull/12426
On Wed, 8 Feb 2023 10:37:16 GMT, Jaikiran Pai wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Merge
>> - Merge
>> - Fix typos in comments
>> - GetStackTrace.java test missing @requi
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
> We'd like to convert these JUnit in the main line in advance of other updates
> to these tests in 21. The changes are mostly mechanical and trivial:
>
> - BeforeClass/AfterClass changed to static BeforeAll/AfterAll
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 09:49:17 GMT, Jaikiran Pai wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Merge
>> - Merge
>> - Fix typos in comments
>> - GetStackTrace.java test missing @requi
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 09:39:37 GMT, Christian Stein wrote:
>> test/jdk/java/lang/Thread/virtual/GetStackTrace.java line 31:
>>
>>> 29: * @enablePreview
>>> 30: * @modules java.base/java.lang:+open
>>> 31: * @run main GetStackTrace
>>
>> That's interesting - so this test was marked as a testng t
On Wed, 8 Feb 2023 09:22:36 GMT, Jaikiran Pai wrote:
>> test/jdk/java/lang/Thread/BuilderTest.java line 294:
>>
>>> 292: void testPriority3() {
>>> 293: Thread currentThread = Thread.currentThread();
>>> 294: assumeFalse(currentThread.isVirtual(), "Main test is a virtual
>>>
On Wed, 8 Feb 2023 09:32:49 GMT, Jaikiran Pai wrote:
> I wonder if testng (and junit) can be configured to fail the test if no test
> methods were present, to flag such mistakes.
JUnit's CLI tool has:
`--fail-if-no-tests Fail and return exit status code 2 if no tests are
found.`
We can a
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
On Wed, 8 Feb 2023 09:13:37 GMT, Jaikiran Pai wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains five commits:
>>
>> - Merge
>> - Merge
>> - Fix typos in comments
>> - GetStackTrace.java test missing @requi
On Wed, 8 Feb 2023 08:14:33 GMT, Alan Bateman wrote:
>> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
>> We'd like to convert these JUnit in the main line in advance of other
>> updates to these tests in 21. The changes are mostly mechanical and trivial:
>>
>> -
> The non-hotspot tests integrated with JEP 425/428 were mostly TestNG tests.
> We'd like to convert these JUnit in the main line in advance of other updates
> to these tests in 21. The changes are mostly mechanical and trivial:
>
> - BeforeClass/AfterClass changed to static BeforeAll/AfterAll
29 matches
Mail list logo
