Re: RFR: 8299915: Remove ArrayAllocatorMallocLimit and associated code [v4]

2023-01-20 Thread Tyler Steele
On Wed, 11 Jan 2023 18:10:47 GMT, Justin King wrote: > This leaves at least AIX as a potential problem. @backwaterred, does the AIX > libc malloc() still exclusively use the data segment? Does free'd memory > still stick to the process? I agree with @coleenp that AIX seems to still use the dat

Integrated: 8300721: Cleanup ProblemList-svc-vthread.txt

2023-01-20 Thread Chris Plummer
On Fri, 20 Jan 2023 02:12:43 GMT, Chris Plummer wrote: > There are a number of entries in ProblemList-svc-vthread.txt that don't have > any CRs associated with them. CRs have since been created and the problemlist > needs to be updated to reflect this. Here are links to the relevant CRs: > > [

Re: RFR: 8300721: Cleanup ProblemList-svc-vthread.txt

2023-01-20 Thread Leonid Mesnik
On Fri, 20 Jan 2023 02:12:43 GMT, Chris Plummer wrote: > There are a number of entries in ProblemList-svc-vthread.txt that don't have > any CRs associated with them. CRs have since been created and the problemlist > needs to be updated to reflect this. Here are links to the relevant CRs: > > [

Re: RFR: 8299635: Hotspot update for deprecated sprintf in Xcode 14 [v8]

2023-01-20 Thread Xue-Lei Andrew Fan
On Fri, 20 Jan 2023 04:39:13 GMT, David Holmes wrote: > Nothing further from me. I think this is okay as-is now. Thanks. @dholmes-ora Thank you for the review! - PR: https://git.openjdk.org/jdk/pull/11935

Re: RFR: 8299635: Hotspot update for deprecated sprintf in Xcode 14

2023-01-20 Thread Xue-Lei Andrew Fan
On Fri, 13 Jan 2023 08:00:55 GMT, Serguei Spitsyn wrote: >>> > I'm also curious: some of the sprintfs are C2 (src/hotspot/share/opto) - >>> > are your builds including C2? If so, why are you not running into the >>> > issue for those files? >>> >>> I'm new to hotspot. Do you know how could I e

Re: RFR: 8300721: Cleanup ProblemList-svc-vthread.txt

2023-01-20 Thread Alan Bateman
On Fri, 20 Jan 2023 02:12:43 GMT, Chris Plummer wrote: > There are a number of entries in ProblemList-svc-vthread.txt that don't have > any CRs associated with them. CRs have since been created and the problemlist > needs to be updated to reflect this. Here are links to the relevant CRs: > > [

RFR: 8300721: Cleanup ProblemList-svc-vthread.txt

2023-01-20 Thread Chris Plummer
There are a number of entries in ProblemList-svc-vthread.txt that don't have any CRs associated with them. CRs have since been created and the problemlist needs to be updated to reflect this. Here are links to the relevant CRs: [JDK-8285414](https://bugs.openjdk.org/browse/JDK-8285414): [LOOM] S

Re: RFR: 8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values [v2]

2023-01-20 Thread Severin Gehwolf
On Thu, 19 Jan 2023 17:24:57 GMT, Severin Gehwolf wrote: >> Please review this refactoring of a container test. It now uses WhiteBox to >> retrieve the host values it asserts for. In terms of functionality this is >> basically a no-op except for the now more precise assertion on systems with >

Re: RFR: JDK-8300245: Replace NULL with nullptr in share/jfr/

2023-01-20 Thread Markus Grönlund
On Thu, 19 Jan 2023 20:44:33 GMT, Johan Sjölen wrote: >> Do the conversion in the share/jfr/ sub-directory and all of its files. > > src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp line 1157: > >> 1155: const int orig_stream_length = orig_stream->length(); >> 1156: // allo

Re: RFR: 8300659: Refactor TestMemoryAwareness to use WhiteBox api for host values [v2]

2023-01-20 Thread Severin Gehwolf
On Thu, 19 Jan 2023 17:24:57 GMT, Severin Gehwolf wrote: >> Please review this refactoring of a container test. It now uses WhiteBox to >> retrieve the host values it asserts for. In terms of functionality this is >> basically a no-op except for the now more precise assertion on systems with >

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-20 Thread Boris Ulasevich
On Tue, 17 Jan 2023 08:57:35 GMT, Fredrik Bredberg wrote: > Hi @bulasevich, can you verify that this PR works on Arm32? ARM32 part LGTM. Test results are fine. Thanks! - PR: https://git.openjdk.org/jdk/pull/11902

Re: RFR: 8299795: Relativize locals in interpreter frames [v4]

2023-01-20 Thread Robbin Ehn
On Tue, 17 Jan 2023 17:34:53 GMT, Andrew Haley wrote: >> Fredrik Bredberg has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains five additional >> com