Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-06 Thread Archie L . Cobbs
On Fri, 6 Jan 2023 15:38:31 GMT, Alan Bateman wrote: >>> The associated JBS issue has been dormant for 6+ years and this is a very >>> intrusive change affecting many, many files. Has the resurrection of this >>> project previously been discussed somewhere? >> >> Hi @dholmes-ora, >> >> The wo

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor [v2]

2023-01-06 Thread Archie L . Cobbs
> This PR adds a new lint warning category `this-escape`. > > It also adds `@SuppressWarnings` annotations as needed to the JDK itself to > allow the JDK to continue to compile with `-Xlint:all`. > > A 'this' escape warning is generated for a constructor `A()` in a class `A` > when the compiler

Re: RFR: 8299593: getprotobyname should not be used

2023-01-06 Thread Chris Plummer
On Wed, 4 Jan 2023 12:56:18 GMT, Daniel JeliƄski wrote: > Please review this patch that removes the remaining uses of non-reentrant > `getprotobyname` function. > > While the protocol number for TCP could theoretically be modified to > something other than the default `IPPROTO_TCP`, that scena

Re: RFR: 8299518: HotSpotVirtualMachine shared code across different platforms [v3]

2023-01-06 Thread Chris Plummer
On Thu, 5 Jan 2023 03:32:21 GMT, Yi Yang wrote: >> harmless refactor to share code across different platforms of >> VirtualMachineImpl: >> 1. Shared code to process command response after requesting a command >> execution >> 2. Read functionality in SocketInputStream can be reused > > Yi Yang h

Re: RFR: 8299739: HashedPasswordFileTest.java and ExceptionTest.java can fail with java.lang.NullPointerException

2023-01-06 Thread Chris Plummer
On Fri, 6 Jan 2023 13:11:41 GMT, Kevin Walls wrote: > Exceptions during setup of these tests could leave e.g. JMXConnector cs as > null. > But, we call cs.close() during a finally block and fail with an NPE, > obscuring the real failure. > We must only call close if this is not null. I looks l

Integrated: 8285416: [LOOM] Some nsk/jdi tests fail due to needing too many virtual threads

2023-01-06 Thread Chris Plummer
On Tue, 20 Dec 2022 02:04:01 GMT, Chris Plummer wrote: > There are a few nsk debugger tests that pin multiple virtual threads to > carrier threads when synchronizing. Sometime the default number of carrier > threads (which equals the number of CPUs) is not enough, and the test > deadlocks beca

Re: RFR: 8299739: HashedPasswordFileTest.java and ExceptionTest.java can fail with java.lang.NullPointerException

2023-01-06 Thread Serguei Spitsyn
On Fri, 6 Jan 2023 13:11:41 GMT, Kevin Walls wrote: > Exceptions during setup of these tests could leave e.g. JMXConnector cs as > null. > But, we call cs.close() during a finally block and fail with an NPE, > obscuring the real failure. > We must only call close if this is not null. Looks goo

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-06 Thread Maurizio Cimadamore
On Fri, 6 Jan 2023 15:38:31 GMT, Alan Bateman wrote: >>> The associated JBS issue has been dormant for 6+ years and this is a very >>> intrusive change affecting many, many files. Has the resurrection of this >>> project previously been discussed somewhere? >> >> Hi @dholmes-ora, >> >> The wo

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-06 Thread Alan Bateman
On Fri, 6 Jan 2023 14:49:16 GMT, Archie L. Cobbs wrote: > Sounds reasonable... so I take it you would also be in favor of patching > `make/modules` instead of adding `@SuppressWarnings` annotations > everywhere... is that correct? > > If this is generally agreed as a better route then let me k

Re: RFR: 8015831: Add lint check for calling overridable methods from a constructor

2023-01-06 Thread Archie L . Cobbs
On Fri, 6 Jan 2023 04:48:27 GMT, David Holmes wrote: > The associated JBS issue has been dormant for 6+ years and this is a very > intrusive change affecting many, many files. Has the resurrection of this > project previously been discussed somewhere? Hi @dholmes-ora, The work to add this war

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v7]

2023-01-06 Thread Coleen Phillimore
On Thu, 15 Dec 2022 01:57:27 GMT, David Holmes wrote: >> I agree that this is ambigious. The `jvmtiTagMap` calls `add/update` methods >> of `jvmtiTagMapTable` which in turn calls `resourceHashTable` methods `put` >> and `put_if_absent`. >> `put` and `put_if_absent` can be used for both adding a

RFR: 8299112: HashedPasswordFileTest.java and ExceptionTest.java fails with java.lang.NullPointerException

2023-01-06 Thread Kevin Walls
Exceptions during setup of these tests could leave e.g. JMXConnector cs as null. But, we call cs.close() during a finally block and fail with an NPE, obscuring the real failure. We must only call close if this is not null. - Commit messages: - 8299112: HashedPasswordFileTest.java an

Re: RFR: 8299234: JMX Repository.query performance

2023-01-06 Thread Kevin Walls
On Wed, 21 Dec 2022 18:50:52 GMT, Alexey Bakhtin wrote: > Please find a patch to improve JMX Repository.query performance > > Using ObjectName.apply() allows significantly decrease memory usage and the > number of GC cycles: > Before: > > $ java test 100 100 > Test PASSED in 8943169791