Re: RFR: 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions [v3]

2022-12-20 Thread Serguei Spitsyn
> Now the `JvmtiVTMSTransitionDisabler` mechanism supports disabling VTMS > transitions for all virtual threads only. It should also support disabling > transitions for any specific virtual thread as well. This will improve > scalability of the JVMTI functions operating on target virtual threads

Integrated: Merge jdk20

2022-12-20 Thread Jesper Wilhelmsson
On Tue, 20 Dec 2022 10:57:44 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 20 -> JDK 21 This pull request has now been integrated. Changeset: c5a4a7a6 Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/c5a4a7a679ec76cb08a999a198e5c73e9cd9d2f0 Stats: 2286 lines

Re: RFR: Merge jdk20 [v2]

2022-12-20 Thread Jesper Wilhelmsson
> Forwardport JDK 20 -> JDK 21 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 107 commits: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8298865: Excessive memory allocation in CipherOutputStre

RFR: Merge jdk20

2022-12-20 Thread Jesper Wilhelmsson
Forwardport JDK 20 -> JDK 21 - Commit messages: - Merge remote-tracking branch 'jdk20/master' into Merge_jdk20 - 8298784: JFR: Test chunk integrity - 8298215: gc/g1/TestVerifyGCType.java failed with "Missing expected verification pattern Verifying After GC for: Pause Young (Prepar

Re: RFR: 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions [v2]

2022-12-20 Thread Serguei Spitsyn
On Tue, 20 Dec 2022 04:49:46 GMT, David Holmes wrote: >> This update just follows the common pattern which was introduced about two >> years ago. At the moment I do not remember the exact reason. This code needs >> to wait for the counter to become zero and to use `ThreadBlockInVM` which >> ca

Re: RFR: 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions [v2]

2022-12-20 Thread Serguei Spitsyn
On Tue, 20 Dec 2022 04:37:32 GMT, David Holmes wrote: >> The JvmtiVTMSTransitionDisabler has to be a no-op for a non-virtual thread. >> It is to avoid different branches where it is possible for virtual and >> non-virtual cases and use this in `jvmtiEnv.cpp`: >> ` JvmtiVTMSTransitionDisabler d

Re: RFR: 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions [v2]

2022-12-20 Thread Serguei Spitsyn
On Tue, 20 Dec 2022 04:50:49 GMT, David Holmes wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review comments are addressed > > src/hotspot/share/prims/jvmtiThreadState.hpp line 88: > >> 86: >> 87: bool _is

Re: RFR: 8298853: JvmtiVTMSTransitionDisabler should support disabling one virtual thread transitions [v2]

2022-12-20 Thread Serguei Spitsyn
On Tue, 20 Dec 2022 04:51:52 GMT, David Holmes wrote: >> Each of these two functions is called just once with the lock held. >> I feel that asserting this would be an overkill but I can add it if you >> still think it is important. >> I've added assert for negative count. > > asserts would be go