Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v7]

2022-12-12 Thread David Holmes
On Thu, 8 Dec 2022 16:56:40 GMT, Afshin Zafari wrote: >> test of tier1-5 passed. > > Afshin Zafari has updated the pull request incrementally with one additional > commit since the last revision: > > 8292741: Convert JvmtiTagMapTable to ResourceHashtable The alternative to force-push would h

Re: RFR: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker

2022-12-12 Thread Leonid Mesnik
On Fri, 9 Dec 2022 23:18:23 GMT, Alex Menkov wrote: > The fix updates the test to ignore ThreadDeathEvent event from non-test > threads waiting for breakpoint Marked as reviewed by lmesnik (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11620

Integrated: 8298343: "Could not confirm if TargetJDK is hardened." warning for SA tests on macosx-aarch64-debug

2022-12-12 Thread Chris Plummer
On Fri, 9 Dec 2022 22:16:44 GMT, Chris Plummer wrote: > In the log for most SA tests on macos-aarch64-debug, you will see something > like: > > > STDOUT: > Executable=/System/Volumes/Data/mesos/work_dir/jib-master/install/2022-12-07-2219530.chris.plummer.jdk/macosx-aarch64-debug.jdk/jdk-20/fa

Re: RFR: 8298343: "Could not confirm if TargetJDK is hardened." warning for SA tests on macosx-aarch64-debug

2022-12-12 Thread Chris Plummer
On Fri, 9 Dec 2022 22:16:44 GMT, Chris Plummer wrote: > In the log for most SA tests on macos-aarch64-debug, you will see something > like: > > > STDOUT: > Executable=/System/Volumes/Data/mesos/work_dir/jib-master/install/2022-12-07-2219530.chris.plummer.jdk/macosx-aarch64-debug.jdk/jdk-20/fa

Re: RFR: 8287812: Cleanup JDWP agent GetEnv initialization [v2]

2022-12-12 Thread Chris Plummer
On Mon, 12 Dec 2022 16:28:27 GMT, Alan Bateman wrote: > I don't mind. For now (JDK 19 and 20), the case where it will only likely > arise is -agentlib:jdwp --enable-preview on ports that don't have VM > continuations. In that case, GetEnv will fail. If virtual threads become > permanent in JDK

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v7]

2022-12-12 Thread Coleen Phillimore
On Thu, 8 Dec 2022 16:56:40 GMT, Afshin Zafari wrote: >> test of tier1-5 passed. > > Afshin Zafari has updated the pull request incrementally with one additional > commit since the last revision: > > 8292741: Convert JvmtiTagMapTable to ResourceHashtable I have a couple of minor comments but

Re: RFR: 8287812: Cleanup JDWP agent GetEnv initialization [v2]

2022-12-12 Thread Alan Bateman
On Sat, 10 Dec 2022 10:29:43 GMT, Alan Bateman wrote: >> I have a memory of the following concerning JVM/TI versions: >> >> - if you asked for JVMTI_VERSION, then you got the highest version supported >> by the JVM. >> - if you asked for JVMTI_VERSION_1, then you got the highest compatible >>

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v7]

2022-12-12 Thread Afshin Zafari
On Mon, 12 Dec 2022 14:44:03 GMT, Robbin Ehn wrote: > > Also please do not force-push. > > FYI: I'm not sure it even was possible to fix the "full of unexpected > changes" without force push. Even if it was, the effort required to fix it > without force push would be pretty significant. So I'd

Re: RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v7]

2022-12-12 Thread Robbin Ehn
On Mon, 12 Dec 2022 00:58:35 GMT, David Holmes wrote: > Also please do not force-push. FYI: I'm not sure it even was possible to fix the "full of unexpected changes" without force push. Even if it was, the effort required to fix it without force push would be pretty significant. So I'd say thi

Re: RFR: 8298343: "Could not confirm if TargetJDK is hardened." warning for SA tests on macosx-aarch64-debug

2022-12-12 Thread Kevin Walls
On Fri, 9 Dec 2022 22:16:44 GMT, Chris Plummer wrote: > In the log for most SA tests on macos-aarch64-debug, you will see something > like: > > > STDOUT: > Executable=/System/Volumes/Data/mesos/work_dir/jib-master/install/2022-12-07-2219530.chris.plummer.jdk/macosx-aarch64-debug.jdk/jdk-20/fa

Re: RFR: 8298514: vmTestbase/nsk/jdi/EventRequestManager/threadDeathRequests/thrdeathreq002/TestDescription.java fails with usage tracker

2022-12-12 Thread Serguei Spitsyn
On Fri, 9 Dec 2022 23:21:04 GMT, Alex Menkov wrote: > One more test fix to ignore ThreadDeathEvent event from non-test threads > waiting for breakpoint Looks good. Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.org/jdk/pull/11621

Re: RFR: 8298513: vmTestbase/nsk/jdi/EventSet/suspendPolicy/suspendpolicy009/TestDescription.java fails with usage tracker

2022-12-12 Thread Serguei Spitsyn
On Fri, 9 Dec 2022 23:18:23 GMT, Alex Menkov wrote: > The fix updates the test to ignore ThreadDeathEvent event from non-test > threads waiting for breakpoint Looks good. Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR: https://git.openjdk.org/jdk/pull/11620