Re: RFR: 8298054: ProblemList jdk/jfr/api/consumer/recordingstream/TestStop.java

2022-12-02 Thread Daniel D . Daugherty
On Sat, 3 Dec 2022 04:06:37 GMT, Leonid Mesnik wrote: >> A trivial fix to ProblemList >> jdk/jfr/api/consumer/recordingstream/TestStop.java. > > Marked as reviewed by lmesnik (Reviewer). @lmesnik - Thanks for the fast review! Especially for a Friday PM... - PR: https://git.openjdk

Integrated: 8298054: ProblemList jdk/jfr/api/consumer/recordingstream/TestStop.java

2022-12-02 Thread Daniel D . Daugherty
On Sat, 3 Dec 2022 03:58:34 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > jdk/jfr/api/consumer/recordingstream/TestStop.java. This pull request has now been integrated. Changeset: 99e2ef49 Author:Daniel D. Daugherty URL: https://git.openjdk.org/jdk/commit/99e2ef4

Re: RFR: 8298054: ProblemList jdk/jfr/api/consumer/recordingstream/TestStop.java

2022-12-02 Thread Leonid Mesnik
On Sat, 3 Dec 2022 03:58:34 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > jdk/jfr/api/consumer/recordingstream/TestStop.java. Marked as reviewed by lmesnik (Reviewer). - PR: https://git.openjdk.org/jdk/pull/11494

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-12-02 Thread Magnus Ihse Bursie
On Fri, 2 Dec 2022 17:12:55 GMT, Andy Goryachev wrote: >> This turned out to be much more complicated than anticipated. I am going to >> close this PR (and bug), and instead I have split up this work in five >> different bugs: >> >> [JDK-8298047](https://bugs.openjdk.org/browse/JDK-8298047) is

Re: RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest

2022-12-02 Thread Daniel D . Daugherty
On Mon, 21 Nov 2022 22:55:40 GMT, Daniel D. Daugherty wrote: > Misc stress testing related fixes: > > [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for > another JLI GetObjectSizeIntrinsicsTest.java subtest > [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367

Re: RFR: 8298046: Fix hidden but significant trailing whitespace in properties files for serviceability code

2022-12-02 Thread Chris Plummer
On Fri, 2 Dec 2022 16:42:57 GMT, Magnus Ihse Bursie wrote: > According to [the > specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)) > trailing whitespaces in the values of properties files are (somewhat > surprisingly) ac

Re: RFR: 8298046: Fix hidden but significant trailing whitespace in properties files for serviceability code

2022-12-02 Thread Chris Plummer
On Fri, 2 Dec 2022 21:03:27 GMT, Chris Plummer wrote: >> According to [the >> specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)) >> trailing whitespaces in the values of properties files are (somewhat >> surprisingly) act

Re: RFR: 8297794: Deprecate JMX Management Applets for Removal [v4]

2022-12-02 Thread Roger Riggs
On Wed, 30 Nov 2022 20:37:38 GMT, Kevin Walls wrote: >> Deprecate the Java Management Extension (JMX) Management Applet (m-let) >> feature for removal. >> >> This deprecation will have no impact on users of other JMX features, the >> JDK's built-in instrumentation, or any of the observability

Integrated: 8280798: com.sun.jdi.ObjectReference::setValue spec should prohibit any final field modification

2022-12-02 Thread Alex Menkov
On Mon, 21 Nov 2022 22:58:54 GMT, Alex Menkov wrote: > com.sun.jdi.ObjectReference::setValue spec says that final static fields > cannot be modified, but openjdk implementation throws > IllegalArgumentException for any final fields (static or instance). > > The fix updates the spec to prohibit

Re: RFR: 8297794: Deprecate JMX Management Applets for Removal [v4]

2022-12-02 Thread Sean Mullan
On Wed, 30 Nov 2022 20:37:38 GMT, Kevin Walls wrote: >> Deprecate the Java Management Extension (JMX) Management Applet (m-let) >> feature for removal. >> >> This deprecation will have no impact on users of other JMX features, the >> JDK's built-in instrumentation, or any of the observability

Integrated: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero

2022-12-02 Thread Coleen Phillimore
On Thu, 1 Dec 2022 02:01:54 GMT, Coleen Phillimore wrote: > The code for RedefineVerifyMark in redefinition replaces the OopHandle mirror > so that the verification has the right mirror, but it really should just copy > it. Replacing an OopHandle in the ClassLoaderData didn't set the > has_mo

Re: RFR: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero [v2]

2022-12-02 Thread Coleen Phillimore
On Fri, 2 Dec 2022 17:02:13 GMT, Coleen Phillimore wrote: >> The code for RedefineVerifyMark in redefinition replaces the OopHandle >> mirror so that the verification has the right mirror, but it really should >> just copy it. Replacing an OopHandle in the ClassLoaderData didn't set the >> ha

Re: RFR: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero [v2]

2022-12-02 Thread Kim Barrett
On Fri, 2 Dec 2022 17:02:13 GMT, Coleen Phillimore wrote: >> The code for RedefineVerifyMark in redefinition replaces the OopHandle >> mirror so that the verification has the right mirror, but it really should >> just copy it. Replacing an OopHandle in the ClassLoaderData didn't set the >> ha

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-12-02 Thread Andy Goryachev
On Fri, 2 Dec 2022 17:10:17 GMT, Magnus Ihse Bursie wrote: > and instead I have split up this work in five different bugs would you consider also adding a unit test to check whether the localized resources also contain leading/trailing whitespace, and possibly special characters (like {, }, ,

RFR: 8298047: Remove all non-significant trailing whitespace from properties files

2022-12-02 Thread Magnus Ihse Bursie
[JDK-8295729](https://bugs.openjdk.org/browse/JDK-8295729) was created in an attempt to remove all trailing whitespace from properties files, and enable a jcheck verification that they did not come back, similar to other source code. It turned out that this was not so simple, however, since trai

Withdrawn: 8295729: Add jcheck whitespace checking for properties files

2022-12-02 Thread Magnus Ihse Bursie
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote: > Properties files is essentially source code. It should have the same > whitespace checks as all other source code, so we don't get spurious trailing > whitespace changes. > > With the new Skara jcheck, it is possible to increase the

Re: RFR: 8295729: Add jcheck whitespace checking for properties files [v3]

2022-12-02 Thread Magnus Ihse Bursie
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote: >> Properties files is essentially source code. It should have the same >> whitespace checks as all other source code, so we don't get spurious >> trailing whitespace changes. >> >> With the new Skara jcheck, it is possible to increas

Re: RFR: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero [v2]

2022-12-02 Thread Coleen Phillimore
> The code for RedefineVerifyMark in redefinition replaces the OopHandle mirror > so that the verification has the right mirror, but it really should just copy > it. Replacing an OopHandle in the ClassLoaderData didn't set the > has_modified_oops flag so GC wasn't noticing that this handle is o

RFR: 8298046: Fix hidden but significant trailing whitespace in properties files for serviceability code

2022-12-02 Thread Magnus Ihse Bursie
According to [the specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)) trailing whitespaces in the values of properties files are (somewhat surprisingly) actually significant. We have multiple files in the JDK with trailing

Re: RFR: 8298046: Fix hidden but significant trailing whitespace in properties files for serviceability code

2022-12-02 Thread Magnus Ihse Bursie
On Fri, 2 Dec 2022 16:42:57 GMT, Magnus Ihse Bursie wrote: > According to [the > specification](https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/util/Properties.html#load(java.io.Reader)) > trailing whitespaces in the values of properties files are (somewhat > surprisingly) ac

Re: RFR: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero

2022-12-02 Thread Erik Ă–sterlund
On Thu, 1 Dec 2022 02:01:54 GMT, Coleen Phillimore wrote: > The code for RedefineVerifyMark in redefinition replaces the OopHandle mirror > so that the verification has the right mirror, but it really should just copy > it. Replacing an OopHandle in the ClassLoaderData didn't set the > has_mo

Re: RFR: 8291830: jvmti/RedefineClasses/StressRedefine failed: assert(!is_null(v)) failed: narrow klass value can never be zero

2022-12-02 Thread Coleen Phillimore
On Thu, 1 Dec 2022 02:01:54 GMT, Coleen Phillimore wrote: > The code for RedefineVerifyMark in redefinition replaces the OopHandle mirror > so that the verification has the right mirror, but it really should just copy > it. Replacing an OopHandle in the ClassLoaderData didn't set the > has_mo

Re: RFR: 8296546: Add @spec tags to API [v4]

2022-12-02 Thread Daniel Fuchs
On Thu, 1 Dec 2022 19:36:16 GMT, Jonathan Gibbons wrote: >> Please review a "somewhat automated" change to insert `@spec` tags into doc >> comments, as appropriate, to leverage the recent new javadoc feature to >> generate a new page listing the references to all external specifications >> lis