On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> *EDIT*: The below discussion has been deferred out of this PR. Now this only
>> deals with fixing the placemen
On Wed, 23 Nov 2022 07:12:13 GMT, Kim Barrett wrote:
> > I'm not sure why conditional includes (that don't rely on macros.hpp) need
> > to come at the end rather than in normal sort order? I don't care either
> > way but a rationale for this would be good if it is to be the preferred
> > style
On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> *EDIT*: The below discussion has been deferred out of this PR. Now this only
>> deals with fixing the placemen
On Wed, 23 Nov 2022 04:47:11 GMT, David Holmes wrote:
> I'm not sure why conditional includes (that don't rely on macros.hpp) need to
> come at the end rather than in normal sort order? I don't care either way but
> a rationale for this would be good if it is to be the preferred style.
Because
On Mon, 14 Nov 2022 12:20:54 GMT, Julian Waters wrote:
>> Sorry my eyes must be playing tricks on me. ??
>>
>> Why did you need to add this here?
>
> It's to avoid redefining the linkage as static in os_windows.cpp (where it's
> implemented) after an extern declaration (inside the class), which
On Mon, 21 Nov 2022 02:43:12 GMT, Julian Waters wrote:
> Out of curiosity, is there a way to get the discussion on approving the use
> of alignas back up? [...]
A PR to address JDK-8252584 would be welcomed by me. Just do the process for
Style Guide changes (see the Style Guide or previous PRs
On Wed, 16 Nov 2022 16:17:48 GMT, Stefan Karlsson wrote:
>> The sorted blocks of includes have deteriorated to the point that I felt
>> compelled to clean up some of the issues.
>>
>> *EDIT*: The below discussion has been deferred out of this PR. Now this only
>> deals with fixing the placemen
On Wed, 23 Nov 2022 02:22:46 GMT, Chris Plummer wrote:
> [JDK-8295376](https://bugs.openjdk.org/browse/JDK-8295376) introduced some
> new code that disables JVMTI VIRTUAL_THREAD_START/END events when the
> debugger disconnects. Sometimes this disabling attempt results in a
> JVMTI_ERROR_WRONG_
[JDK-8295376](https://bugs.openjdk.org/browse/JDK-8295376) introduced some new
code that disables JVMTI VIRTUAL_THREAD_START/END events when the debugger
disconnects. Sometimes this disabling attempt results in a
JVMTI_ERROR_WRONG_PHASE. The reason is because often the disconnect and
debuggee e
On Mon, 21 Nov 2022 22:55:40 GMT, Daniel D. Daugherty
wrote:
> Misc stress testing related fixes:
>
> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for
> another JLI GetObjectSizeIntrinsicsTest.java subtest
> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367
On Wed, 23 Nov 2022 00:24:28 GMT, Serguei Spitsyn wrote:
> This problem has two sides.
> One is that the `VirtualThread::run() `cashes the field `notifyJvmtiEvents`
> value.
> It caused the native method `notifyJvmtiUnmountBegin()` not called after the
> field `notifyJvmtiEvents`
> value has be
On Wed, 23 Nov 2022 00:24:28 GMT, Serguei Spitsyn wrote:
> This problem has two sides.
> One is that the `VirtualThread::run() `cashes the field `notifyJvmtiEvents`
> value.
> It caused the native method `notifyJvmtiUnmountBegin()` not called after the
> field `notifyJvmtiEvents`
> value has be
On Tue, 22 Nov 2022 23:30:57 GMT, Daniel D. Daugherty
wrote:
> I could not find an @requires incantation for saying
> do-not-use-slowdebug-bits nor one for saying do-not-use-macosx-aarch64.
Something like:
`@requires vm.debug != slowdebug`
`@requires !(os.arch == "aarch64" && os.family == "m
This problem has two sides.
One is that the `VirtualThread::run() `cashes the field `notifyJvmtiEvents`
value.
It caused the native method `notifyJvmtiUnmountBegin()` not called after the
field `notifyJvmtiEvents`
value has been set to `true` when an agent library is loaded into running VM.
The f
On Tue, 22 Nov 2022 23:31:07 GMT, Daniel D. Daugherty
wrote:
>> Mild grumble: langtools tests do not rely on jdk test libraries
>
> Does langtools have its own test libraries that I can use to ask the same
> questions?
Sorry, I was not clear.
The Fuzz.java has this order:
+import jdk.test.lib
On Fri, 11 Nov 2022 00:43:33 GMT, Alex Menkov wrote:
> Changes:
> - removed `` from TOC;
> - added CSS style for TOC (to simplify customization, currently it's empty);
> - removed `` from from function list (per Phase);
> - removed `` from from list of events;
> - introduced CSS style for bold te
On Sat, 19 Nov 2022 07:08:38 GMT, Serguei Spitsyn wrote:
> The can_support_virtual_thread was initially implemented as an onload
> capability.
> It is why this capability does not work for the agents loaded into running VM.
> The fix is to move it from `onload` to `always`capabilities list.
>
>
On Tue, 22 Nov 2022 23:17:24 GMT, Jonathan Gibbons wrote:
>> Misc stress testing related fixes:
>>
>> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout
>> for another JLI GetObjectSizeIntrinsicsTest.java subtest
>> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-829736
On Tue, 22 Nov 2022 23:15:48 GMT, Jonathan Gibbons wrote:
>> Why? 'jdk' comes before 'jtreg' and 'Platform' comes before
>> 'SkippedException'.
>> What am I missing here?
>
> Mild grumble: langtools tests do not rely on jdk test libraries
Does langtools have its own test libraries that I can us
> The can_support_virtual_thread was initially implemented as an onload
> capability.
> It is why this capability does not work for the agents loaded into running VM.
> The fix is to move it from `onload` to `always`capabilities list.
>
> Testing:
> New test is added: VirtualStartThreadTest.
> TB
On Tue, 22 Nov 2022 20:57:16 GMT, Daniel D. Daugherty
wrote:
>> Serguei Spitsyn has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains eight additional
On Tue, 22 Nov 2022 21:05:16 GMT, Daniel D. Daugherty
wrote:
>> test/langtools/jdk/javadoc/doclet/testLinkOption/TestRedirectLinks.java line
>> 73:
>>
>>> 71:
>>> 72: import jdk.test.lib.Platform;
>>> 73: import jtreg.SkippedException;
>>
>> Nit: the order of imports on 72-73 needs to be swa
On Mon, 21 Nov 2022 22:55:40 GMT, Daniel D. Daugherty
wrote:
> Misc stress testing related fixes:
>
> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for
> another JLI GetObjectSizeIntrinsicsTest.java subtest
> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367
On Tue, 22 Nov 2022 00:40:09 GMT, Kim Barrett wrote:
> Please review this trivial change to remove a function declaration that is
> never defined.
This pull request has now been integrated.
Changeset: 974cb837
Author:Kim Barrett
URL:
https://git.openjdk.org/jdk/commit/974cb8370d568
> Please review this trivial change to remove a function declaration that is
> never defined.
Kim Barrett has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contai
On Tue, 22 Nov 2022 12:36:07 GMT, Aleksey Shipilev wrote:
>> Kim Barrett has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commi
On Mon, 21 Nov 2022 22:58:54 GMT, Alex Menkov wrote:
> com.sun.jdi.ObjectReference::setValue spec says that final static fields
> cannot be modified, but openjdk implementation throws
> IllegalArgumentException for any final fields (static or instance).
>
> The fix updates the spec to prohibit
On Mon, 21 Nov 2022 22:58:54 GMT, Alex Menkov wrote:
> com.sun.jdi.ObjectReference::setValue spec says that final static fields
> cannot be modified, but openjdk implementation throws
> IllegalArgumentException for any final fields (static or instance).
>
> The fix updates the spec to prohibit
On Mon, 21 Nov 2022 22:58:54 GMT, Alex Menkov wrote:
> com.sun.jdi.ObjectReference::setValue spec says that final static fields
> cannot be modified, but openjdk implementation throws
> IllegalArgumentException for any final fields (static or instance).
>
> The fix updates the spec to prohibit
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed in the `@spec` tags.
>
> "Somewhat automated" means that I
On Mon, 21 Nov 2022 22:58:54 GMT, Alex Menkov wrote:
> com.sun.jdi.ObjectReference::setValue spec says that final static fields
> cannot be modified, but openjdk implementation throws
> IllegalArgumentException for any final fields (static or instance).
>
> The fix updates the spec to prohibit
On Tue, 22 Nov 2022 05:57:37 GMT, Serguei Spitsyn wrote:
>> The can_support_virtual_thread was initially implemented as an onload
>> capability.
>> It is why this capability does not work for the agents loaded into running
>> VM.
>> The fix is to move it from `onload` to `always`capabilities li
On Tue, 22 Nov 2022 19:43:38 GMT, Serguei Spitsyn wrote:
>> Misc stress testing related fixes:
>>
>> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout
>> for another JLI GetObjectSizeIntrinsicsTest.java subtest
>> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367
On Mon, 21 Nov 2022 22:55:40 GMT, Daniel D. Daugherty
wrote:
> Misc stress testing related fixes:
>
> [JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for
> another JLI GetObjectSizeIntrinsicsTest.java subtest
> [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367
On Mon, 21 Nov 2022 22:58:54 GMT, Alex Menkov wrote:
> com.sun.jdi.ObjectReference::setValue spec says that final static fields
> cannot be modified, but openjdk implementation throws
> IllegalArgumentException for any final fields (static or instance).
>
> The fix updates the spec to prohibit
Misc stress testing related fixes:
[JDK-8295424](https://bugs.openjdk.org/browse/JDK-8295424) adjust timeout for
another JLI GetObjectSizeIntrinsicsTest.java subtest
[JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367) disable
TestRedirectLinks.java in slowdebug mode
[JDK-8297369](https://
> This PR contains the API and implementation changes for JEP-434 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.org/jeps/434
Maurizio Cimadamore has updated the pull request incr
On Tue, 22 Nov 2022 00:40:09 GMT, Kim Barrett wrote:
> Please review this trivial change to remove a function declaration that is
> never defined.
Looks fine and trivial.
-
Marked as reviewed by shade (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11280
On Tue, 22 Nov 2022 05:57:37 GMT, Serguei Spitsyn wrote:
>> The can_support_virtual_thread was initially implemented as an onload
>> capability.
>> It is why this capability does not work for the agents loaded into running
>> VM.
>> The fix is to move it from `onload` to `always`capabilities li
On Mon, 21 Nov 2022 22:58:54 GMT, Alex Menkov wrote:
> com.sun.jdi.ObjectReference::setValue spec says that final static fields
> cannot be modified, but openjdk implementation throws
> IllegalArgumentException for any final fields (static or instance).
>
> The fix updates the spec to prohibit
40 matches
Mail list logo
