Re: RFR: 8296796: Provide clean, platform-agnostic interface to C-heap trimming [v2]

2022-11-13 Thread Thomas Stuefe
> This is a breakout from > [JDK-8293114](https://bugs.openjdk.org/browse/JDK-8293114), which is starved > for reviews. So I attempt to break up that fix into smaller units which are > hopefully easier to review separately. > > We can trim the C-heap manually using jcmd since > [JDK-8268893](h

Re: RFR: 8296796: Provide clean, platform-agnostic interface to C-heap trimming

2022-11-13 Thread Thomas Stuefe
On Mon, 14 Nov 2022 01:35:35 GMT, David Holmes wrote: > This looks good for doing what it says, but I have to wonder whether it is > actually worthwhile doing this unless most OS/lib will support it? What will > the implementation be in AIX? I think C-Heap trimming is useful even if only Linux

Re: RFR: 8295146: Clean up native code with newer C/C++ language features [v2]

2022-11-13 Thread Julian Waters
On Sun, 13 Nov 2022 22:58:11 GMT, David Holmes wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> ATTRIBUTE_SCANF > > src/hotspot/os/linux/os_perf_linux.cpp line 233: > >> 231: * Ensure that 'fmt' does _NOT_ conta

Re: RFR: 8295146: Clean up native code with newer C/C++ language features [v2]

2022-11-13 Thread Julian Waters
> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and > [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ > code across the JDK can be replaced and simplified with cleaner language > features that were previously not available due to required compatibili

Re: RFR: 8296886: Fix various include sort order issues

2022-11-13 Thread David Holmes
On Fri, 11 Nov 2022 14:26:20 GMT, Stefan Karlsson wrote: > The sorted blocks of includes have deteriorated to the point that I felt > compelled to clean up some of the issues. > > One of the more prevalent issues is that files in src/hotspot/share/include > are not properly sorted. There has b

Re: RFR: 8295146: Clean up native code with newer C/C++ language features

2022-11-13 Thread Julian Waters
On Sun, 13 Nov 2022 23:16:47 GMT, David Holmes wrote: >> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and >> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ >> code across the JDK can be replaced and simplified with cleaner language >> features th

Re: RFR: 8295146: Clean up native code with newer C/C++ language features

2022-11-13 Thread Julian Waters
On Sun, 13 Nov 2022 23:08:53 GMT, David Holmes wrote: >> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and >> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ >> code across the JDK can be replaced and simplified with cleaner language >> features th

Re: RFR: 8296796: Provide clean, platform-agnostic interface to C-heap trimming

2022-11-13 Thread David Holmes
On Thu, 10 Nov 2022 13:23:34 GMT, Thomas Stuefe wrote: > This is a breakout from > [JDK-8293114](https://bugs.openjdk.org/browse/JDK-8293114), which is starved > for reviews. So I attempt to break up that fix into smaller units which are > hopefully easier to review separately. > > We can tri

Re: RFR: 8295146: Clean up native code with newer C/C++ language features

2022-11-13 Thread Julian Waters
On Sun, 13 Nov 2022 23:07:35 GMT, David Holmes wrote: >> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and >> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ >> code across the JDK can be replaced and simplified with cleaner language >> features th

Re: RFR: 8295146: Clean up native code with newer C/C++ language features

2022-11-13 Thread Julian Waters
On Sun, 13 Nov 2022 22:59:01 GMT, David Holmes wrote: >> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and >> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ >> code across the JDK can be replaced and simplified with cleaner language >> features th

Re: RFR: 8296709: WARNING: JNI call made without checking exceptions [v3]

2022-11-13 Thread David Holmes
On Fri, 11 Nov 2022 16:26:59 GMT, Lutz Schmidt wrote: >> This small change fixes a warning that may pop up during runtime. May I >> please request reviews? Thank you! > > Lutz Schmidt has updated the pull request incrementally with one additional > commit since the last revision: > > 8296709

Re: RFR: 8295146: Clean up native code with newer C/C++ language features

2022-11-13 Thread David Holmes
On Thu, 10 Nov 2022 06:20:41 GMT, Julian Waters wrote: > After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and > [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++ > code across the JDK can be replaced and simplified with cleaner language > features that

Re: RFR: 8291555: Replace stack-locking with fast-locking

2022-11-13 Thread David Holmes
On Fri, 11 Nov 2022 14:35:22 GMT, Roman Kennke wrote: >>> So the data structure for lock records (per thread) could consist of a >>> series of distinct values [ A B C ] and each of the values could be >>> repeated, but only adjacently: [ A A A B C C ] for example. >> @rose00 why only adjacently

Re: RFR: 8296796: Provide clean, platform-agnostic interface to C-heap trimming

2022-11-13 Thread Thomas Stuefe
On Thu, 10 Nov 2022 13:23:34 GMT, Thomas Stuefe wrote: > This is a breakout from > [JDK-8293114](https://bugs.openjdk.org/browse/JDK-8293114), which is starved > for reviews. So I attempt to break up that fix into smaller units which are > hopefully easier to review separately. > > We can tri