On Fri, 11 Nov 2022 06:26:19 GMT, Christoph Langer wrote:
>> This small change fixes a warning that may pop up during runtime. May I
>> please request reviews? Thank you!
>
> Maybe you could also call "bin/java -Xcheck:jni
> -agentlib:jdwp=transport=dt_socket,server=y,suspend=n -version" which
On Thu, 10 Nov 2022 20:58:36 GMT, Chris Plummer wrote:
>> The debug agent sets a breakpoint in Thread.resume() so it can prevent the
>> debugger from suspending threads while in the resume call:
>>
>> /*
>> * Track the resuming thread by marking it as being within
>>
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Maybe you could also call "bin/java -Xcheck:jni
-agentlib:jdwp=transport=dt_socket,server=y,suspend=n -version" which would
show
On Thu, 10 Nov 2022 22:42:10 GMT, Ioi Lam wrote:
> Here's redo for https://github.com/openjdk/jdk/pull/10687. This PR has two
> commits:
> - 739b79afb1965b625b2002187ac3fd43f385a639 is the same as in the original PR
> - 78455c024ec5c00f1a0ce6c0e13df477c3063fe1 fixes the bug in the original PR.
>
On Fri, 11 Nov 2022 03:17:58 GMT, Chris Plummer wrote:
> Get rid of `list` argument in debug agent's `removeNode()` API. The list is
> stored in the node, so no need to pass it in.
Marked as reviewed by amenkov (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11101
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Thu, 10 Nov 2022 21:30:54 GMT, Leonid Mesnik wrote:
>> Change Thread.resume() to error reporting and add some time to complete
>> thread.
>
> Leonid Mesnik has updated the pull request incrementally with one additional
> commit since the last revision:
>
> log message added.
Changes requ
Get rid of `list` argument in debug agent's `removeNode()` API. The list is
stored in the node, so no need to pass it in.
-
Commit messages:
- Remove list argument from removeNode()
Changes: https://git.openjdk.org/jdk/pull/11101/files
Webrev: https://webrevs.openjdk.org/?repo=jdk
On Wed, 9 Nov 2022 13:24:54 GMT, Maurizio Cimadamore
wrote:
>> This PR contains the API and implementation changes for JEP-434 [1]. A more
>> detailed description of such changes, to avoid repetitions during the review
>> process, is included as a separate comment.
>>
>> [1] - https://openjdk
Changes:
- removed `` from TOC;
- added CSS style for TOC (to simplify customization, currently it's empty);
- removed `` from from function list (per Phase);
- removed `` from from list of events;
- introduced CSS style for bold text, replaced `` tags with ``;
- update transformation rule for `"b"
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Thu, 10 Nov 2022 23:01:24 GMT, Naoto Sato wrote:
>> A trivial fix to ProblemList
>> jdk/jfr/api/consumer/TestRecordingFileWrite.java.
>
> Marked as reviewed by naoto (Reviewer).
@naotoj - Thanks for the fast review!
-
PR: https://git.openjdk.org/jdk/pull/11095
On Thu, 10 Nov 2022 22:54:54 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList jdk/jfr/api/consumer/TestRecordingFileWrite.java.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11095
A trivial fix to ProblemList jdk/jfr/api/consumer/TestRecordingFileWrite.java.
-
Commit messages:
- 8296822: ProblemList jdk/jfr/api/consumer/TestRecordingFileWrite.java
Changes: https://git.openjdk.org/jdk/pull/11095/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11095&ran
On Thu, 10 Nov 2022 22:54:54 GMT, Daniel D. Daugherty
wrote:
> A trivial fix to ProblemList jdk/jfr/api/consumer/TestRecordingFileWrite.java.
This pull request has now been integrated.
Changeset: 43ebd963
Author:Daniel D. Daugherty
URL:
https://git.openjdk.org/jdk/commit/43ebd96301
Here's redo for https://github.com/openjdk/jdk/pull/10687. This PR has two
commits:
- 739b79afb1965b625b2002187ac3fd43f385a639 is the same as in the original PR
- 78455c024ec5c00f1a0ce6c0e13df477c3063fe1 fixes the bug in the original PR.
I have run tiers 1 - 4 so hopefully I got it right this tim
On Thu, 10 Nov 2022 16:33:09 GMT, AJ1062910 wrote:
> did you changed 420 files ?
I ran a custom utility that edited these files, yes.
-
PR: https://git.openjdk.org/jdk/pull/11073
On Thu, 10 Nov 2022 12:01:11 GMT, Alan Bateman wrote:
> I'm trying to understand what "fix-ups" will be needed if the automated patch
> is applied. In some cases, it looks the same spec will be linked from "See
> also" and "External Specifications", e.g.
> http://cr.openjdk.java.net/~jjg/82965
On Thu, 10 Nov 2022 11:45:39 GMT, Alan Bateman wrote:
> > When referencing an RFC, it might be good to keep the RFC number in the
> > text link. For instance I see that java.net.URL now has this:
>
> I agree and also to add that some RFCs have commas in their titles, the same
> separator used
On Thu, 10 Nov 2022 11:30:51 GMT, Daniel Fuchs wrote:
> Hi Jon,
>
> When referencing an RFC, it might be good to keep the RFC number in the text
> link. For instance I see that java.net.URL now has this:
>
> http://cr.openjdk.java.net/~jjg/8296546/api.00/java.base/java/net/URL.html
>
> Extern
On Thu, 10 Nov 2022 11:45:39 GMT, Alan Bateman wrote:
> When referencing an RFC, it might be good to keep the RFC number in the text
> link.
+1.
-
PR: https://git.openjdk.org/jdk/pull/11073
> Change Thread.resume() to error reporting and add some time to complete
> thread.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
log message added.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10877/files
> Change Thread.resume() to error reporting and add some time to complete
> thread.
Leonid Mesnik has updated the pull request incrementally with one additional
commit since the last revision:
update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/10877/files
- new: https
On Thu, 27 Oct 2022 15:01:18 GMT, Daniel D. Daugherty
wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> All dispose tests fixed.
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003a.java
>
On Thu, 27 Oct 2022 15:34:38 GMT, Serguei Spitsyn wrote:
>> Leonid Mesnik has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> All dispose tests fixed.
>
> test/hotspot/jtreg/vmTestbase/nsk/share/jdi/Utils.java line 29:
>
>> 27:
>> 28:
On Thu, 27 Oct 2022 15:35:08 GMT, Chris Plummer wrote:
>> Or you could use the longer name `nsk.share.jdi.Utils` to differentiate...
>>
>> Is it always the case that we're calling this `isAlive()` function after a
>> `VM.dispose()` call?
>> I'm not so sure that's the case... See L135-142 below.
> The debug agent sets a breakpoint in Thread.resume() so it can prevent the
> debugger from suspending threads while in the resume call:
>
> /*
> * Track the resuming thread by marking it as being within
> * a resume and by setting up for notification on
On Thu, 10 Nov 2022 11:03:25 GMT, Serguei Spitsyn wrote:
>> Chris Plummer has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Cleanup some suspect suspendOnStart and toBeResumed checks.
>
> src/jdk.jdwp.agent/share/native/libjdwp/threadContr
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Thu, 10 Nov 2022 13:23:34 GMT, Thomas Stuefe wrote:
> This is a breakout from
> [JDK-8293114](https://bugs.openjdk.org/browse/JDK-8293114), which is starved
> for reviews. So I attempt to break up that fix into smaller units which are
> hopefully easier to review separately.
>
> We can tri
This is a breakout from
[JDK-8293114](https://bugs.openjdk.org/browse/JDK-8293114), which is starved
for reviews. So I attempt to break up that fix into smaller units which are
hopefully easier to review separately.
We can trim the C-heap manually using jcmd since
[JDK-8268893](https://bugs.op
*+serviceability-dev*
Firstly, thank you both for your time and work in this space. Apologies if this
should be a separate thread, but the new title “Extend Native Memory Tracking
over the JDK” aligns directly with some work I’ve been investigating, and I
hope my feedback will be helpful for pr
On Thu, 10 Nov 2022 12:20:58 GMT, David Holmes wrote:
> Can the test be augmented to catch this case too?
David,
the test already catches both warnings. The warnings are only issued under
special circumstances. That's why everything looks fine in most cases. SAP's
commercial vm has a feature c
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Can the test be augmented to catch this case too?
-
PR: https://git.openjdk.org/jdk/pull/11083
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Thu, 10 Nov 2022 01:10:13 GMT, Jonathan Gibbons wrote:
> Please review a "somewhat automated" change to insert `@spec` tags into doc
> comments, as appropriate, to leverage the recent new javadoc feature to
> generate a new page listing the references to all external specifications
> listed
On Thu, 10 Nov 2022 11:30:51 GMT, Daniel Fuchs wrote:
> When referencing an RFC, it might be good to keep the RFC number in the text
> link. For instance I see that java.net.URL now has this:
I agree and also to add that some RFCs have commas in their titles, the same
separator used when there
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Thanks for the review, Kevin!
I'm looking into the "exceeds capacity" warning separately. Need to find out
who is holding so man
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Looks good.
Thank you for taking care about this.
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR: https://
On Wed, 9 Nov 2022 05:57:32 GMT, Chris Plummer wrote:
>> The debug agent sets a breakpoint in Thread.resume() so it can prevent the
>> debugger from suspending threads while in the resume call:
>>
>> /*
>> * Track the resuming thread by marking it as being within
>>
On Wed, 9 Nov 2022 05:57:32 GMT, Chris Plummer wrote:
>> The debug agent sets a breakpoint in Thread.resume() so it can prevent the
>> debugger from suspending threads while in the resume call:
>>
>> /*
>> * Track the resuming thread by marking it as being within
>>
On Thu, 10 Nov 2022 09:02:02 GMT, Lutz Schmidt wrote:
> This small change fixes a warning that may pop up during runtime. May I
> please request reviews? Thank you!
Looks good I think. Got to check for those exceptions!
The example invocation also shows the me "exceeds capacity" warning, whic
Today we use mtNone to denote that a GrowableArray should *NOT* be backed by a
CHeap allocated array.
I've gotten feedback that it would probably be good to limit the usage of
mtNone, and at some point maybe completely remove it.
This patch takes a small step to remove mtNone from the GrowableA
This small change fixes a warning that may pop up during runtime. May I please
request reviews? Thank you!
-
Commit messages:
- 8296709: WARNING: JNI call made without checking exceptions
Changes: https://git.openjdk.org/jdk/pull/11083/files
Webrev: https://webrevs.openjdk.org/?re
45 matches
Mail list logo
