Re: RFR: 8256072: Eliminate JVMTI tagmap rehashing [v3]

2022-11-02 Thread Erik Österlund
On Wed, 2 Nov 2022 22:23:57 GMT, Coleen Phillimore wrote: >> Use identity_hash for objects in the JVMTI TagMap table. If the object has >> no hashcode, it's not in the table. >> Tested with tier1-6. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit s

Re: RFR: 8256072: Eliminate JVMTI tagmap rehashing [v3]

2022-11-02 Thread Erik Österlund
On Thu, 3 Nov 2022 03:41:26 GMT, Kim Barrett wrote: >> Coleen Phillimore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove now-unused function that I missed. > > src/hotspot/share/gc/z/zHeap.inline.hpp line 48: > >> 46: inline uint

Re: RFR: 8256072: Eliminate JVMTI tagmap rehashing [v3]

2022-11-02 Thread Kim Barrett
On Wed, 2 Nov 2022 22:23:57 GMT, Coleen Phillimore wrote: >> Use identity_hash for objects in the JVMTI TagMap table. If the object has >> no hashcode, it's not in the table. >> Tested with tier1-6. > > Coleen Phillimore has updated the pull request incrementally with one > additional commit s

Re: RFR: 8256072: Eliminate JVMTI tagmap rehashing [v2]

2022-11-02 Thread Coleen Phillimore
On Wed, 2 Nov 2022 20:44:58 GMT, Coleen Phillimore wrote: >> Use identity_hash for objects in the JVMTI TagMap table. If the object has >> no hashcode, it's not in the table. >> Tested with tier1-6. > > Coleen Phillimore has updated the pull request with a new target base due to > a merge or a

Re: RFR: 8256072: Eliminate JVMTI tagmap rehashing [v3]

2022-11-02 Thread Coleen Phillimore
> Use identity_hash for objects in the JVMTI TagMap table. If the object has > no hashcode, it's not in the table. > Tested with tier1-6. Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision: Remove now-unused function that I missed.

Re: RFR: 8256072: Eliminate JVMTI tagmap rehashing [v2]

2022-11-02 Thread Kim Barrett
On Wed, 2 Nov 2022 20:44:58 GMT, Coleen Phillimore wrote: >> Use identity_hash for objects in the JVMTI TagMap table. If the object has >> no hashcode, it's not in the table. >> Tested with tier1-6. > > Coleen Phillimore has updated the pull request with a new target base due to > a merge or a

Re: RFR: 8283101: serviceability/jvmti/thread/GetFrameCount/framecnt01/framecnt01.java failing #VirtualThread-Frozen: number of frames expected: 14, got: 9

2022-11-02 Thread Kevin Walls
On Wed, 2 Nov 2022 16:06:41 GMT, Leonid Mesnik wrote: > …t01.java failing #VirtualThread-Frozen: number of frames expected: 14, got: 9 Looks good to me! - Marked as reviewed by kevinw (Committer). PR: https://git.openjdk.org/jdk/pull/10951

Re: RFR: 8256072: Eliminate JVMTI tagmap rehashing [v2]

2022-11-02 Thread Coleen Phillimore
> Use identity_hash for objects in the JVMTI TagMap table. If the object has > no hashcode, it's not in the table. > Tested with tier1-6. Coleen Phillimore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brou

Re: RFR: 8283101: serviceability/jvmti/thread/GetFrameCount/framecnt01/framecnt01.java failing #VirtualThread-Frozen: number of frames expected: 14, got: 9

2022-11-02 Thread Serguei Spitsyn
On Wed, 2 Nov 2022 16:06:41 GMT, Leonid Mesnik wrote: > …t01.java failing #VirtualThread-Frozen: number of frames expected: 14, got: 9 As I understand this change is ported from the Loom repo. Looks good to me. Thanks, Serguei - Marked as reviewed by sspitsyn (Reviewer). PR: https

New candidate JEP: 435: Asynchronous Stack Trace VM API

2022-11-02 Thread Mark Reinhold
https://openjdk.org/jeps/435 Summary: Define an efficient and reliable API to collect stack traces asynchronously and include information on both Java and native stack frames. - Mark

RE: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-02 Thread Langer, Christoph
Hi Mark, yes, you can set me as the owner. Thanks Christoph > -Original Message- > From: Mark Reinhold > Sent: Mittwoch, 2. November 2022 19:15 > To: Bechberger, Johannes > Cc: andrei.pan...@gmail.com; Langer, Christoph ; > jaroslav.bacho...@datadoghq.com; serviceability-dev@openjdk.or

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-02 Thread Bechberger, Johannes
I only have 10 changes in the OpenJDK (and most them are smaller bug fixes), therefore I did not yet become a committer. - Johannes From: Mark Reinhold Date: Wednesday, 2. November 2022 at 19:15 To: Bechberger, Johannes Cc: andrei.pan...@gmail.com , Langer, Christoph , jaroslav.bacho...@datad

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-02 Thread Mark Reinhold
Johannes -- I just now noticed that you’re not yet a Committer, so per the JEP process [1] you can author but not submit or own a JEP. Christoph, Jaroslav -- as active JDK Project Reviewers, would one of you be willing to be the owner of record for this JEP? - Mark [1] https://cr.openjdk.java.n

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-02 Thread Bechberger, Johannes
Ah, you’re right. Thanks for the revision. - Johannes From: Mark Reinhold Date: Wednesday, 2. November 2022 at 19:06 To: Bechberger, Johannes Cc: andrei.pan...@gmail.com , Langer, Christoph , jaroslav.bacho...@datadoghq.com , serviceability-dev@openjdk.org Subject: Re: Submitted JEP: Asynch

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-11-02 Thread Mark Reinhold
2022/11/1 1:15:13 -0700, johannes.bechber...@sap.com: > Thanks for your corrections. I only corrected one minor thing: I > removed “; in a JDK image it should be copied into the `include` > directory”, as I forgot to remove after moving the header to a > location which is auto copied. What’s impor

RFR: 8256072: Eliminate JVMTI tagmap rehashing

2022-11-02 Thread Coleen Phillimore
Use identity_hash for objects in the JVMTI TagMap table. If the object has no hashcode, it's not in the table. Tested with tier1-6. - Commit messages: - 8256072: Eliminate JVMTI tagmap rehashing Changes: https://git.openjdk.org/jdk/pull/10938/files Webrev: https://webrevs.openjdk

Re: RFR: 8283101: serviceability/jvmti/thread/GetFrameCount/framecnt01/framecnt01.java failing #VirtualThread-Frozen: number of frames expected: 14, got: 9

2022-11-02 Thread Leonid Mesnik
On Wed, 2 Nov 2022 16:06:41 GMT, Leonid Mesnik wrote: > …t01.java failing #VirtualThread-Frozen: number of frames expected: 14, got: 9 The fix is backported from loom repo where it has been tested for a while. - PR: https://git.openjdk.org/jdk/pull/10951

RFR: 8283101: serviceability/jvmti/thread/GetFrameCount/framecnt01/framecnt01.java failing #VirtualThread-Frozen: number of frames expected: 14, got: 9

2022-11-02 Thread Leonid Mesnik
…t01.java failing #VirtualThread-Frozen: number of frames expected: 14, got: 9 - Commit messages: - 8283101: serviceability/jvmti/thread/GetFrameCount/framecnt01/framecnt01.java failing #VirtualThread-Frozen: number of frames expected: 14, got: 9 Changes: https://git.openjdk.org/j

Re: RFR: 8294241: Deprecate URL public constructors [v3]

2022-11-02 Thread Alan Bateman
On Tue, 1 Nov 2022 16:14:20 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism define