Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-31 Thread Alan Bateman
On Mon, 31 Oct 2022 22:00:01 GMT, Phil Race wrote: > You have jumped through some refactoring hoops to be able to apply the > deprecation suppression to as little code as possible .. having made such > changes, then why didn't you just make the recommended change instead ? > > Should I presume

Re: Submitted JEP: Asynchronous Stack Trace VM API

2022-10-31 Thread Mark Reinhold
I’ve edited the text of this JEP in JBS to tighten the prose, correct terminology, and fix a few formatting issues. HTML and diffs attached for reference. Please review and make any necessary corrections, then I’ll move it to Candidate. - Mark Title: JEP TBD: Asynchronous Stack Trace VM API JEP

Re: RFR: 8294241: Deprecate URL public constructors [v2]

2022-10-31 Thread Phil Race
On Fri, 28 Oct 2022 14:54:26 GMT, Daniel Fuchs wrote: >> Deprecate URL constructors. Developers are encouraged to use `java.net.URI` >> to parse or construct any URL. >> >> The `java.net.URL` class does not itself encode or decode any URL components >> according to the escaping mechanism defin

Re: RFR: 8296089: Remove debug agent code for special handling of Thread.resume()

2022-10-31 Thread Chris Plummer
On Mon, 31 Oct 2022 19:08:14 GMT, Chris Plummer wrote: > The debug agent sets a breakpoint in Thread.resume() so it can prevent the > debugger from suspending threads while in the resume call: > > /* > * Track the resuming thread by marking it as being within >

RFR: 8296089: Remove debug agent code for special handling of Thread.resume()

2022-10-31 Thread Chris Plummer
The debug agent sets a breakpoint in Thread.resume() so it can prevent the debugger from suspending threads while in the resume call: /* * Track the resuming thread by marking it as being within * a resume and by setting up for notification on

Re: JIT compiler turned off after stepping over in jdb

2022-10-31 Thread Chris Plummer
Hi Simeon, We have the following bug filed for the debug agent:     JDK-8229012: When single stepping, the debug agent can cause the thread to remain in interpreter mode after single stepping completes It will result in the behavior you are seeing. However, I'm not sure how it relates to the

JIT compiler turned off after stepping over in jdb

2022-10-31 Thread S A
Hi all, TL;DR We observe a significant performance degradation after stepping over in a debugger. By the looks of it, the interpreter only mode is entered and never left due to this change: https://github.com/openjdk/jdk11u/commit/dbb9eb5b9c3ddcbcfaae8ac4ca21760c9c99a15c#diff-fa220f091e99b08a3a20

Integrated: 8295964: Move InstanceKlass::_misc_flags

2022-10-31 Thread Coleen Phillimore
On Tue, 13 Sep 2022 13:29:45 GMT, Coleen Phillimore wrote: > I moved misc_flags out to their own misc flags class so that we can put the > writeable accessFlags there too with atomic access. > > Tested with tier1-4. This pull request has now been integrated. Changeset: 7e88209e Author:Col

Re: RFR: 8295964: Move InstanceKlass::_misc_flags

2022-10-31 Thread Coleen Phillimore
On Fri, 28 Oct 2022 04:01:18 GMT, David Holmes wrote: >> I moved misc_flags out to their own misc flags class so that we can put the >> writeable accessFlags there too with atomic access. >> >> Tested with tier1-4. > > src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java

Re: RFR: 8295964: Move InstanceKlass::_misc_flags

2022-10-31 Thread Coleen Phillimore
On Fri, 28 Oct 2022 03:59:45 GMT, David Holmes wrote: >> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 4408: >> >>> 4406: if (!the_class->has_been_redefined()) { >>> 4407: the_class->set_has_been_redefined(); >>> 4408: } >> >> Nit: Is this change really needed? > > Seems unrelat

Re: RFR: 8295964: Move InstanceKlass::_misc_flags

2022-10-31 Thread Coleen Phillimore
On Tue, 13 Sep 2022 13:29:45 GMT, Coleen Phillimore wrote: > I moved misc_flags out to their own misc flags class so that we can put the > writeable accessFlags there too with atomic access. > > Tested with tier1-4. Thank you for the code reviews, David and Serguei. - PR: https:/