On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Tue, 25 Oct 2022 00:55:17 GMT, Serguei Spitsyn wrote:
>> There are only 2 calls of removeNode and I don't see risk here. But fell
>> free to file separate RFE
>
> I agree with Alex that there should not be any risk here.
> But I'm okay if filing a separate RFE is more convenient to you.
I fi
On Mon, 24 Oct 2022 05:29:26 GMT, Chris Plummer wrote:
> Various debugger tests (mainly JCK vm/jdwp tests) are failing with:
>
> `FATAL ERROR in native method: JDWP SetTag,
> jvmtiError=JVMTI_ERROR_WRONG_PHASE(112) `
>
> Sometimes instead of `SetTag` the message says `GetTag` or `signature`.
On Mon, 24 Oct 2022 23:42:20 GMT, Alex Menkov wrote:
>> Yes. I did the assert to first convince myself that this would always be the
>> case. I was thinking it would be good to leave as-is until we get a full
>> round of testing first. Are you ok if I file an RFE instead?
>
> There are only 2 c
On Mon, 24 Oct 2022 23:05:31 GMT, Chris Plummer wrote:
>> I was almost to suggest the same.
>
> Yes. I did the assert to first convince myself that this would always be the
> case. I was thinking it would be good to leave as-is until we get a full
> round of testing first. Are you ok if I file
On Sat, 22 Oct 2022 03:05:07 GMT, Chris Plummer wrote:
> The implementation of removeThread() is currently:
>
>
> static void
> removeThread(JNIEnv *env, ThreadList *list, jthread thread)
> {
> ThreadNode *node;
>
> node = findThread(list, thread);
> if (node != NULL) {
> r
On Sat, 22 Oct 2022 01:38:44 GMT, Kim Barrett wrote:
> Please review this change to GrowableArray to support capacity management.
> Two functions are added to GrowableArray, reserve and shrink_to_fit. Also
> renamed the max_length function to capacity.
>
> Used these new functions in StringDedu
On Mon, 24 Oct 2022 22:56:08 GMT, Serguei Spitsyn wrote:
>> src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c line 322:
>>
>>> 320: ThreadNode *next;
>>> 321:
>>> 322: JDI_ASSERT(list == node->list);
>>
>> "list" argument is redundant
>> I suggest to drop it and replace this asse
On Mon, 24 Oct 2022 20:43:48 GMT, Alex Menkov wrote:
>> The implementation of removeThread() is currently:
>>
>>
>> static void
>> removeThread(JNIEnv *env, ThreadList *list, jthread thread)
>> {
>> ThreadNode *node;
>>
>> node = findThread(list, thread);
>> if (node != NULL) {
>>
On Sat, 22 Oct 2022 03:05:07 GMT, Chris Plummer wrote:
> The implementation of removeThread() is currently:
>
>
> static void
> removeThread(JNIEnv *env, ThreadList *list, jthread thread)
> {
> ThreadNode *node;
>
> node = findThread(list, thread);
> if (node != NULL) {
> r
On Fri, 21 Oct 2022 21:39:23 GMT, Leonid Mesnik wrote:
>> The fix removes nsk/jvmti/ tests ported to serviceability/jvmti and
>> forward-ports corresponding fixed. The suspend/resume tests require more
>> work covered by https://bugs.openjdk.org/browse/JDK-8295169.
>
> Leonid Mesnik has update
On Mon, 24 Oct 2022 21:09:05 GMT, Serguei Spitsyn wrote:
> I hope it solves the problem observed with the JCK tests.
> In fact, we sometimes keep forgetting to run JCK tests. 👍
Yes, but it's also turning up with some JDI tests. I did a lot of testing, and
have done a bunch since for other chang
On Mon, 24 Oct 2022 21:28:55 GMT, Serguei Spitsyn wrote:
> Thank you for the update. One more question. A couple of tests are not listed
> in the `test/hotspot/jtreg/TEST.quick-groups`:
>
> ```
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/GetFrameLocation/frameloc001
> test/hotspot/jtreg/vmTes
On Fri, 21 Oct 2022 21:39:23 GMT, Leonid Mesnik wrote:
>> The fix removes nsk/jvmti/ tests ported to serviceability/jvmti and
>> forward-ports corresponding fixed. The suspend/resume tests require more
>> work covered by https://bugs.openjdk.org/browse/JDK-8295169.
>
> Leonid Mesnik has update
On Mon, 24 Oct 2022 05:29:26 GMT, Chris Plummer wrote:
> Various debugger tests (mainly JCK vm/jdwp tests) are failing with:
>
> `FATAL ERROR in native method: JDWP SetTag,
> jvmtiError=JVMTI_ERROR_WRONG_PHASE(112) `
>
> Sometimes instead of `SetTag` the message says `GetTag` or `signature`.
On Sat, 22 Oct 2022 03:05:07 GMT, Chris Plummer wrote:
> The implementation of removeThread() is currently:
>
>
> static void
> removeThread(JNIEnv *env, ThreadList *list, jthread thread)
> {
> ThreadNode *node;
>
> node = findThread(list, thread);
> if (node != NULL) {
> r
On Mon, 17 Oct 2022 20:16:49 GMT, Kevin Walls wrote:
>> There are a few changes we can make to better understand the LingeredApp
>> test when it goes wrong:
>>
>> startAppExactJvmOpts() should not try and call finishApp unless the process
>> isAlive, that just creates a misleading exception.
>
On Mon, 24 Oct 2022 19:39:21 GMT, Jonathan Gibbons wrote:
> I think it would be better to try and remove incidental trailing whitespace
> first, before encoding any remaining whitespace. Hiding the trailing
> whitespace as a Unicode escape seems like a bad idea, equivalent to sweeping
> the is
On Mon, 24 Oct 2022 20:08:02 GMT, Andy Goryachev wrote:
> Good idea! I wonder if this should be done as a unit test. go through all the
> bundles and check leading/trailing whitespace.
Right. Definitely not a job for `jcheck`, but it should be considered somewhere
in the l10n process.
---
On Mon, 24 Oct 2022 19:58:31 GMT, Naoto Sato wrote:
> I think what we can do is check the original English properties values that
> the engineers provided, and if there is no trailing spaces there, we can
> safely remove trailing spaces in localized bundles.
Good idea! I wonder if this should
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Mon, 24 Oct 2022 19:23:04 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert "Remove check for .properties from jcheck"
>>
>>This reverts commit c91fdaa19dc06351598bd1c061
On Mon, 24 Oct 2022 19:34:56 GMT, Magnus Ihse Bursie wrote:
> For the files which have trailing "whitespace" (now as unicode sequences), I
> will file follow-up bugs on the respective components to verify if this is
> indeed correct, or a bug that should be fixed.
probably not needed - if nobo
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Mon, 24 Oct 2022 19:20:24 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Remove check for .properties from jcheck
>> - Restore trailing whitespace for property values
>
> 368 files
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the coverage of the
> whitespace checks (in the old mercurial ve
On Sat, 22 Oct 2022 03:05:07 GMT, Chris Plummer wrote:
> The implementation of removeThread() is currently:
>
>
> static void
> removeThread(JNIEnv *env, ThreadList *list, jthread thread)
> {
> ThreadNode *node;
>
> node = findThread(list, thread);
> if (node != NULL) {
> r
On Sat, 22 Oct 2022 01:38:44 GMT, Kim Barrett wrote:
> Please review this change to GrowableArray to support capacity management.
> Two functions are added to GrowableArray, reserve and shrink_to_fit. Also
> renamed the max_length function to capacity.
>
> Used these new functions in StringDedu
On Mon, 24 Oct 2022 08:03:13 GMT, Roman Kennke wrote:
>> This change replaces the current stack-locking implementation with a
>> fast-locking scheme that retains the advantages of stack-locking (namely
>> fast locking in uncontended code-paths), while avoiding the overload of the
>> mark word.
On Sat, 22 Oct 2022 01:38:44 GMT, Kim Barrett wrote:
> Please review this change to GrowableArray to support capacity management.
> Two functions are added to GrowableArray, reserve and shrink_to_fit. Also
> renamed the max_length function to capacity.
>
> Used these new functions in StringDedu
On Wed, 19 Oct 2022 15:43:17 GMT, Richard Reingruber wrote:
> With `StressReflectiveCode` C2 has inexact type information which can prevent
> ea
> based optimizations (see `ConnectionGraph::add_call_node()`)
>
> This pr changes the test jdk/com/sun/jdi/EATests.java to read the flag
> `StressRef
> This change replaces the current stack-locking implementation with a
> fast-locking scheme that retains the advantages of stack-locking (namely fast
> locking in uncontended code-paths), while avoiding the overload of the mark
> word. That overloading causes massive problems with Lilliput, bec
On Thu, 20 Oct 2022 20:55:12 GMT, Richard Reingruber wrote:
>> With `StressReflectiveCode` C2 has inexact type information which can
>> prevent ea
>> based optimizations (see `ConnectionGraph::add_call_node()`)
>>
>> This pr changes the test jdk/com/sun/jdi/EATests.java to read the flag
>> `Str
37 matches
Mail list logo
