On Thu, 20 Oct 2022 20:55:12 GMT, Richard Reingruber wrote:
>> With `StressReflectiveCode` C2 has inexact type information which can
>> prevent ea
>> based optimizations (see `ConnectionGraph::add_call_node()`)
>>
>> This pr changes the test jdk/com/sun/jdi/EATests.java to read the flag
>> `Str
On Tue, 11 Oct 2022 19:00:11 GMT, Leonid Mesnik wrote:
> The fix removes nsk/jvmti/ tests ported to serviceability/jvmti and
> forward-ports corresponding fixed. The suspend/resume tests require more work
> covered by https://bugs.openjdk.org/browse/JDK-8295169.
A question.
I do not see the f
On Thu, 20 Oct 2022 01:21:19 GMT, Chris Plummer wrote:
> The debug agent needs to keep track of all loaded classes, and also be
> notified when they are unloaded. It tracks classes loading by getting
> CLASS_PREPARE events and it tracks their unloading by tagging them, which
> triggers OBJECT_
On Fri, 21 Oct 2022 01:02:21 GMT, Alex Menkov wrote:
> Failures of the test are usually caused by unexpected frame in the stack.
> Also the failures are intermittent, so it makes sense to report more details
> on error to simplify analysis.
> The fix adds stack trace printing if the test fails
On Fri, 21 Oct 2022 01:02:21 GMT, Alex Menkov wrote:
> Failures of the test are usually caused by unexpected frame in the stack.
> Also the failures are intermittent, so it makes sense to report more details
> on error to simplify analysis.
> The fix adds stack trace printing if the test fails
On Fri, 21 Oct 2022 01:02:21 GMT, Alex Menkov wrote:
> Failures of the test are usually caused by unexpected frame in the stack.
> Also the failures are intermittent, so it makes sense to report more details
> on error to simplify analysis.
> The fix adds stack trace printing if the test fails
Failures of the test are usually caused by unexpected frame in the stack.
Also the failures are intermittent, so it makes sense to report more details on
error to simplify analysis.
The fix adds stack trace printing if the test fails
-
Commit messages:
- JDK-8295427
Changes: https:
On Mon, 17 Oct 2022 19:22:26 GMT, Alex Menkov wrote:
> The fix resolved conflicts between jvmti test shared code:
> test/lib/jdk/test/lib/jvmti/jvmti_common.h and
> test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/* to allot NSK tests to use
> jvmti_common.h
>
> testing: test native libraries ar
On Thu, 20 Oct 2022 20:55:12 GMT, Richard Reingruber wrote:
>> With `StressReflectiveCode` C2 has inexact type information which can
>> prevent ea
>> based optimizations (see `ConnectionGraph::add_call_node()`)
>>
>> This pr changes the test jdk/com/sun/jdi/EATests.java to read the flag
>> `Str
> With `StressReflectiveCode` C2 has inexact type information which can prevent
> ea
> based optimizations (see `ConnectionGraph::add_call_node()`)
>
> This pr changes the test jdk/com/sun/jdi/EATests.java to read the flag
> `StressReflectiveCode`. If enabled it shall neither expect ea based
> o
On Thu, 20 Oct 2022 20:04:23 GMT, Richard Reingruber wrote:
> > Should we add check for `StressReflectiveCode` to all `shouldSkip()`
> > methods too? Similar to `DeoptimizeObjectsALot` flag.
>
> I'd be ok to skip all testcases (by checking for `StressReflectiveCode` in
> the base classes' `sho
On Thu, 20 Oct 2022 19:52:39 GMT, Vladimir Kozlov wrote:
> Should we add check for `StressReflectiveCode` to all `shouldSkip()` methods
> too? Similar to `DeoptimizeObjectsALot` flag.
I'd be ok to skip all testcases (by checking for `StressReflectiveCode` in the
base classes' `shouldSkip()`).
On Wed, 19 Oct 2022 15:43:17 GMT, Richard Reingruber wrote:
> With `StressReflectiveCode` C2 has inexact type information which can prevent
> ea
> based optimizations (see `ConnectionGraph::add_call_node()`)
>
> This pr changes the test jdk/com/sun/jdi/EATests.java to read the flag
> `StressRef
On Wed, 19 Oct 2022 15:43:17 GMT, Richard Reingruber wrote:
> With `StressReflectiveCode` C2 has inexact type information which can prevent
> ea
> based optimizations (see `ConnectionGraph::add_call_node()`)
>
> This pr changes the test jdk/com/sun/jdi/EATests.java to read the flag
> `StressRef
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Wed, 19 Oct 2022 15:43:17 GMT, Richard Reingruber wrote:
> With `StressReflectiveCode` C2 has inexact type information which can prevent
> ea
> based optimizations (see `ConnectionGraph::add_call_node()`)
>
> This pr changes the test jdk/com/sun/jdi/EATests.java to read the flag
> `StressRef
With `StressReflectiveCode` C2 has inexact type information which can prevent ea
based optimizations (see `ConnectionGraph::add_call_node()`)
This pr changes the test jdk/com/sun/jdi/EATests.java to read the flag
`StressReflectiveCode`. If enabled it shall neither expect ea based
optimizations
of
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Thu, 20 Oct 2022 01:21:19 GMT, Chris Plummer wrote:
> The debug agent needs to keep track of all loaded classes, and also be
> notified when they are unloaded. It tracks classes loading by getting
> CLASS_PREPARE events and it tracks their unloading by tagging them, which
> triggers OBJECT_
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Thu, 20 Oct 2022 10:15:50 GMT, Magnus Ihse Bursie wrote:
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in the
> serv
On Thu, 20 Oct 2022 18:46:04 GMT, Magnus Ihse Bursie wrote:
>> I would vote against this change. Per java properties spec
>> https://github.com/openjdk/jdk/pull/10792
>>
>>
>> White space following the property value is not ignored, and is treated as
>> part of the property value.
>>
>>
>>
On Thu, 20 Oct 2022 18:38:43 GMT, Andy Goryachev wrote:
> `White space following the property value is not ignored, and is treated as
> part of the property value.`
Although I didn't know this was in the spec, I suspected it might be the case.
When looking at the jdk.management.agent changes,
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Thu, 20 Oct 2022 17:54:51 GMT, Chris Plummer wrote:
>> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
>> possible to disable warnings for individual files instead for whole
>> libraries. I used this opportunity to go through all disabled warnings in
>> the servi
On Thu, 20 Oct 2022 18:38:43 GMT, Andy Goryachev wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increase th
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Thu, 20 Oct 2022 10:15:50 GMT, Magnus Ihse Bursie wrote:
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in the
> serv
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Thu, 20 Oct 2022 10:15:50 GMT, Magnus Ihse Bursie wrote:
> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
> possible to disable warnings for individual files instead for whole
> libraries. I used this opportunity to go through all disabled warnings in the
> serv
On Thu, 20 Oct 2022 09:40:55 GMT, Aleksey Shipilev wrote:
>> Found this when working on JOL support
>> ([CODETOOLS-7903364](https://bugs.openjdk.org/browse/CODETOOLS-7903364)). If
>> you try to attach to VM running with -XX:ObjectAlignmentInBytes=32, then SA
>> would fail with:
>>
>>
>> Caus
On Thu, 20 Oct 2022 10:01:19 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which proposes to fix the
>> recent intermittent failures in `RmiBootstrapTest` reported in
>> https://bugs.openjdk.org/browse/JDK-8030616?
>>
>> The test has been intermittently failing
On Thu, 20 Oct 2022 10:01:19 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which proposes to fix the
>> recent intermittent failures in `RmiBootstrapTest` reported in
>> https://bugs.openjdk.org/browse/JDK-8030616?
>>
>> The test has been intermittently failing
On Thu, 20 Oct 2022 10:01:19 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this test only change which proposes to fix the
>> recent intermittent failures in `RmiBootstrapTest` reported in
>> https://bugs.openjdk.org/browse/JDK-8030616?
>>
>> The test has been intermittently failing
On Thu, 20 Oct 2022 09:35:16 GMT, Aleksey Shipilev wrote:
> Ran those too with different object alignments. I am running tests with
> different GCs too.
Ran with Serial, Parallel, G1. Shenandoah and ZGC have problems with SA tests
even with default object alignment, so I skipped those. Serial
Properties files is essentially source code. It should have the same whitespace
checks as all other source code, so we don't get spurious trailing whitespace
changes.
With the new Skara jcheck, it is possible to increase the coverage of the
whitespace checks (in the old mercurial version, this
After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now
possible to disable warnings for individual files instead for whole libraries.
I used this opportunity to go through all disabled warnings in the
serviceability native libraries.
Any warnings that were only triggered in
On Sun, 18 Sep 2022 11:52:28 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test only change which proposes to fix the
> recent intermittent failures in `RmiBootstrapTest` reported in
> https://bugs.openjdk.org/browse/JDK-8030616?
>
> The test has been intermittently failing with
> Can I please get a review of this test only change which proposes to fix the
> recent intermittent failures in `RmiBootstrapTest` reported in
> https://bugs.openjdk.org/browse/JDK-8030616?
>
> The test has been intermittently failing with `cannot find a free port after
> 10 tries`. The tests
On Wed, 19 Oct 2022 22:44:37 GMT, Chris Plummer wrote:
>> Yes. I don't see a need for it.
>
> You could keep in the check to make sure it is aligned to a power of 2, since
> I doubt SA would work with a value that isn't, but then I don't see the
> possibility of hotspot ever supporting it eithe
On Wed, 19 Oct 2022 21:02:13 GMT, Chris Plummer wrote:
> Sorry, I missed that. There are also some SA tests in
> test/jdk/sun/tools/jhsdb.
Ran those too with different object alignments. I am running tests with
different GCs too.
-
PR: https://git.openjdk.org/jdk/pull/10762
> Found this when working on JOL support
> ([CODETOOLS-7903364](https://bugs.openjdk.org/browse/CODETOOLS-7903364)). If
> you try to attach to VM running with -XX:ObjectAlignmentInBytes=32, then SA
> would fail with:
>
>
> Caused by: java.lang.RuntimeException: Object alignment 32 not yet supp
43 matches
Mail list logo
