Re: RFR: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread [v3]

2022-10-10 Thread Serguei Spitsyn
> The spec of JVM TI GetLocalXXX/SetLocalXXX functions is updated to require > the target thread to be suspended. If not suspended then the > JVMTI_ERROR_THREAD_NOT_SUSPENDED error code is returned by the implementation. > > The CSR is: https://bugs.openjdk.org/browse/JDK-8294690 > > A few test

Re: RFR: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread [v2]

2022-10-10 Thread Serguei Spitsyn
On Mon, 10 Oct 2022 10:08:59 GMT, Andrey Turbanov wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> addressed review comments about is_JavaThread_current and @enablePreview >> tag > > test/hotspot/jtreg/serviceab

Re: RFR: 8294689: The SA transported_core.html file needs quite a bit of work [v4]

2022-10-10 Thread Serguei Spitsyn
On Mon, 10 Oct 2022 21:57:25 GMT, Chris Plummer wrote: >> src/jdk.hotspot.agent/doc/transported_core.html line 66: >> >>> 64: set SA_ALTROOT=/altroot, then /altroot will be prepended >>> to any path found >>> 65: in the core file, and also prepended to any subdir with the root part >>> strip

Re: RFR: 8294689: The SA transported_core.html file needs quite a bit of work [v5]

2022-10-10 Thread Serguei Spitsyn
On Mon, 10 Oct 2022 21:54:09 GMT, Chris Plummer wrote: >> The main issues I set out to address are: >> >> - legacy Solaris references can be removed >> - add help with dealing with Windows core files, most of important of which >> is use of PATH to find the dlls referenced by the core file. >>

Re: RFR: 8294689: The SA transported_core.html file needs quite a bit of work [v4]

2022-10-10 Thread Chris Plummer
On Mon, 10 Oct 2022 20:25:18 GMT, Serguei Spitsyn wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> some minor edits > > src/jdk.hotspot.agent/doc/transported_core.html line 99: > >> 97: >> 98: >> 99: For locatin

Re: RFR: 8294689: The SA transported_core.html file needs quite a bit of work [v4]

2022-10-10 Thread Chris Plummer
On Mon, 10 Oct 2022 20:22:27 GMT, Serguei Spitsyn wrote: >> Chris Plummer has updated the pull request incrementally with one additional >> commit since the last revision: >> >> some minor edits > > src/jdk.hotspot.agent/doc/transported_core.html line 66: > >> 64: set SA_ALTROOT=/altroot, t

Re: RFR: 8294689: The SA transported_core.html file needs quite a bit of work [v5]

2022-10-10 Thread Chris Plummer
> The main issues I set out to address are: > > - legacy Solaris references can be removed > - add help with dealing with Windows core files, most of important of which > is use of PATH to find the dlls referenced by the core file. > - add help with dealing with macOS core files, most of importan

Re: RFR: 8294689: The SA transported_core.html file needs quite a bit of work [v4]

2022-10-10 Thread Serguei Spitsyn
On Sat, 8 Oct 2022 15:35:24 GMT, Chris Plummer wrote: >> The main issues I set out to address are: >> >> - legacy Solaris references can be removed >> - add help with dealing with Windows core files, most of important of which >> is use of PATH to find the dlls referenced by the core file. >> -

Re: RFR: 8294689: The SA transported_core.html file needs quite a bit of work [v4]

2022-10-10 Thread Serguei Spitsyn
On Sat, 8 Oct 2022 15:35:24 GMT, Chris Plummer wrote: >> The main issues I set out to address are: >> >> - legacy Solaris references can be removed >> - add help with dealing with Windows core files, most of important of which >> is use of PATH to find the dlls referenced by the core file. >> -

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

2022-10-10 Thread Andrey Turbanov
On Wed, 18 May 2022 18:14:52 GMT, Severin Gehwolf wrote: >> Please review this change to the cgroup v1 subsystem which makes it more >> resilient on some of the stranger systems. Unfortunately, I wasn't able to >> re-create a similar system as the reporter. The idea of using the longest >> sub

Re: RFR: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread [v2]

2022-10-10 Thread Andrey Turbanov
On Thu, 6 Oct 2022 17:31:00 GMT, Serguei Spitsyn wrote: >> The spec of JVM TI GetLocalXXX/SetLocalXXX functions is updated to require >> the target thread to be suspended. If not suspended then the >> JVMTI_ERROR_THREAD_NOT_SUSPENDED error code is returned by the >> implementation. >> >> The