Re: RFR: 8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3

2022-09-29 Thread Serguei Spitsyn
On Thu, 29 Sep 2022 07:21:46 GMT, Serguei Spitsyn wrote: > The test SuspendResume fails on linux-aarch64 with timeouts. > However, it never fails when test timeout is set to a bigger value: > > diff --git > a/test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java >

Re: RFR: 8294406: Test runtime/handshake/HandshakeDirectTest.java failed: JVMTI_ERROR_WRONG_PHASE

2022-09-29 Thread Serguei Spitsyn
On Fri, 30 Sep 2022 04:37:58 GMT, David Holmes wrote: > Why is `JVMTI_ERROR_WRONG_PHASE` a valid result here? I think, it is because the testing `suspendResumeThread` tread is a daemon thread. I'm not sure why it was set to be a daemon thread though. - PR: https://git.openjdk.org/

Re: RFR: 8294406: Test runtime/handshake/HandshakeDirectTest.java failed: JVMTI_ERROR_WRONG_PHASE

2022-09-29 Thread David Holmes
On Fri, 30 Sep 2022 01:32:44 GMT, Leonid Mesnik wrote: > 8294406: Test runtime/handshake/HandshakeDirectTest.java failed: > JVMTI_ERROR_WRONG_PHASE Why is `JVMTI_ERROR_WRONG_PHASE` a valid result here? - PR: https://git.openjdk.org/jdk/pull/10502

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-29 Thread Iris Clark
On Fri, 30 Sep 2022 01:11:45 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated th

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org

2022-09-29 Thread Joe Darcy
On Fri, 30 Sep 2022 00:48:02 GMT, Mikael Vidstedt wrote: > Switch to https where needed/applicable while at it? Good idea; might as well do the update in a single changeset. - PR: https://git.openjdk.org/jdk/pull/10501

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v4]

2022-09-29 Thread Joe Darcy
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with one additional commit sinc

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v3]

2022-09-29 Thread Joe Darcy
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with one additional commit sinc

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org

2022-09-29 Thread Mikael Vidstedt
On Fri, 30 Sep 2022 00:33:57 GMT, Joe Darcy wrote: > With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Switch to https where needed/app

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v2]

2022-09-29 Thread Mikael Vidstedt
On Fri, 30 Sep 2022 00:50:13 GMT, Joe Darcy wrote: >> With the domain change from openjdk.java.net to openjdk.org, references to >> URLs in the sources should be updated. >> >> Updates were made using a shell script. I"ll run a copyright updater before >> any push. > > Joe Darcy has updated th

Re: RFR: JDK-8294618: Update openjdk.java.net => openjdk.org [v2]

2022-09-29 Thread Joe Darcy
> With the domain change from openjdk.java.net to openjdk.org, references to > URLs in the sources should be updated. > > Updates were made using a shell script. I"ll run a copyright updater before > any push. Joe Darcy has updated the pull request incrementally with two additional commits sin

RFR: JDK-8294618: Update openjdk.java.net => openjdk.org

2022-09-29 Thread Joe Darcy
With the domain change from openjdk.java.net to openjdk.org, references to URLs in the sources should be updated. Updates were made using a shell script. I"ll run a copyright updater before any push. - Commit messages: - JDK-8294618: Update openjdk.java.net => openjdk.org Changes

Re: RFR: 8289711: Add container configuration data to mbeans [v10]

2022-09-29 Thread Andrey Turbanov
On Wed, 10 Aug 2022 02:10:25 GMT, xpbob wrote: >> Container configuration information is useful for troubleshooting >> problems,Exposing information in MBeans is ideal for monitoring, jConsole, >> and other scenarios. >> Results the following >> ![图片](https://user-images.githubusercontent.com/7

Integrated: 8294547: HotSpotAgent.setupVM() should include "cause" exception when throwing DebuggerException

2022-09-29 Thread Chris Plummer
On Wed, 28 Sep 2022 22:38:44 GMT, Chris Plummer wrote: > In `HotSpotAgent.setupVM()`, if there is an underlying exception in the vm > setup, the exception is consumed and a `DebuggerException` is thrown, hiding > the root cause. When throwing the `DebuggerException`, the "cause" exception > sh

Integrated: 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316

2022-09-29 Thread Chris Plummer
On Wed, 28 Sep 2022 23:32:24 GMT, Chris Plummer wrote: > The SA core file tests are already problem listed on macosx-x64 due to > [JDK-8267433](https://bugs.openjdk.org/browse/JDK-8267433), but they should > also be due to [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316), > which is

Re: RFR: 8294547: HotSpotAgent.setupVM() should include "cause" exception when throwing DebuggerException

2022-09-29 Thread Coleen Phillimore
On Wed, 28 Sep 2022 22:38:44 GMT, Chris Plummer wrote: > In `HotSpotAgent.setupVM()`, if there is an underlying exception in the vm > setup, the exception is consumed and a `DebuggerException` is thrown, hiding > the root cause. When throwing the `DebuggerException`, the "cause" exception > sh

Re: RFR: 8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3

2022-09-29 Thread Chris Plummer
On Thu, 29 Sep 2022 07:21:46 GMT, Serguei Spitsyn wrote: > The test SuspendResume fails on linux-aarch64 with timeouts. > However, it never fails when test timeout is set to a bigger value: > > diff --git > a/test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java >

Re: RFR: 8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3

2022-09-29 Thread Chris Plummer
On Thu, 29 Sep 2022 07:21:46 GMT, Serguei Spitsyn wrote: > The test SuspendResume fails on linux-aarch64 with timeouts. > However, it never fails when test timeout is set to a bigger value: > > diff --git > a/test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java >

Integrated: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace()

2022-09-29 Thread Patricio Chilano Mateo
On Mon, 26 Sep 2022 14:23:38 GMT, Patricio Chilano Mateo wrote: > Please review this small fix in async_get_stack_trace(). The GrowableArrays > created to store the bci and Method* of each frame found while traversing the > stack are allocated in the resource area of the thread that calls > a

Re: RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v5]

2022-09-29 Thread Severin Gehwolf
> Similar issue to the hotspot change discussed in > https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation > may get the resource limits wrong if there are additional cgroup fs mounts. > Apparently that's more common than one might think. I've reproduced this with > these

Re: RFR: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj [v3]

2022-09-29 Thread Kim Barrett
On Wed, 28 Sep 2022 13:41:06 GMT, Johan Sjölen wrote: >> Or you could have the class that requires dynamic mtFlag be declared with >> mtNone and assert in one place in AllocateHeap that mt != mtNone. Actually >> that assert might already be there. Can't really puzzle out what Kim's >> change

Re: RFR: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj [v3]

2022-09-29 Thread Johan Sjölen
On Wed, 28 Sep 2022 13:45:53 GMT, Johan Sjölen wrote: >> Here's a suggested solution for the ticket mentioned and a use case for >> outputStream. I'm not attached to the name. >> >> This saves space for all allocated outputStreams, which is nice. It also >> makes the purpose of ResourceObj mor

Re: RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v3]

2022-09-29 Thread Severin Gehwolf
On Wed, 28 Sep 2022 05:45:14 GMT, Ioi Lam wrote: >> Severin Gehwolf has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains one commit: >> >> 8293540: [Metrics] Potentially incorrectly detected resource limits with >> additional cgroup

Re: RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v4]

2022-09-29 Thread Severin Gehwolf
> Similar issue to the hotspot change discussed in > https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation > may get the resource limits wrong if there are additional cgroup fs mounts. > Apparently that's more common than one might think. I've reproduced this with > these

Re: RFR: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj [v3]

2022-09-29 Thread Johan Sjölen
On Wed, 28 Sep 2022 18:21:09 GMT, Coleen Phillimore wrote: >> Johan Sjölen has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains six commits: >> >> - Introduce new, invalid, memory flag >> - delete _print_inlining_stream >> - Merge r

Re: RFR: 8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3

2022-09-29 Thread David Holmes
On Thu, 29 Sep 2022 07:21:46 GMT, Serguei Spitsyn wrote: > The test SuspendResume fails on linux-aarch64 with timeouts. > However, it never fails when test timeout is set to a bigger value: > > diff --git > a/test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java >

RFR: 8288907: serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java fails with -XX:TieredStopAtLevel=2,3

2022-09-29 Thread Serguei Spitsyn
The test SuspendResume fails on linux-aarch64 with timeouts. However, it never fails when test timeout is set to a bigger value: diff --git a/test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume1/SuspendResume1.java b/test/hotspot/jtreg/serviceability/jvmti/vthread/SuspendResume1/Suspe