Re: RFR: 8294547: HotSpotAgent.setupVM() should include "cause" exception when throwing DebuggerException

2022-09-28 Thread Serguei Spitsyn
On Wed, 28 Sep 2022 22:38:44 GMT, Chris Plummer wrote: > In `HotSpotAgent.setupVM()`, if there is an underlying exception in the vm > setup, the exception is consumed and a `DebuggerException` is thrown, hiding > the root cause. When throwing the `DebuggerException`, the "cause" exception > sh

Re: RFR: 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316

2022-09-28 Thread Serguei Spitsyn
On Wed, 28 Sep 2022 23:32:24 GMT, Chris Plummer wrote: > The SA core file tests are already problem listed on macosx-x64 due to > [JDK-8267433](https://bugs.openjdk.org/browse/JDK-8267433), but they should > also be due to [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316), > which is

RFR: 8294548: Problem list SA core file tests on macosx-x64 due to JDK-8294316

2022-09-28 Thread Chris Plummer
The SA core file tests are already problem listed on macosx-x64 due to [JDK-8267433](https://bugs.openjdk.org/browse/JDK-8267433), but they should also be due to [JDK-8294316](https://bugs.openjdk.org/browse/JDK-8294316), which is actually the much more serious of the two issues. I'd like to pu

RFR: 8294547: HotSpotAgent.setupVM() should include "cause" exception when throwing DebuggerException

2022-09-28 Thread Chris Plummer
In `HotSpotAgent.setupVM()`, if there is an underlying exception in the vm setup, the exception is consumed and a `DebuggerException` is thrown, hiding the root cause. When throwing the `DebuggerException`, the "cause" exception should be included. This provides a more detailed exception stack t

Integrated: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException

2022-09-28 Thread Chris Plummer
On Tue, 27 Sep 2022 21:38:43 GMT, Chris Plummer wrote: > JDK-8293563 is due to a macOS bug (or maybe a feature) that is resulting in > the java heap not always being present in the core file. Running with > `-XX:+AlwaysPreTouch` seems to work around this problem. This issue is only > on macosx

Re: RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException

2022-09-28 Thread Chris Plummer
On Tue, 27 Sep 2022 21:38:43 GMT, Chris Plummer wrote: > JDK-8293563 is due to a macOS bug (or maybe a feature) that is resulting in > the java heap not always being present in the core file. Running with > `-XX:+AlwaysPreTouch` seems to work around this problem. This issue is only > on macosx

Re: RFR: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj [v3]

2022-09-28 Thread Coleen Phillimore
On Wed, 28 Sep 2022 13:45:53 GMT, Johan Sjölen wrote: >> Here's a suggested solution for the ticket mentioned and a use case for >> outputStream. I'm not attached to the name. >> >> This saves space for all allocated outputStreams, which is nice. It also >> makes the purpose of ResourceObj mor

Integrated: 8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"

2022-09-28 Thread Chris Plummer
On Tue, 27 Sep 2022 05:16:35 GMT, Chris Plummer wrote: > Sometimes SA fails to startup with the following error message: > > ERROR: failed to workaround classshareing > Unable to open core file > > The code in question is init_classsharing_workaround() in ps_core_common.c. > There a number of

Re: RFR: 8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"

2022-09-28 Thread Chris Plummer
On Tue, 27 Sep 2022 05:16:35 GMT, Chris Plummer wrote: > Sometimes SA fails to startup with the following error message: > > ERROR: failed to workaround classshareing > Unable to open core file > > The code in question is init_classsharing_workaround() in ps_core_common.c. > There a number of

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-09-28 Thread Michael Ernst
On Wed, 28 Sep 2022 15:26:13 GMT, Alexey Ivanov wrote: > The title says under `test/jdk/*`, yet there are lots of files changed in > `src/*`. The title was edited by someone other than me, as you can see from the PR history. - PR: https://git.openjdk.org/jdk/pull/10029

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-09-28 Thread Alexey Ivanov
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote: >> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni > > Michael Ernst has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Reinstate t

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-09-28 Thread Daniel Fuchs
On Wed, 28 Sep 2022 14:45:54 GMT, Michael Ernst wrote: >> Michael Ernst has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains six commits: >> >> - Reinstate typos in Apache code that is copied into the JDK >> - Merge ../jdk-openjdk in

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-09-28 Thread Michael Ernst
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote: >> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni > > Michael Ernst has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains six commits: > > - Reinstate t

Re: RFR: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace() [v2]

2022-09-28 Thread Patricio Chilano Mateo
On Wed, 28 Sep 2022 14:43:43 GMT, Patricio Chilano Mateo wrote: >> Please review this small fix in async_get_stack_trace(). The GrowableArrays >> created to store the bci and Method* of each frame found while traversing >> the stack are allocated in the resource area of the thread that calls

Re: RFR: 8294370: Fix allocation bug in java_lang_Thread::async_get_stack_trace() [v2]

2022-09-28 Thread Patricio Chilano Mateo
> Please review this small fix in async_get_stack_trace(). The GrowableArrays > created to store the bci and Method* of each frame found while traversing the > stack are allocated in the resource area of the thread that calls > async_get_stack_trace(). But if the handshake is executed by the tar

Re: RFR: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj [v3]

2022-09-28 Thread Johan Sjölen
On Mon, 26 Sep 2022 15:34:29 GMT, Coleen Phillimore wrote: >> We can eliminate this problem: >> "I guess the risk is that you get mtInternal if you forget the parameter to >> new." >> >> We can instead have CHeapObj that *only* allocates with mtFoo, and >> CHeapObj<> that *requires* specifying

Re: RFR: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj [v3]

2022-09-28 Thread Johan Sjölen
> Here's a suggested solution for the ticket mentioned and a use case for > outputStream. I'm not attached to the name. > > This saves space for all allocated outputStreams, which is nice. It also > makes the purpose of ResourceObj more clear ("please handle the life cycle > for me"), reducing

Re: RFR: 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni [v2]

2022-09-28 Thread Daniel Fuchs
On Tue, 27 Sep 2022 23:12:43 GMT, Michael Ernst wrote: > Feel free to break up the pull request if that is what is needed to free it > from red tape. Only you can do that @mernst - PR: https://git.openjdk.org/jdk/pull/10029

Re: RFR: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException

2022-09-28 Thread Kevin Walls
On Tue, 27 Sep 2022 21:38:43 GMT, Chris Plummer wrote: > JDK-8293563 is due to a macOS bug (or maybe a feature) that is resulting in > the java heap not always being present in the core file. Running with > `-XX:+AlwaysPreTouch` seems to work around this problem. This issue is only > on macosx