Re: RFR: 8289607: Change hotspot/jtreg tests to not use Thread.suspend/resume [v3]

2022-09-21 Thread Chris Plummer
On Thu, 22 Sep 2022 03:04:26 GMT, Leonid Mesnik wrote: >> The Thread.suspend/resume is replaced by JVM TI SuspendThread/ResumeThread >> whether it is possible. >> Testcase from test >> test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java >> was removed because o

Re: RFR: 8289610: Degrade Thread.stop [v4]

2022-09-21 Thread Joe Darcy
On Sat, 17 Sep 2022 08:41:19 GMT, Alan Bateman wrote: >> Degrade Thread.stop to throw UOE unconditionally, deprecate ThreadDeath for >> removal, and remove the remaining special handling of ThreadDeath from the >> JDK. >> >> Thread.stop is inherently unsafe and has been deprecated since JDK 1.

Re: RFR: 8289607: Change hotspot/jtreg tests to not use Thread.suspend/resume [v2]

2022-09-21 Thread Leonid Mesnik
On Tue, 20 Sep 2022 21:41:31 GMT, Chris Plummer wrote: > > Testcase from test > > test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java > > was removed because only one environment can suspend threads so debugger > > is not compatible with JVM TI agent suspending te

Re: RFR: 8289607: Change hotspot/jtreg tests to not use Thread.suspend/resume [v3]

2022-09-21 Thread Leonid Mesnik
> The Thread.suspend/resume is replaced by JVM TI SuspendThread/ResumeThread > whether it is possible. > Testcase from test > test/hotspot/jtreg/vmTestbase/nsk/jdi/ThreadReference/interrupt/interrupt001.java > was removed because only one environment can suspend threads so debugger is > not

Re: RFR: 8249627: Degrade Thread.suspend and Thread.resume

2022-09-21 Thread Serguei Spitsyn
On Sun, 18 Sep 2022 16:32:31 GMT, Alan Bateman wrote: > Degrade Thread.suspend/resume to throw UOE unconditionally. > > Another step in the removal of this deadlock prone mis-feature from the > user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2 > (1998) and terminally de

Re: RFR: 8293613: need to properly handle and hide tmp VTMS transitions [v3]

2022-09-21 Thread Chris Plummer
On Tue, 20 Sep 2022 22:41:50 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/runtime/javaThread.cpp line 1174: >> >>> 1172: #if INCLUDE_JVMTI >>> 1173: // Suspending a JavaThread in VTMS transition or disabling VTMS >>> transitions can cause deadlocks. >>> 1174: assert(!is_in_non_tmp_VTMS_

Re: RFR: 8293613: need to properly handle and hide tmp VTMS transitions [v3]

2022-09-21 Thread Chris Plummer
On Tue, 20 Sep 2022 22:15:49 GMT, Serguei Spitsyn wrote: >> src/hotspot/share/prims/jvmtiEnvBase.cpp line 713: >> >>> 711: if (!jt->is_in_tmp_VTMS_transition()) { >>> 712: jvf = check_and_skip_hidden_frames(jt, jvf); >>> 713: } >> >> I think this comment needs some help. It's hard to ma

Re: RFR: 8249627: Degrade Thread.suspend and Thread.resume

2022-09-21 Thread Chris Plummer
On Sun, 18 Sep 2022 16:32:31 GMT, Alan Bateman wrote: > Degrade Thread.suspend/resume to throw UOE unconditionally. > > Another step in the removal of this deadlock prone mis-feature from the > user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2 > (1998) and terminally de

Integrated: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy

2022-09-21 Thread Thomas Stuefe
On Fri, 16 Sep 2022 14:55:42 GMT, Thomas Stuefe wrote: > Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be > omitted from the output if a parent class loader never loaded any class and > therefore had no associated DCmd. > > The fix changes the command to not rely on th

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v3]

2022-09-21 Thread Thomas Stuefe
On Wed, 21 Sep 2022 16:32:30 GMT, Chris Plummer wrote: >> Thomas Stuefe has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Fix test error in GHAs >> - feedback dholmes >> - childs->children > > Marked as reviewed by cjplummer (Reviewe

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v3]

2022-09-21 Thread Chris Plummer
On Wed, 21 Sep 2022 06:51:56 GMT, Thomas Stuefe wrote: >> Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be >> omitted from the output if a parent class loader never loaded any class and >> therefore had no associated DCmd. >> >> The fix changes the command to not rely

Re: RFR: 8249627: Degrade Thread.suspend and Thread.resume

2022-09-21 Thread Stuart Marks
On Sun, 18 Sep 2022 16:32:31 GMT, Alan Bateman wrote: > Degrade Thread.suspend/resume to throw UOE unconditionally. > > Another step in the removal of this deadlock prone mis-feature from the > user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2 > (1998) and terminally de

RFR: 8249627: Degrade Thread.suspend and Thread.resume

2022-09-21 Thread Alan Bateman
Degrade Thread.suspend/resume to throw UOE unconditionally. Another step in the removal of this deadlock prone mis-feature from the user-facing API. Thread.suspend/resume have been deprecated since JDK 1.2 (1998) and terminally deprecated since Java 14. ThreadGroup.suspend/resume were degraded

Re: RFR: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"

2022-09-21 Thread Kevin Walls
On Sun, 18 Sep 2022 12:57:28 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to fix the > intermittent failures noted in https://bugs.openjdk.org/browse/JDK-8293657? > > There are two parts to this fix. One is straightforward fix in the test > configuration f

Re: RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v3]

2022-09-21 Thread Severin Gehwolf
On Thu, 15 Sep 2022 08:55:41 GMT, Severin Gehwolf wrote: >> Similar issue to the hotspot change discussed in >> https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation >> may get the resource limits wrong if there are additional cgroup fs mounts. >> Apparently that's more

Re: RFR: 8289610: Degrade Thread.stop [v4]

2022-09-21 Thread Alan Bateman
On Wed, 21 Sep 2022 06:43:50 GMT, David Holmes wrote: > Okay I will defer to your views here. Thanks. Thank you, I'll get the CSR moving again and we'll try to get this done. - PR: https://git.openjdk.org/jdk/pull/10230

Re: RFR: JDK-8293156: Dcmd VM.classloaders fails to print the full hierarchy [v3]

2022-09-21 Thread David Holmes
On Wed, 21 Sep 2022 06:51:56 GMT, Thomas Stuefe wrote: >> Fixes a bug in the `VM.classloaders` jcmd that causes class loaders to be >> omitted from the output if a parent class loader never loaded any class and >> therefore had no associated DCmd. >> >> The fix changes the command to not rely

Re: RFR: 8293143: Workaround for JDK-8292217 when doing "step over" of bytecode with unresolved cp referernce

2022-09-21 Thread Serguei Spitsyn
On Wed, 31 Aug 2022 00:25:20 GMT, Chris Plummer wrote: > There is a workaround we can do for > [JDK-8292217](https://bugs.openjdk.org/browse/JDK-8292217) for the use case > where a step over or step out is being done. This workaround can't be made to > also work for the step into case. From >