Re: RFR: 8293879: Remove unnecessary castings in jdk.hotspot.agent

2022-09-15 Thread Chris Plummer
On Thu, 15 Sep 2022 20:49:14 GMT, Andrey Turbanov wrote: > Redundant castings make code harder to read. > Found them by IntelliJ IDEA. > I tried to choose only casts which are definitely safe to remove. > Most generification was done in > [JDK-8241618](https://bugs.openjdk.org/browse/JDK-8241618

Re: RFR: 8293879: Remove unnecessary castings in jdk.hotspot.agent

2022-09-15 Thread Leonid Mesnik
On Thu, 15 Sep 2022 20:49:14 GMT, Andrey Turbanov wrote: > Redundant castings make code harder to read. > Found them by IntelliJ IDEA. > I tried to choose only casts which are definitely safe to remove. > Most generification was done in > [JDK-8241618](https://bugs.openjdk.org/browse/JDK-8241618

RFR: 8293879: Remove unnecessary castings in jdk.hotspot.agent

2022-09-15 Thread Andrey Turbanov
Redundant castings make code harder to read. Found them by IntelliJ IDEA. I tried to choose only casts which are definitely safe to remove. Most generification was done in [JDK-8241618](https://bugs.openjdk.org/browse/JDK-8241618), but casts weren't removed. - Commit messages: - [P

Integrated: 8293875: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64

2022-09-15 Thread Daniel D . Daugherty
On Thu, 15 Sep 2022 19:27:47 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64. This pull request has now been integrated. Changeset: 6beeb847 Author:Daniel D. Daugherty URL: https://git.openj

Re: RFR: 8293875: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64

2022-09-15 Thread Daniel D . Daugherty
On Thu, 15 Sep 2022 19:32:14 GMT, Brian Burkhalter wrote: >> A trivial fix to ProblemList >> sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64. > > Marked as reviewed by bpb (Reviewer). @bplb - Thanks for the fast review. - PR: https://git.openjdk.org/jdk/p

Re: RFR: 8293875: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64

2022-09-15 Thread Brian Burkhalter
On Thu, 15 Sep 2022 19:27:47 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64. Marked as reviewed by bpb (Reviewer). - PR: https://git.openjdk.org/jdk/pull/10293

RFR: 8293875: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64

2022-09-15 Thread Daniel D . Daugherty
A trivial fix to ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64. - Commit messages: - 8293875: ProblemList sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 on linux-x64 Changes: https://git.openjdk.org/jdk/pull/10293/files Webrev

Integrated: 8289608: Change com/sun/jdi tests to not use Thread.suspend/resume

2022-09-15 Thread Leonid Mesnik
On Tue, 13 Sep 2022 23:05:00 GMT, Leonid Mesnik wrote: > There are 2 tests that should be deleted. They test Thread.suspend/resume and > don't have a sense if these functions don't work. This pull request has now been integrated. Changeset: 2028ec74 Author:Leonid Mesnik URL: https:

Integrated: 8244681: Add a warning for possibly lossy conversion in compound assignments

2022-09-15 Thread Adam Sotona
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote: > Please review this patch adding new lint option, **lossy-conversions**, to > javac to warn about type casts in compound assignments with possible lossy > conversions. > > The new lint warning is shown if the type of the right-hand operand o

Re: RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v3]

2022-09-15 Thread Severin Gehwolf
> Similar issue to the hotspot change discussed in > https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation > may get the resource limits wrong if there are additional cgroup fs mounts. > Apparently that's more common than one might think. I've reproduced this with > these

Re: RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts [v2]

2022-09-15 Thread Severin Gehwolf
> Similar issue to the hotspot change discussed in > https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation > may get the resource limits wrong if there are additional cgroup fs mounts. > Apparently that's more common than one might think. I've reproduced this with > these

Re: RFR: 8293540: [Metrics] Incorrectly detected resource limits with additional cgroup fs mounts

2022-09-15 Thread Severin Gehwolf
On Tue, 13 Sep 2022 13:06:10 GMT, Severin Gehwolf wrote: > Similar issue to the hotspot change discussed in > https://bugs.openjdk.org/browse/JDK-8293472. The Java metrics implementation > may get the resource limits wrong if there are additional cgroup fs mounts. > Apparently that's more comm