Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v4]

2022-08-01 Thread Serguei Spitsyn
On Tue, 2 Aug 2022 06:32:09 GMT, Ao Qi wrote: >> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and >> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java` >> are added or modified by >> [JDK-8284161](https://bugs.openjdk.org/browse/JDK-

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations" [v4]

2022-08-01 Thread Ao Qi
> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java` and > `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java` > are added or modified by > [JDK-8284161](https://bugs.openjdk.org/browse/JDK-8284161), and they are > failed if Loom or JVMTI is

Re: RFR: 8291650: Add delay to ClassUnloadEventTest before exiting to give time for JVM to send all events before VMDeath

2022-08-01 Thread Serguei Spitsyn
On Mon, 1 Aug 2022 21:02:39 GMT, Chris Plummer wrote: > Near the end of the test, the debuggee forces a GC so ClassUnloadEvents will > be generated, and then the debuggee immediately exits. However, the > ClassUnloadEvents might not be sent out before the VMDeath is generated, and > it prevent

Re: RFR: 8291650: Add delay to ClassUnloadEventTest before exiting to give time for JVM to send all events before VMDeath

2022-08-01 Thread Chris Plummer
On Mon, 1 Aug 2022 21:25:09 GMT, Serguei Spitsyn wrote: > This looks okay to me. > However, it can be still unreliable. > Is there a way to check-wait for the expected class unload events? The debuggee would need to block until the debugger says it got all the events. Currently the debugger jus

Integrated: 8282730: LdapLoginModule throw NPE from logout method after login failure

2022-08-01 Thread Weijun Wang
On Fri, 1 Jul 2022 17:31:06 GMT, Weijun Wang wrote: > Add null-checks in all `LoginModule` implementations. It's possible that an > application calls `logout` after a login failure, where most internal > variables for principals and credentials are null and removing a null from > the `Subject`

Re: RFR: 8291650: Add delay to ClassUnloadEventTest before exiting to give time for JVM to send all events before VMDeath

2022-08-01 Thread Serguei Spitsyn
On Mon, 1 Aug 2022 21:02:39 GMT, Chris Plummer wrote: > Near the end of the test, the debuggee forces a GC so ClassUnloadEvents will > be generated, and then the debuggee immediately exits. However, the > ClassUnloadEvents might not be sent out before the VMDeath is generated, and > it prevent

Re: RFR: 8291578: Remove JMX related tests from ProblemList-svc-vthreads.txt

2022-08-01 Thread Serguei Spitsyn
On Mon, 1 Aug 2022 20:05:02 GMT, Chris Plummer wrote: > These tests do not belong in ProblemList-svc-vthreads.txt. This problem list > is meant for tests that fail when the debuggee is run with the virtual thread > wrapper. These tests are not setup to run in that mode, and therefore never > a

RFR: 8291650: Add delay to ClassUnloadEventTest before exiting to give time for JVM to send all events before VMDeath

2022-08-01 Thread Chris Plummer
Near the end of the test, the debuggee forces a GC so ClassUnloadEvents will be generated, and then the debuggee immediately exits. However, the ClassUnloadEvents might not be sent out before the VMDeath is generated, and it prevents delivery of any more events. A short delay after the GC should

RFR: 8291578: Remove JMX related tests from ProblemList-svc-vthreads.txt

2022-08-01 Thread Chris Plummer
These tests do not belong in ProblemList-svc-vthreads.txt. This problem list is meant for tests that fail when the debuggee is run with the virtual thread wrapper. These tests are not setup to run in that mode, and therefore never are. They fail when the test itself is run with the jtreg virtual

Re: RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM

2022-08-01 Thread Chris Plummer
On Mon, 1 Aug 2022 07:41:50 GMT, Serguei Spitsyn wrote: > This is a regression that has been introduced by the fix of: > [8256811](https://bugs.openjdk.org/browse/JDK-8256811): Delayed/missed jdwp > class unloading events > > This is the relevant comment from Zhengyu: > > It is caused by https

Re: [jdk19] RFR: 8290889: JDK 19 RDP2 L10n resource files update - msgdrop 10 [v4]

2022-08-01 Thread Naoto Sato
On Fri, 29 Jul 2022 18:13:25 GMT, Alisen Chung wrote: >> open l10n msg drop >> All tests passed. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > added comments in CurrencyNames root in base, moved US CurrencyNames back > t

Re: RFR: 8291508: Fix some tests with "requires vm.jvmti & vm.continuations"

2022-08-01 Thread Ao Qi
On Mon, 1 Aug 2022 15:54:47 GMT, Alan Bateman wrote: > > Since these two kinds (`jvmti` and `XMLDecoder` tests) of the fix are a > > little different, should I split this issue into two? > > I think it would be better to split them. XMLDecoder tests are filed: https://bugs.openjdk.org/browse/J

Re: RFR: 8291508: Fix some tests with "requires vm.continuations" [v3]

2022-08-01 Thread Ao Qi
> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java`, > `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`, > `java/beans/XMLDecoder/8028054/TestConstructorFinder.java` and > `java/beans/XMLDecoder/8028054/TestMethodFinder.java` are added or

Re: RFR: 8291508: Fix some tests with "requires vm.continuations"

2022-08-01 Thread Alan Bateman
On Mon, 1 Aug 2022 12:02:19 GMT, Ao Qi wrote: > Since these two kinds (`jvmti` and `XMLDecoder` tests) of the fix are a > little different, should I split this issue into two? I think it would be better to split them. - PR: https://git.openjdk.org/jdk/pull/9677

RFR: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM

2022-08-01 Thread Serguei Spitsyn
This is a regression that has been introduced by the fix of: [8256811](https://bugs.openjdk.org/browse/JDK-8256811): Delayed/missed jdwp class unloading events This is the relevant comment from Zhengyu: It is caused by https://bugs.openjdk.org/browse/JDK-8256811 as JvmtiExport::post_object_free

[jdk19] RFR: 8290562: ThreadMXBean.getThread{Cpu, User}Time fails with -XX:-VMContinuations

2022-08-01 Thread Alan Bateman
ThreadMXBean.getThread{Cpu,User}Time is specified to return -1L when invoked with the id of a virtual thread. This isn't so when running with -XX:-VMContinuations (or ports without support for continuations in the VM) as it returns the cpu/user time of the OS thread that that the virtual thread

Re: RFR: 8291508: Fix some tests with "requires vm.continuations"

2022-08-01 Thread Ao Qi
On Mon, 1 Aug 2022 07:18:52 GMT, Alan Bateman wrote: >> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java`, >> `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`, >> `java/beans/XMLDecoder/8028054/TestConstructorFinder.java` and >> `java/b

Re: RFR: 8291508: Fix some tests with "requires vm.continuations" [v2]

2022-08-01 Thread Ao Qi
> `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java`, > `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`, > `java/beans/XMLDecoder/8028054/TestConstructorFinder.java` and > `java/beans/XMLDecoder/8028054/TestMethodFinder.java` are added or

Integrated: 8290497: some tests in com/sun/jdi fail on localized Windows platform

2022-08-01 Thread KIRIYAMA Takuya
On Tue, 19 Jul 2022 06:30:09 GMT, KIRIYAMA Takuya wrote: > Failed tests call java.lang.ProcessBuilder in direct, so not used command > options specified when jtreg command run. > To run non-localized tests, the locale options should be added in > ProcessBuilder. > > Could you review this fix,

Re: RFR: 8290497: some tests in com/sun/jdi fail on localized Windows platform [v2]

2022-08-01 Thread Serguei Spitsyn
On Mon, 1 Aug 2022 06:51:28 GMT, KIRIYAMA Takuya wrote: >> @tkiriyama Normally, two reviews are required in Serviceability area. > > @sspitsyn > Can I ask you again to integrate this fix? @tkiriyama I've sponsored your fix. It will be integrated now, I hope. - PR: https://git.openj

Re: RFR: 8291508: Fix some tests with "requires vm.continuations"

2022-08-01 Thread Alan Bateman
On Thu, 28 Jul 2022 16:11:12 GMT, Ao Qi wrote: > `vmTestbase/nsk/jvmti/GetThreadInfo/thrinfo001/TestDescription.java`, > `vmTestbase/nsk/jvmti/RedefineClasses/StressRedefineVirtual/StressRedefineVirtual.java`, > `java/beans/XMLDecoder/8028054/TestConstructorFinder.java` and > `java/beans/XMLDe