Re: RFR: 8290497: some tests in com/sun/jdi fail on localized Windows platform

On Tue, 19 Jul 2022 23:36:33 GMT, Serguei Spitsyn wrote: >> Failed tests call java.lang.ProcessBuilder in direct, so not used command >> options specified when jtreg command run. >> To run non-localized tests, the locale options should be added in >> ProcessBuilder. >> >> Could you review thi

Re: [jdk19] RFR: 8278274: Update nroff pages in JDK 19 before RC

On Mon, 18 Jul 2022 23:27:58 GMT, David Holmes wrote: >> src/java.base/share/man/keytool.1 line 456: >> >>> 454: \f[CB]PrivateKeyEntry\f[R] for the signer that already exists in the >>> 455: keystore. >>> 456: This option is used to sign the certificate with the signer?s private >> >> Not a pro

[jdk19] Integrated: 8278274: Update nroff pages in JDK 19 before RC

On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote: > Please review these changes to the nroff manpage files so that they match > their markdown sources that Oracle maintains. > > All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022 > if needed. Additionally: > > T

Re: RFR: 8290497: some tests in com/sun/jdi fail on localized Windows platform

On Tue, 19 Jul 2022 06:30:09 GMT, KIRIYAMA Takuya wrote: > Failed tests call java.lang.ProcessBuilder in direct, so not used command > options specified when jtreg command run. > To run non-localized tests, the locale options should be added in > ProcessBuilder. > > Could you review this fix,

RFR: 8290525: Move HeapRegion::_compaction_top to G1FullCollector

Hi all, can I have reviews for this change that moves `HeapRegion::_compaction_top` into the `G1FullCollector` class; my reasoning is that these values are transient temporary values only ever useful for the full collection algorithm, basically results of the application of the algorithm, tha

Re: RFR: 8286212: Cgroup v1 initialization causes NPE on some systems [v3]

On Wed, 18 May 2022 18:14:52 GMT, Severin Gehwolf wrote: >> Please review this change to the cgroup v1 subsystem which makes it more >> resilient on some of the stranger systems. Unfortunately, I wasn't able to >> re-create a similar system as the reporter. The idea of using the longest >> sub

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v18]

On Mon, 18 Jul 2022 23:12:00 GMT, Zhengyu Gu wrote: >> Currently, jdi only check and process class unloading event when it detects >> a new GC cycle. >> >> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting >> class events can overlap with GC finish event, that results,