Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-12 Thread Chris Plummer
On Tue, 12 Jul 2022 22:02:59 GMT, Zhengyu Gu wrote: >> Currently, jdi only check and process class unloading event when it detects >> a new GC cycle. >> >> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting >> class events can overlap with GC finish event, that results,

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-12 Thread Chris Plummer
On Tue, 12 Jul 2022 22:02:59 GMT, Zhengyu Gu wrote: >> Currently, jdi only check and process class unloading event when it detects >> a new GC cycle. >> >> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting >> class events can overlap with GC finish event, that results,

Re: [jdk19] Integrated: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all

2022-07-12 Thread Daniel D . Daugherty
On Tue, 12 Jul 2022 21:22:16 GMT, Naoto Sato wrote: >> A trivial fix to ProblemList >> vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java >> on linux-all. > > Marked as reviewed by naoto (Reviewer). @naotoj - Thanks for the fast code review. - PR: https:

[jdk19] Integrated: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all

2022-07-12 Thread Daniel D . Daugherty
On Tue, 12 Jul 2022 21:15:57 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java > on linux-all. This pull request has now been integrated. Changeset: ce36f6ea Author:Daniel D. Daugherty URL:

Re: [jdk19] Integrated: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all

2022-07-12 Thread Naoto Sato
On Tue, 12 Jul 2022 21:15:57 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList > vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java > on linux-all. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.org/jdk19/pull/137

[jdk19] Integrated: 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all

2022-07-12 Thread Daniel D . Daugherty
A trivial fix to ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all. - Commit messages: - 8290203: ProblemList vmTestbase/nsk/jvmti/scenarios/capability/CM03/cm03t001/TestDescription.java on linux-all Changes: https://git.openjd

Re: RFR: 8286030: Avoid JVM crash when containers share the same /tmp dir [v5]

2022-07-12 Thread Thomas Stuefe
On Tue, 12 Jul 2022 18:38:33 GMT, Ioi Lam wrote: >> src/hotspot/os/posix/perfMemory_posix.cpp line 807: >> >>> 805: // Hold the lock until here to prevent other JVMs from using this >>> file >>> 806: // while we are in the middle of deleting it. >>> 807: ::close(fd); >> >> I don't

Re: RFR: 8286030: Avoid JVM crash when containers share the same /tmp dir [v5]

2022-07-12 Thread Ioi Lam
On Mon, 11 Jul 2022 04:53:19 GMT, Thomas Stuefe wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed typo > > src/hotspot/os/posix/perfMemory_posix.cpp line 733: > >> 731: while ((entry = os::readdir(dirp)) != NULL)

Re: RFR: 8286030: Avoid JVM crash when containers share the same /tmp dir [v6]

2022-07-12 Thread Ioi Lam
> Some Kubernetes setups share the /tmp directory across multiple containers. > On rare occasions, the JVM may crash when it tries to write to > `/tmp/hsperfdata_/` when a process in a separate container decides > to do the same thing (because they happen to have the same namespaced pid). > > T

Re: RFR: 8286030: Avoid JVM crash when containers share the same /tmp dir [v6]

2022-07-12 Thread Thomas Stuefe
On Tue, 12 Jul 2022 19:12:01 GMT, Ioi Lam wrote: >> Some Kubernetes setups share the /tmp directory across multiple containers. >> On rare occasions, the JVM may crash when it tries to write to >> `/tmp/hsperfdata_/` when a process in a separate container >> decides to do the same thing (becau

[jdk19] Integrated: 8290201: ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in vthread mode

2022-07-12 Thread Daniel D . Daugherty
On Tue, 12 Jul 2022 20:43:33 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in > vthread mode. > > The copyright header is missing in this ProblemList file and there is a > duplicate entry. > I'm fixing those also as long as I'm h

Re: [jdk19] Integrated: 8290201: ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in vthread mode

2022-07-12 Thread Daniel D . Daugherty
On Tue, 12 Jul 2022 20:46:05 GMT, Brian Burkhalter wrote: >> A trivial fix to ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 >> in vthread mode. >> >> The copyright header is missing in this ProblemList file and there is a >> duplicate entry. >> I'm fixing those also as long as I'm

Re: [jdk19] Integrated: 8290201: ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in vthread mode

2022-07-12 Thread Brian Burkhalter
On Tue, 12 Jul 2022 20:43:33 GMT, Daniel D. Daugherty wrote: > A trivial fix to ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in > vthread mode. > > The copyright header is missing in this ProblemList file and there is a > duplicate entry. > I'm fixing those also as long as I'm h

[jdk19] Integrated: 8290201: ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in vthread mode

2022-07-12 Thread Daniel D . Daugherty
A trivial fix to ProblemList com/sun/jdi/InvokeHangTest.java on macosx-x64 in vthread mode. The copyright header is missing in this ProblemList file and there is a duplicate entry. I'm fixing those also as long as I'm here. - Commit messages: - 8290201: ProblemList com/sun/jdi/In

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v16]

2022-07-12 Thread Zhengyu Gu
On Tue, 12 Jul 2022 19:27:16 GMT, Chris Plummer wrote: > I haven't had a chance to review your change or to understand the sync > issues, but I did test them out and it seems to have gotten rid of the issue. > However, there is new assert that turned up once in 75 runs: > > ``` > # Internal E

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v17]

2022-07-12 Thread Zhengyu Gu
> Currently, jdi only check and process class unloading event when it detects a > new GC cycle. > > After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting > class events can overlap with GC finish event, that results, sometimes, it > only captures partial or even empty unload

Re: RFR: 8282730: LdapLoginModule throw NPE from logout method after login failure [v2]

2022-07-12 Thread Sean Mullan
On Tue, 12 Jul 2022 17:38:38 GMT, Weijun Wang wrote: >> Why isn't it sufficient to just call logout once per each login module? > > I meant to make the test more real. When there are multiple login modules, > the principals and credentials sets could be different. For example, the > `privateCre

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v16]

2022-07-12 Thread Chris Plummer
On Tue, 12 Jul 2022 17:02:54 GMT, Zhengyu Gu wrote: >> Currently, jdi only check and process class unloading event when it detects >> a new GC cycle. >> >> After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting >> class events can overlap with GC finish event, that results,

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v15]

2022-07-12 Thread Zhengyu Gu
On Tue, 12 Jul 2022 14:28:18 GMT, Zhengyu Gu wrote: > > It seems during test shutdown, ObjectFree events are being delivered after > > JVMTI events have been disabled: > > ``` > > nsk_jvmti_enableEvents(JVMTI_DISABLE, eventsCount, events, NULL); > > > > NSK_TRACE(jni->DeleteGlobalRef(de

Integrated: Merge jdk19

2022-07-12 Thread Jesper Wilhelmsson
On Tue, 12 Jul 2022 12:53:58 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 19 -> JDK 20 This pull request has now been integrated. Changeset: d9ca438d Author:Jesper Wilhelmsson URL: https://git.openjdk.org/jdk/commit/d9ca438d06166f153d11bb55c9ec672fc63c0e9e Stats: 1307 lines

Re: RFR: 8289711: Add container configuration data to mbeans [v2]

2022-07-12 Thread Alan Bateman
On Mon, 11 Jul 2022 09:30:59 GMT, Alan Bateman wrote: >> It's not clear that introducing this as a standard API is the right thing to >> do. Are you 100% confident that the concepts of "CPU quota", "CPU shares", >> "CPU period", "soft limit" etc. will last the test of time and that we don't >>

Re: RFR: 8289711: Add container configuration data to mbeans [v2]

2022-07-12 Thread Poonam Bajaj
On Mon, 11 Jul 2022 09:30:59 GMT, Alan Bateman wrote: >> It's not clear that introducing this as a standard API is the right thing to >> do. Are you 100% confident that the concepts of "CPU quota", "CPU shares", >> "CPU period", "soft limit" etc. will last the test of time and that we don't >>

Re: RFR: 8282730: LdapLoginModule throw NPE from logout method after login failure [v2]

2022-07-12 Thread Sean Mullan
On Mon, 11 Jul 2022 21:03:16 GMT, Weijun Wang wrote: >> test/jdk/javax/security/auth/login/modules/SafeLogout.java line 51: >> >>> 49: >>> 50: static void test(int pos) throws Exception { >>> 51: // Create random JAAS login config. >> >> I'm probably missing something obvious, but

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v15]

2022-07-12 Thread Zhengyu Gu
On Tue, 12 Jul 2022 06:31:39 GMT, Chris Plummer wrote: > It seems during test shutdown, ObjectFree events are being delivered after > JVMTI events have been disabled: > > ``` > nsk_jvmti_enableEvents(JVMTI_DISABLE, eventsCount, events, NULL); > > NSK_TRACE(jni->DeleteGlobalRef(debugeeC

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v15]

2022-07-12 Thread Zhengyu Gu
On Tue, 12 Jul 2022 06:31:39 GMT, Chris Plummer wrote: > post_object_free - PR: https://git.openjdk.org/jdk/pull/9168

RFR: Merge jdk19

2022-07-12 Thread Jesper Wilhelmsson
Forwardport JDK 19 -> JDK 20 - Commit messages: - Merge - 8289148: j.l.foreign.VaList::nextVarg call could throw IndexOutOfBoundsException or even crash the VM - 8289709: fatal error: stuck in JvmtiVTMSTransitionDisabler::disable_VTMS_transitions - 8287902: UnreadableRB case in

Re: [jdk19] RFR: 8289709: fatal error: stuck in JvmtiVTMSTransitionDisabler::disable_VTMS_transitions [v4]

2022-07-12 Thread Serguei Spitsyn
On Mon, 11 Jul 2022 22:41:02 GMT, Leonid Mesnik wrote: >> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> remove trailing white space > > test/hotspot/jtreg/serviceability/jvmti/events/FramePop/framepop02/libframepop02.cp

Re: RFR: 8256811: Delayed/missed jdwp class unloading events [v16]

2022-07-12 Thread Zhengyu Gu
> Currently, jdi only check and process class unloading event when it detects a > new GC cycle. > > After [JDK-8212879](https://bugs.openjdk.org/browse/JDK-8212879), posting > class events can overlap with GC finish event, that results, sometimes, it > only captures partial or even empty unload

Integrated: 8289768: Clean up unused code

2022-07-12 Thread Daniel Jeliński
On Tue, 5 Jul 2022 20:19:10 GMT, Daniel Jeliński wrote: > This patch removes many unused variables and one unused label reported by the > compilers when relevant warnings are enabled. > > The unused code was found by compiling after removing `unused` from the list > of disabled warnings for