arold
On 8/11/2016 1:57 PM, Daniel D. Daugherty wrote:
Greetings,
I'm quarantining a test that hung in the 2016-08-09 and
2016-08-10 JDK9-hs nightlies:
JDK-8163879 quarantine serviceability/sa/sadebugd/SADebugDTest.java
since it hangs intermittently
https://bugs.openjdk.ja
David,
Sorry I forgot to respond before I left for Santa Fe, NM...
More below...
On 8/8/16 5:57 PM, David Holmes wrote:
Hi Dan,
Thanks for the review.
On 9/08/2016 2:07 AM, Daniel D. Daugherty wrote:
On 8/4/16 8:28 PM, David Holmes wrote:
Hi Volker,
Thanks for looking at this.
On 5/08
On 8/23/16 6:17 AM, Harsha Wardhana B wrote:
Hi David,
You approach to waiter object is a neat little abstraction and I will
make it a point to use it in future fixes, if required.
revised webrev : http://cr.openjdk.java.net/~hb/8152589/webrev.02/
test/java/lang/management/ThreadMXBean/Lock
On 8/29/16 8:51 PM, David Holmes wrote:
On 30/08/2016 9:08 AM, Daniel D. Daugherty wrote:
On 8/23/16 6:17 AM, Harsha Wardhana B wrote:
Hi David,
You approach to waiter object is a neat little abstraction and I will
make it a point to use it in future fixes, if required.
revised webrev
On 8/31/16 2:20 AM, Harsha Wardhana B wrote:
Hello,
Please review new webrev incorporating nits form Daniel.
http://cr.openjdk.java.net/~hb/8152589/webrev.03/
Replies below.
-Harsha
On Wednesday 31 August 2016 01:47 AM, Daniel D. Daugherty wrote:
On 8/29/16 8:51 PM, David Holmes wrote
Dmitry,
This fix needs to be run through the entire JPDA test stack
before it is pushed. Don't know if we still have test definitions
to support that style of run anymore so it might be easier to
run it through the equivalent of a JDK9-hs nightly.
Dan
On 9/14/16 11:50 AM, Dmitry Samersoff wrote
On 9/15/16 8:18 AM, Severin Gehwolf wrote:
On Thu, 2016-09-15 at 08:15 -0600, Daniel D. Daugherty wrote:
Dmitry,
This fix needs to be run through the entire JPDA test stack
before it is pushed. Don't know if we still have test definitions
to support that style of run anymore so it mig
On 9/15/16 9:31 AM, harold seigel wrote:
Hi,
Please review this small fix for JDK-8160987. The JDWP InvokeStatic()
method was depending on the JNI function that it called to enforce the
requirement that the specified method must be a member of the
specified class or one of its super classes.
of the
JNI ToReflectedMethod() function. That would be relying on
the fact that HotSpot doesn't use the clazz parameter to
convert {clazz,jmethodID} => method_object.
Sorry... again...
Dan
Harold
On 9/15/2016 1:09 PM, Daniel D. Daugherty wrote:
On 9/15/16 9:31 AM, harold seigel w
7;m withdrawing this change because I found that it fails
a com/sun/jdi JTreg test involving static methods in interfaces.
Ouch! OK a test failure for this obscure corner is unexpected... :-(
Dan
Thanks, Harold
On 9/15/2016 3:37 PM, Daniel D. Daugherty wrote:
On 9/15/16 12:10 PM, harold se
r what
should happen and all we have to guide us is what hotspot does (eg
"virtual" invocations on non-virtual methods).
David
-
Thanks, Harold
On 9/15/2016 3:37 PM, Daniel D. Daugherty wrote:
On 9/15/16 12:10 PM, harold seigel wrote:
(Adding hotspot-runtime)
Hi Dan,
Thanks
Unfortunately it is a minefield I also have to wade
through for private interface methods. In many cases it is not
clear what should happen and all we have to guide us is what
hotspot does (eg "virtual" invocations on non-virtual methods).
David
-----
Thanks, Harold
On 9/15/2016
implemented in hotspot.
Unfortunately it is a minefield I also have to wade through for
private interface methods. In many cases it is not clear what
should happen and all we have to guide us is what hotspot does (eg
"virtual" invocations on non-virtual methods). David -
Thanks, Har
minefield when it comes to what
is required by the different specs and what is implemented in
hotspot. Unfortunately it is a minefield I also have to wade through
for private interface methods. In many cases it is not clear what
should happen and all we have to guide us is what hotspot does (eg
"vir
On 9/20/16 12:33 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8147943
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8147943-jvmti-header.hs1/
src/share/vm/prims/jvmti.xml
No comments.
src/share/vm/prims
On 9/20/16 11:07 PM, Chris Plummer wrote:
Hello,
Please help review the following:
https://bugs.openjdk.java.net/browse/JDK-8161225
http://cr.openjdk.java.net/~cjplummer/8161225/webrev.00/
hotspot/src/share/vm/prims/jvmtiEnter.xsl
L490: log_trace(jvmti)("[-] %s %s(%d)", func_na
On 10/10/16 7:55 PM, David Holmes wrote:
Turns out the only place changes were needed were in JDI.
Bug: https://bugs.openjdk.java.net/browse/JDK-8165827
webrev: http://cr.openjdk.java.net/~dholmes/8165827/webrev/
src/jdk.jdi/share/classes/com/sun/jdi/ObjectReference.java
No comments. (Tha
On 10/11/16 3:11 PM, David Holmes wrote:
Hi Dan,
Thanks for looking at this.
On 12/10/2016 3:30 AM, Daniel D. Daugherty wrote:
On 10/10/16 7:55 PM, David Holmes wrote:
Turns out the only place changes were needed were in JDI.
Bug: https://bugs.openjdk.java.net/browse/JDK-8165827
webrev
On 10/17/16 9:59 PM, David Holmes wrote:
Hi Lois, Dan, Serguei,
Went to push this today and realized I had left off the updated JNI
method lookup tests. As I said in the bug report JNI behaves as
expected, but there weren't any testcases so I added them:
http://cr.openjdk.java.net/~dholmes/8
I don't see the changes to unquarantine the affected tests.
Please see my comments in the bug about where the quarantines
were done.
Dan
On 10/19/16 3:40 AM, Dmitry Samersoff wrote:
Sharath,
Looks good for me.
(I'll sponsor the push)
-Dmitry
On 2016-10-19 12:20, Sharath Ballal wrote:
Hell
On 10/20/16 2:28 PM, Chris Plummer wrote:
Hello,
Please review the following:
http://cr.openjdk.java.net/~cjplummer/8166679/webrev.00/webrev.hotspot/
src/cpu/aarch64/vm/frame_aarch64.cpp
So we're in a "if (StubRoutines::returns_to_call_stub()" block
and the assumption was that a frame
> Ok. Let me know what you think now after a bit more explanation.
I'm good with it. Thumbs up!
Dan
On 10/21/16 1:13 PM, Chris Plummer wrote:
Hi Dan,
Thanks for the review. Comments inline below:
On 10/21/16 7:59 AM, Daniel D. Daugherty wrote:
On 10/20/16 2:28 PM, Chris Plumm
On 11/1/16 6:58 AM, serguei.spit...@oracle.com wrote:
Please, review this small fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8160024
JDK webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2016/hotspot/8160024-JDI-eval.jdk1/
src/jdk.jdi/share/classes/com/sun/tools/jdi/MethodImpl.java
On 12/8/16 1:59 PM, David Holmes wrote:
On 9/12/2016 12:21 AM, Lindenmaier, Goetz wrote:
Hi David,
thanks for looking at the change. New webrev:
http://cr.openjdk.java.net/~goetz/wr16/8170663-corlib_s11y/webrev.04/
src/java.base/share/native/libjli/java.c
As far as I can see the existing cod
On 1/17/17 6:03 PM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8172261
webrev: http://cr.openjdk.java.net/~dholmes/8172261/webrev/
src/share/vm/prims/jvmti.xml
No comments.
Thumbs up.
Dan
This is a simple relaxation of the spec in regards to the new "early
VM
Greetings,
I have a very small work around for a JVM/TI event posting bug:
JDK-8173693 disable post_class_unload() for non JavaThread initiators
https://bugs.openjdk.java.net/browse/JDK-8173693
This work around disables the JVM/TI post_class_unload() function
when the thread requesting
Serguei,
Thanks for the fast review!
Dan
On 1/31/17 11:28 AM, serguei.spit...@oracle.com wrote:
Dan,
It looks good.
Thank you for the work around.
Thanks,
Serguei
On 1/31/17 09:18, Daniel D. Daugherty wrote:
Greetings,
I have a very small work around for a JVM/TI event posting bug
Jerry,
Thanks for the fast review!
Dan
On 1/31/17 11:36 AM, Gerald Thornbrugh wrote:
Hi Dan,
Your changes look good.
Thanks,
Jerry
On Jan 31, 2017, at 10:18 AM, Daniel D. Daugherty
wrote:
Greetings,
I have a very small work around for a JVM/TI event posting bug:
JDK-8173693
Thumbs up!
Dan
On 2/12/17 5:19 PM, David Holmes wrote:
Planning to push under trivial rules so just need one Reviewer please.
Bug: https://bugs.openjdk.java.net/browse/JDK-8174798
Stumbled on this by accident. This test should no longer be ignored,
but somehow the removal of the @ignore wa
On 2/13/17 12:33 AM, serguei.spit...@oracle.com wrote:
Please, review a JDK 9 fix for the bug:
https://bugs.openjdk.java.net/browse/JDK-8172969
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8172969-jvmti-spec.hs1/
src/share/vm/prims/jvmti.xml
No comments.
Thumbs up
On 3/1/17 8:49 PM, serguei.spit...@oracle.com wrote:
Please, review the JDK 10 fix for:
https://bugs.openjdk.java.net/browse/JDK-8134103
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8134103-jdi-wrong-phase.1/
src/jdk.jdwp.agent/share/native/libjdwp/debugLoop.c
old
va reproduce
the problem?
Dan
Thanks,
Serguei
On 3/2/17 11:21, serguei.spit...@oracle.com wrote:
Dan,
Thank you for reviewing!
I was waiting for your comments.
On 3/2/17 06:59, Daniel D. Daugherty wrote:
On 3/1/17 8:49 PM, serguei.spit...@oracle.com wrote:
Please, review the JDK 10
On 3/2/17 3:19 PM, serguei.spit...@oracle.com wrote:
On 3/2/17 14:06, Daniel D. Daugherty wrote:
On 3/2/17 2:24 PM, serguei.spit...@oracle.com wrote:
The updated webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8134103-jdi-wrong-phase.2/
The change at L152-L153 has been
I hereby nominate Serguei Spitsyn to Serviceability Group Lead [1].
Serguei is a Reviewer in the jdk10 and jdk9 projects, a Committer in
the jdk8u project, a member of the OpenJDK Serviceability Group, and
has so far committed > 70 changesets spread across multiple repos
in JDK9 alone.
Serguei i
Vote: yes
Dan
On 4/4/17 7:46 AM, Daniel D. Daugherty wrote:
I hereby nominate Serguei Spitsyn to Serviceability Group Lead [1].
Serguei is a Reviewer in the jdk10 and jdk9 projects, a Committer in
the jdk8u project, a member of the OpenJDK Serviceability Group, and
has so far committed >
The vote for Serguei Spitsyn [1] is now closed.
Yes: 5
No: 0
Abstain: 0
According to the Bylaws definition of Simple Majority[2], this is
sufficient to approve the new Group Lead. The OpenJDK Lead will
ask the Governing Board to ratify this nomination.
Daniel Daugherty
[1]
http://mail.openjdk
Resending... this time I'm including regist...@openjdk.java.net.
Dan
On 4/19/17 10:13 AM, Daniel D. Daugherty wrote:
The vote for Serguei Spitsyn [1] is now closed.
Yes: 5
No: 0
Abstain: 0
According to the Bylaws definition of Simple Majority[2], this is
sufficient to approve the new
> New webrev version is:
>
http://cr.openjdk.java.net/~sspitsyn/webrevs/2017/hotspot/8172970-start-phase.3/
make/test/JtregNative.gmk
No comments.
test/serviceability/jvmti/StartPhase/AllowedFunctions/AllowedFunctions.java
L27: * @summary Verify the functions that allowed to operate i
Adding Jonathan Gibbons for the JavaTest/JTREG options part...
Dan
On 8/23/13 5:26 AM, Staffan Larsen wrote:
The JDI tests have some quite arcane way of sending command line options to the
debuggee. Options have to be put into a file called @debuggeeVMOptions before
invoking jtreg. This was
On 8/26/13 5:27 AM, Staffan Larsen wrote:
On 26 aug 2013, at 13:03, David Holmes wrote:
If your test-jdk and compile-jdk are the same then you will have trouble
telling them apart :)
That aside I would have thought it quite reasonable for the debugger and
debuggee VMs to need different opti
MOptions solution. A
little tricker to parse in shell based tests, though.
/Staffan
On 26 aug 2013, at 15:48, Daniel D. Daugherty
wrote:
On 8/26/13 5:27 AM, Staffan Larsen wrote:
On 26 aug 2013, at 13:03, David Holmes wrote:
If your test-jdk and compile-jdk are the same then you will have t
On 9/5/13 9:33 AM, Coleen Phillimore wrote:
Summary: Need to refetch the methods array from InstanceKlass after
safepoint.
open webrev at http://cr.openjdk.java.net/~coleenp/8022887/
The "frames" links are broken in this webrev. I had to
write down the changed line numbers for jvm.cpp and the
Coleen
On 9/5/2013 12:23 PM, Daniel D. Daugherty wrote:
On 9/5/13 9:33 AM, Coleen Phillimore wrote:
Summary: Need to refetch the methods array from InstanceKlass after
safepoint.
open webrev at http://cr.openjdk.java.net/~coleenp/8022887/
The "frames" links are broken in this webrev
> http://cr.openjdk.java.net/~dcubed/for_gthornbr/6986195-webrev/
src/os/linux/vm/os_linux.cpp
No comments.
Thumbs up.
Just for the record, the internal review team was:
dcubed
dsamersoff
coleenp
iklam
Dan
On 9/12/13 2:00 PM, Daniel D. Daugherty wrote:
Greetings,
I
Greetings,
I am sponsoring the following code review for Jerry Thornbrugh.
Since this code review request is going to two aliases, please make
sure you include BOTH aliases in your replies.
Dan
OpenJDK bug:
6986195 correctly identify Ubuntu as the operating system in crash
rep
Greetings,
I have some new diagnostic code that I would like to add to the system
that was developed during my hunt for this bug:
8019835 Strings interned in different threads equal but does not ==
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8019835
https://bugs.openjdk.java.n
Thanks for quick re-review!
Dan
On 9/16/13 11:43 AM, serguei.spit...@oracle.com wrote:
Looks nice.
Thanks,
Serguei
On 9/16/13 10:08 AM, Daniel D. Daugherty wrote:
Greetings,
I have some new diagnostic code that I would like to add to the system
that was developed during my hunt for this
On 9/16/13 11:10 AM, Gerald Thornbrugh wrote:
Hi Omair,
Hi Gerald,
On 09/16/2013 12:52 PM, Gerald Thornbrugh wrote:
Sorry about the delay of my response.
No problem :)
I chose to place the /etc/SuSE-release file in front of the
/etc/os-release file because the
SuSE-release file was more cle
Thanks for re-review!
Dan
On 9/16/13 4:17 PM, Ron Durbin wrote:
Dan it looks good,
Thx
Ron
-Original Message-
From: Daniel D. Daugherty
Sent: Monday, September 16, 2013 11:48 AM
To: Serguei Spitsyn
Cc: serviceability-dev@openjdk.java.net; hotspot-runtime-...@openjdk.java.net
ew webrev from you.
Thanks,
Serguei
On 9/5/13 9:35 AM, Coleen Phillimore wrote:
Dan,
Thank you for looking at this so quickly. You are right, we are
not only getting public methods, whose number cannot change right
now with redefine classes.
I have to rework this change.
Thanks,
Coleen
On 9
On 9/18/13 4:13 PM, Coleen Phillimore wrote:
Thank you Dan for the really quick review!
No problem. I figured you wanted a quick review with JavaOne approaching
and all...
On 9/18/2013 5:26 PM, Daniel D. Daugherty wrote:
On 9/18/13 1:37 PM, Coleen Phillimore wrote:
Hi, The new webrev
On 9/19/13 7:53 AM, Staffan Larsen wrote:
All,
Please review this fix for a JDI test. The problem and fix is described in the
bug report.
bug: https://bugs.openjdk.java.net/browse/JDK-8024985
webrev: http://cr.openjdk.java.net/~sla/8024985/webrev.00/
Thumbs up.
test/com/sun/jdi/TestScaffold
test/com/sun/jdi/RepStep.java
No comments (7 excludes here).
test/com/sun/jdi/TestScaffold.java
No comments (7 excludes here).
Dan
On 9/19/13 12:17 PM, Staffan Larsen wrote:
On 19 sep 2013, at 17:49, Daniel D. Daugherty
wrote:
On 9/19/13 7:53 AM, Staffan Larsen wrote:
All,
Please review
On 9/20/13 3:49 AM, Staffan Larsen wrote:
Please review this change to avoid a buffer overflow in npt/utf.c.
webrev: http://cr.openjdk.java.net/~sla/7200277/webrev.00/
Thumbs up.
src/share/npt/utf.c
No comments
Dan
bug: https://bugs.openjdk.java.net/browse/JDK-7200277
Thanks,
/Staffan
Greetings,
I have the initial support for Full Debug Symbols (FDS) on MacOS X done
and ready for review:
7165611 implement Full Debug Symbols on MacOS X hotspot
https://bugs.openjdk.java.net/browse/JDK-7165611
Here is the JDK8/HSX-25 webrev URL:
OpenJDK:
http://cr.openjdk.java.net/~dc
ic to know when
to copy/import .diz files from the various repo builds into the image
being constructed.
Dan
/Erik
On 2013-09-21 05:36, Daniel D. Daugherty wrote:
Greetings,
I have the initial support for Full Debug Symbols (FDS) on MacOS X done
and ready for review:
7165611 implement
_strip)
so they have to be indented by a tab. Very ugly, but necessary.
Dan
/Staffan
On 21 sep 2013, at 05:36, Daniel D. Daugherty
wrote:
Greetings,
I have the initial support for Full Debug Symbols (FDS) on MacOS X done
and ready for review:
7165611 implement Fu
Thanks,
Vadim
On 30.09.2013 17:44, Daniel D. Daugherty wrote:
On 9/30/13 7:13 AM, Staffan Larsen wrote:
First: thanks for doing this work - it will make debugging on os x
so much easier!
That's the plan...
I'm not done with the review, but here are a couple of comments so
Thanks (again). You previously posted a review for the OpenJDK side
on 2013.09.23... :-)
Dan
On 10/1/13 2:42 AM, Erik Joelsson wrote:
I have looked at the build changes in the root and jdk repos and they
look OK.
/Erik
On 2013-09-21 05:36, Daniel D. Daugherty wrote:
Greetings,
I have the
Tim,
Thanks for the review.
Dan
On 10/1/13 9:30 AM, Tim Bell wrote:
Open changes look good to me as well.
Tim
On 10/ 1/13 06:48 AM, Daniel D. Daugherty wrote:
Thanks (again). You previously posted a review for the OpenJDK side
on 2013.09.23... :-)
Dan
On 10/1/13 2:42 AM, Erik Joelsson
On 9/30/13 12:00 PM, Staffan Larsen wrote:
On 30 sep 2013, at 15:44, Daniel D. Daugherty
wrote:
I'm presuming that you're trying with a forest that includes
closed repos. If so, then you'll need the jdk/make/closed change
in order for the build to work.
Yes, I was running wi
efined for everything without it seeming to cause a problem.
So why do we need to change it and what impact will it have?
David
-
On 21/09/2013 1:36 PM, Daniel D. Daugherty wrote:
Greetings,
I have the initial support for Full Debug Symbols (FDS) on MacOS X done
and ready for review:
Ron,
Thanks for the review.
Dan
On 10/2/13 8:44 AM, Ron Durbin wrote:
Dan
You have my thumbs up changes look good
-Original Message-
On 21/09/2013 1:36 PM, Daniel D. Daugherty wrote:
Greetings,
I have the initial support for Full Debug Symbols (FDS) on MacOS X done
and ready
> http://cr.openjdk.java.net/~coleenp/8025238/
src/share/vm/classfile/javaClasses.cpp
1804 if (method == NULL) {
1805 // leave name and fileName null
1806 java_lang_StackTraceElement::set_lineNumber(element(), -1);
Is it possible to set the name and fileName to something
> open webrev at http://cr.openjdk.java.net/~coleenp/8025238_jdk
test/java/lang/instrument/RedefineMethodInBacktrace.sh
No comments.
test/java/lang/instrument/RedefineMethodInBacktraceApp.java
line 78: t.setDaemon(true);
Why make the target thread a daemon? Wouldn't it be
On 10/3/13 4:56 PM, Coleen Phillmore wrote:
Thanks Dan -
On 10/3/2013 4:07 PM, Daniel D. Daugherty wrote:
> http://cr.openjdk.java.net/~coleenp/8025238/
src/share/vm/classfile/javaClasses.cpp
1804 if (method == NULL) {
1805 // leave name and fileName null
1
o we need to change it and what impact will it have?
It just seemed wrong to define something that should never be used
on non-Solaris platforms. My control build of the entire forest
didn't have an issue with this change so I'm planning to keep it.
Dan
David
-
On 21/09/2013
Replies also inline...
On 10/9/13 6:02 AM, David Holmes wrote:
inline ...
On 9/10/2013 8:59 AM, Daniel D. Daugherty wrote:
On 10/1/13 8:52 PM, David Holmes wrote:
- hotspot/make/Makefile
+ $(EXPORT_CLIENT_DIR)/%.dSYM: $(MINIMAL1_BUILD_DIR)/%.dSYM
EXPORT_CLIENT_DIR should be
On 10/9/13 9:03 AM, Daniel D. Daugherty wrote:
Replies also inline...
On 10/9/13 6:02 AM, David Holmes wrote:
inline ...
On 9/10/2013 8:59 AM, Daniel D. Daugherty wrote:
On 10/1/13 8:52 PM, David Holmes wrote:
- make/bsd/makefiles/universal.gmk
I did not understand the additional logic
On 10/8/13 12:27 PM, Coleen Phillimore wrote:
Summary: Add missing cases.
I verified this with the test for
https://bugs.openjdk.java.net/browse/JDK-8022701 but don't want to
copy the test into with modifications the hotspot repository, still
working on refactoring the test for the JDK reposi
Thanks for confirmation.
Dan
On 10/10/13 3:09 AM, David Holmes wrote:
I'm fine with not adding untestable minimal VM support.
Thanks,
David
On 10/10/2013 1:03 AM, Daniel D. Daugherty wrote:
Replies also inline...
On 10/9/13 6:02 AM, David Holmes wrote:
inline ...
On 9/10/2013 8:
[universal_debug] Error 2
...
Another comment: There are some makefile logic for BSD, non-darwin platforms.
Have you had a chance to test this logic? (hotspot/make/bsd/makefiles/vm.make)
Nit: hotspot/make/bsd/makefiles/vm.make: L345, L356: wrong indentation.
/Staffan
On 21 sep 2013, at 05:36,
Greetings,
I'm ready for code review round 1 of the FDS on MacOS X hotspot changes.
Below is the original code review round 0 invite (slightly edited for
clarity). Working on FDS is like pulling a thread on a sweater... so
there are four additional changed files along with more changes to
many of
ought would be needed.
Hmm second comment - I don't see a .m4 file change that corresponds to
the DSYMUTIL configure change ??
Yikes! I'll check into that shortly. Not sure what happened here.
Dan
Thanks,
David
On 12/10/2013 6:27 AM, Daniel D. Daugherty wrote:
Greetings,
I'm r
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change that corresponds
to the DSYMUTIL configure change ??
Yikes! I'll check into that shortly. Not sure what happened here.
I somehow missed/
On 10/15/13 12:05 AM, David Holmes wrote:
On 15/10/2013 1:52 AM, Daniel D. Daugherty wrote:
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change that corresponds
to the DSYMUTIL configure change ??
On 10/15/13 12:07 AM, David Holmes wrote:
On 15/10/2013 1:18 AM, Daniel D. Daugherty wrote:
Thanks for the re-review!
On 10/13/13 7:57 PM, David Holmes wrote:
Hi Dan,
Only further comment I have, and it may well be deferred for future
work, is that we should be able to abstract away the
fan
On 11 okt 2013, at 22:27, Daniel D. Daugherty
wrote:
Greetings,
I'm ready for code review round 1 of the FDS on MacOS X hotspot changes.
Below is the original code review round 0 invite (slightly edited for
clarity). Working on FDS is like pulling a thread on a sweater... so
Thanks!
Dan
On 10/15/13 3:33 AM, Erik Joelsson wrote:
Daniel,
Looks good to me.
/Erik
On 2013-10-14 17:52, Daniel D. Daugherty wrote:
On 10/14/13 9:18 AM, Daniel D. Daugherty wrote:
On 10/13/13 7:57 PM, David Holmes wrote:
Hmm second comment - I don't see a .m4 file change
On 10/15/13 6:21 AM, Magnus Ihse Bursie wrote:
On 2013-10-11 22:27, Daniel D. Daugherty wrote:
Greetings,
I'm ready for code review round 1 of the FDS on MacOS X hotspot changes.
Below is the original code review round 0 invite (slightly edited for
clarity). Working on FDS is like pull
On 10/15/13 8:50 AM, Daniel D. Daugherty wrote:
On 10/15/13 6:21 AM, Magnus Ihse Bursie wrote:
On 2013-10-11 22:27, Daniel D. Daugherty wrote:
Greetings,
I'm ready for code review round 1 of the FDS on MacOS X hotspot
changes.
Below is the original code review round 0 invite (sli
> webrev: http://cr.openjdk.java.net/~sla/8026789/webrev.00/
test/ProblemList.txt
Interesting. The tests are on the list via 8023201, but you're
tweaking the tests via 8026789. I'm guessing you don't want to
say (yet) that this fix resolved the 'leak' in 8023201.
test/java/lang/instr
Greetings,
I have some MacOS X Full Debug Symbols whitespace/indent fixes.
Here is the JDK8/HSX-25 webrev URL:
OpenJDK:
http://cr.openjdk.java.net/~dcubed/fds_revamp/8027117-webrev/0-jdk8/
Internal:
http://javaweb.us.oracle.com/~ddaugher/fds_revamp/8027117-webrev/0-jdk8/
Because these are wh
Jerry,
Thanks for the fast review!
On 10/23/13 2:41 PM, Gerald Thornbrugh wrote:
Hi Dan,
Your changes look good but I have a question.
On source files that do not have an Oracle copyright like generated-configure.sh
is the correct method to leave the copyright as it is?
generated-configure
Adding back the other two aliases...
Dan
On 10/23/13 2:50 PM, Daniel D. Daugherty wrote:
Harold,
Thanks for the fast review!
Dan
On 10/23/13 2:36 PM, harold seigel wrote:
Hi Dan,
The whitespace/indents look good.
Harold
On 10/23/2013 4:26 PM, Daniel D. Daugherty wrote:
Greetings,
I
Adding back the other two aliases...
Coleen,
Thanks for the fast review!
Dan
On 10/23/13 2:50 PM, Coleen Phillimore wrote:
Looks fine.
Coleen
On 10/23/2013 4:26 PM, Daniel D. Daugherty wrote:
Greetings,
I have some MacOS X Full Debug Symbols whitespace/indent fixes.
Here is the JDK8/HSX
Erik,
Thanks for the review!
Dan
On 10/24/13 2:05 AM, Erik Joelsson wrote:
Daniel,
Looks good to me.
/Erik
On 2013-10-23 22:26, Daniel D. Daugherty wrote:
Greetings,
I have some MacOS X Full Debug Symbols whitespace/indent fixes.
Here is the JDK8/HSX-25 webrev URL:
OpenJDK:
http
On 10/24/13 2:12 AM, Magnus Ihse Bursie wrote:
On 2013-10-23 22:26, Daniel D. Daugherty wrote:
Greetings,
I have some MacOS X Full Debug Symbols whitespace/indent fixes.
Here is the JDK8/HSX-25 webrev URL:
OpenJDK:
http://cr.openjdk.java.net/~dcubed/fds_revamp/8027117-webrev/0-jdk8/
Internal
The current thread number is part of the jdb prompt.
So something like this:
$ jdb Hello
Initializing jdb ...
> stop in Hello.main
Deferring breakpoint Hello.main.
It will be set after the class is loaded.
> run
run Hello
Set uncaught java.lang.Throwable
Set deferred uncaught java.lang.Throwable
gnal Dispatcher[17a]".
/Staffan
On 30 okt 2013, at 13:10, Daniel D. Daugherty
wrote:
The current thread number is part of the jdb prompt.
So something like this:
$ jdb Hello
Initializing jdb ...
stop in Hello.main
Deferring breakpoint Hello.main.
It will be set after the class is loade
test/com/sun/jdi/ShellScaffold.sh
line 1048: echo "apa $res"
Debug output?
Thumbs up.
Dan
Thanks,
/Staffan
On 31 okt 2013, at 13:39, Daniel D. Daugherty
wrote:
I stand corrected. Only the thread name is in the prompt.
I think I've been away from 'jdb&#x
> Could you please help us with this? Is it a legal scenario to
redefine shared classes?
Sorry for the delay in responding. I was on vacation.
Yes, redefining a shared class is supported via either JVM/TI or
via java.lang.instrument. There should be existing tests that
verify this behavior, but
57, Daniel D. Daugherty
mailto:daniel.daughe...@oracle.com>> wrote:
> Could you please help us with this? Is it a legal scenario to
redefine shared classes?
Sorry for the delay in responding. I was on vacation.
Yes, redefining a shared class is supported via either JVM/TI or
via j
On 12/19/13 1:01 AM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-8030027
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2013/hotspot/8030027-JVMTI-HS101.1/
src/share/vm/prims/jvmtiEnvThreadState.cpp
No comments.
Th
Greetings,
I have a fix ready for the following bug:
8028073 race condition in ObjectMonitor implementation causing
deadlocks
https://bugs.openjdk.java.net/browse/JDK-8028073
On the surface, this is a very simple fix that relocates a few lines of
code, relocates and rewrites the comme
Adding Dave Dice to this thread...
On 2/3/14 5:10 AM, David Holmes wrote:
Hi Dan,
On 2/02/2014 4:38 AM, Daniel D. Daugherty wrote:
Greetings,
I have a fix ready for the following bug:
8028073 race condition in ObjectMonitor implementation causing
deadlocks
https
On 1/31/14 7:58 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-6471769
Open webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2014/hotspot/6471769-JVMTI-FRAME/
src/share/vm/prims/jvmtiEnv.cpp
Thumbs up on the code change.
Thanks for the review Serguei!
Dan
On 2/3/14 11:36 AM, serguei.spit...@oracle.com wrote:
Hi Dan,
It looks good to me.
Your work on this issue is outstanding.
I know what it took to resolve this one.
Great job!
Thanks,
Serguei
On 2/1/14 10:38 AM, Daniel D. Daugherty wrote:
Greetings,
I
On 2/3/14 12:12 PM, serguei.spit...@oracle.com wrote:
On 2/3/14 4:16 AM, David Holmes wrote:
Hi Serguei,
On 1/02/2014 12:58 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-6471769
Open webrev:
http://cr.openjdk.java.net/~sspitsyn
On 2/3/14 1:13 PM, serguei.spit...@oracle.com wrote:
Dan,
Thank you for reviewing!
Some comments are below.
On 2/3/14 7:51 AM, Daniel D. Daugherty wrote:
On 1/31/14 7:58 PM, serguei.spit...@oracle.com wrote:
Please, review the fix for:
https://bugs.openjdk.java.net/browse/JDK-6471769
601 - 700 of 1805 matches
Mail list logo
