Sorry for the delay in reviewing this one... I've been playing whack-a-mole
with Robbin's MoCrazy test and my AsyncMonitorDeflation bits...
On 9/24/19 1:09 AM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8231289
webrev: http://cr.openjdk.java.net/~dholmes/8231289/webrev/
On 10/3/19 6:13 AM, David Holmes wrote:
Hi Dan,
On 3/10/2019 3:20 am, Daniel D. Daugherty wrote:
Sorry for the delay in reviewing this one... I've been playing
whack-a-mole
with Robbin's MoCrazy test and my AsyncMonitorDeflation bits...
No problem - your contribution mad
On 10/3/19 7:35 PM, serguei.spit...@oracle.com wrote:
On 10/3/19 3:33 PM, David Holmes wrote:
On 4/10/2019 3:15 am, serguei.spit...@oracle.com wrote:
On 10/3/19 03:13, David Holmes wrote:
Hi Dan,
On 3/10/2019 3:20 am, Daniel D. Daugherty wrote:
Sorry for the delay in reviewing this one
On 10/3/19 9:55 PM, David Holmes wrote:
On 4/10/2019 10:01 am, Daniel D. Daugherty wrote:
On 10/3/19 7:35 PM, serguei.spit...@oracle.com wrote:
If I remember correctly it is a scenario where this issue also
comes to the picture:
https://bugs.openjdk.java.net/browse/JDK-8033399
I do not
On 10/3/19 11:58 PM, David Holmes wrote:
Okay, to allow for me to make forward progress here I've decided to
follow the "principle of least brokenness" ;-)
Recap: Because of JVMTI event callbacks it is possible for a thread to
set its current pending monitor as a JvmtiRawMonitor when it was
a
On 10/7/19 9:58 PM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8231737
webrev: http://cr.openjdk.java.net/~dholmes/8231737/webrev/
Thanks for cleaning up this code!!
src/hotspot/share/prims/jvmtiRawMonitor.hpp
L58: QNode* volatile _entry_list; // Threads bloc
Thumbs up!
Dan
On 10/1/19 4:57 PM, Daniil Titov wrote:
Hello,
Please review a new version of the change [1] that fixes the problem with the
debugger not stopping in the low memory notification code. The fix moves the
send notifications task from
not visible ServiceThread to a new visible
I think Kim has already been clear that he is not a fan of option A:
I'm not a fan of replacing correct and idiomatic uses of strncpy with
strcpy or memcpy. I've suggested in the past that we should turn off
this warning while it is so buggy.
Dan
On 10/10/19 10:02 PM, Yasumasa Suenaga wrot
On 10/29/19 3:42 AM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8229516
CSR: https://bugs.openjdk.java.net/browse/JDK-8232676 (already approved)
webrev: http://cr.openjdk.java.net/~dholmes/8229516/webrev/
make/hotspot/symbols/symbols-unix
No comments.
src/hotspot/os/
Since this review contains build changes, I've added build-dev@...
Dan
On 11/1/19 4:56 AM, Yasumasa Suenaga wrote:
(Changed subject to review request)
Hi,
I converted LinuxDebuggerLocal.c to C++ code, and it works fine on
submit repo.
(mach5-one-ysuenaga-JDK-8233285-1-20191101-0746-6336009
Moving this thread over to serviceability-dev@... since this question is
about Serviceability Agent tests... Bcc'ing hotspot-dev@... so folks know
that the thread moved...
On 11/4/19 9:49 AM, Jaikiran Pai wrote:
On 04/11/19 8:11 PM, Jaikiran Pai wrote:
...
Looking at the testcase itself, I see
On 11/11/19 11:52 PM, David Holmes wrote:
webrev: http://cr.openjdk.java.net/~dholmes/8233549/webrev/
src/hotspot/os/posix/os_posix.cpp
L2078: // Can't access interrupt state now we are
_thread_blocked. If we've been
L2079: // interrupted since we checked above then _counter will
On 11/12/19 5:50 PM, David Holmes wrote:
Hi Dan,
Thanks for taking a look so quickly!
Your welcome! I figured you would prefer to get this one out of
the way quickly.
On 13/11/2019 3:18 am, Daniel D. Daugherty wrote:
On 11/11/19 11:52 PM, David Holmes wrote:
webrev: http
Webrev updated in place.
Thumbs up.
Dan
On 11/14/19 5:21 PM, David Holmes wrote:
Hi Serguei,
Thanks for taking a look.
On 15/11/2019 4:04 am, serguei.spit...@oracle.com wrote:
Hi David,
It looks good to me.
A couple of nits below.
http://cr.openjdk.java.net/~dholmes/8233549/webrev/src/
On 11/15/19 7:48 AM, coleen.phillim...@oracle.com wrote:
I meant to add myself to the To list.
On 11/15/19 7:39 AM, coleen.phillim...@oracle.com wrote:
On 11/14/19 9:07 PM, Chris Plummer wrote:
Hi Coleen,
Is it ok to end up missing some CompiledMethodLoad events? The spec
says:
"Sent whe
Hi David,
On 11/17/19 9:30 PM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8215355
webrev: http://cr.openjdk.java.net/~dholmes/8215355/webrev/
src/hotspot/share/runtime/thread.hpp
Nice catch!
src/hotspot/share/runtime/thread.cpp
Nice catch!
Not your issue,
Hi Coleen,
Sorry for the delay in getting back to this re-review.
On 11/21/19 9:12 AM, coleen.phillim...@oracle.com wrote:
Please review a new version of this change that keeps the nmethod from
being unloaded, after it is added to the deferred event queue:
http://cr.openjdk.java.net/~colee
...@oracle.com wrote:
Dan, Thank you for reviewing this!
On 11/22/19 12:49 PM, Daniel D. Daugherty wrote:
Hi Coleen,
Sorry for the delay in getting back to this re-review.
On 11/21/19 9:12 AM, coleen.phillim...@oracle.com wrote:
Please review a new version of this change that keeps the nmethod
On 12/4/19 8:00 AM, coleen.phillim...@oracle.com wrote:
Summary: Remove use of GC.class_stats in testing and failure analysis
(plan to deprecate)
See bug for more details.
open webrev at http://cr.openjdk.java.net/~coleenp/2019/8234355.01/webrev
test/failure_handler/src/share/conf/common.pro
Generally speaking, JVM/TI related things should be in JvmtiThreadState
instead of directly in the Thread class. That way the extra space is only
consumed when JVM/TI is in use and only when a Thread does something that
requires a JvmtiThreadState to be created.
Please reconsider moving _jvmti_ev
Do you plan to make JVM/TI spec changes also?
Dan
On 12/5/19 9:28 AM, Harold Seigel wrote:
Hi,
Please review this trivial change to add documentation about the
Record attribute to the JDWP, JDI, and Instrumentation specs.
The changed .html pages (best viewed as 'raw') are included in the
Thanks for clarifying.
Dan
On 12/5/19 1:30 PM, Harold Seigel wrote:
The JVM/TI change for Record attrbute was in the big Records push. I
missed the other three until Serguei pointed it out.
Thanks, Harold
On 12/5/2019 11:15 AM, Daniel D. Daugherty wrote:
Do you plan to make JVM/TI spec
Thumbs up. This is a trivial change.
Dan
On 12/5/19 3:29 PM, Alex Menkov wrote:
Hi all,
Recently JdwpListenTest.java and JdwpAttachTest.java have started to
fail on Windows2016 for unclear (yet) reason:
https://bugs.openjdk.java.net/browse/JDK-8234935
Until the issue is resolved need to pro
On 12/6/19 6:26 PM, serguei.spit...@oracle.com wrote:
On 12/6/19 13:52, Chris Plummer wrote:
On 12/6/19 1:18 PM, serguei.spit...@oracle.com wrote:
On 12/6/19 11:07, Chris Plummer wrote:
On 12/5/19 6:45 PM, David Holmes wrote:
Hi Serguei,
On 6/12/2019 11:31 am, serguei.spit...@oracle.com wrot
src/hotspot/share/gc/shared/generationSpec.hpp
No comments.
test/hotspot/jtreg/serviceability/tmtools/jstat/utils/JstatGcCapacityResults.java
No comments.
Thumbs up.
Dan
On 12/12/19 10:23 AM, Stefan Karlsson wrote:
In the interest to get this integrated before the RDP cut-off I'm
goi
On 12/13/19 2:35 PM, Harold Seigel wrote:
Hi,
Please review this trivial fix to prevent java/lang/instrument/...
TestRecordAttr.java and TestRecordAttrGenericSig.java from failing.
The fix replaces hard-wired JDK version 14 with mechanisms that get
the latest JDK version.
Open Webrev:
htt
Thumbs up and I agree that this is a trivial fix.
Dan
On 1/24/20 9:01 AM, coleen.phillim...@oracle.com wrote:
Fix cut/paste error and reran the test, which passes.
open webrev at http://cr.openjdk.java.net/~coleenp/2020/8237501.01/webrev
bug link https://bugs.openjdk.java.net/browse/JDK-82375
Hi Tony!
Thanks for filing:
JDK-8239497 SEGV in EdgeUtils::field_name_symbol(Edge const&)
https://bugs.openjdk.java.net/browse/JDK-8239497
I've added hotspot-jfr-dev@... alias to this thread, but the JFR
folks usually lurk on the Serviceability alias also.
Dan
On 2/19/20 1:33 PM, To
Greetings,
I'm trying to reduce the noise in the jdk/jdk CI. I'm ProblemListing
com/sun/jdi/InvokeHangTest.java on Linux due to this bug:
JDK-8218463 com/sun/jdi/InvokeHangTest.java fail
"java.lang.Exception: InvokeHangTest: failed; bkpts = 64 "
https://bugs.openjdk.java.net/browse/JDK
Thanks for the fast review!
Dan
On 2/26/20 5:52 PM, Mikael Vidstedt wrote:
Looks good, thanks for doing it!
Cheers,
Mikael
On Feb 26, 2020, at 2:49 PM, Daniel D. Daugherty
wrote:
Greetings,
I'm trying to reduce the noise in the jdk/jdk CI. I'm ProblemListing
c
On 3/11/20 3:35 PM, serguei.spit...@oracle.com wrote:
Please, review the fix of:
https://bugs.openjdk.java.net/browse/JDK-8240881
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/8240881-encoding-antidelta/
Thumbs up! This is a trivial changeset so you may push with a
single (R)eviewe
The replacement bug should be filed with this description:
[REDO] 8222489 jcmd VM.system_properties gives unusable paths on
Windows
and should be linked to the original bug also.
Dan
On 3/11/20 3:52 PM, serguei.spit...@oracle.com wrote:
Hi Chihiro,
I've tested and pushed your fix but
Thumbs up. Also, this fix is trivial.
Dan
On 3/18/20 4:05 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8241162
diff --git a/test/hotspot/jtreg/ProblemList.txt
b/test/hotspot/jtreg/ProblemList.txt
--- a/test/hotspot/jtreg/ProblemList
On 3/17/20 4:14 PM, Patricio Chilano wrote:
Hi all,
Please review the following patch:
Bug: https://bugs.openjdk.java.net/browse/JDK-8240902
Webrev: http://cr.openjdk.java.net/~pchilanomate/8240902/v1/webrev/
src/jdk.jdi/share/native/libdt_shmem/shmemBase.c
L411: int attempts = 10;
Patricio,
This is a separate follow up about the jshell tests. Since I have been
tracking these as part of my GK work and filed a number of those bugs,
I figured I would help analyze them...
JDK-8209848 test/langtools/jdk/jshell tests failed with Accept timed out
https://bugs.openjdk.java.net/br
serviceability-dev@... was included in this email by mistake.
This was only supposed to go to Patricio since the Mach5 links
won't work outside of Oracle. Sigh...
Sorry about the noise folks!
Dan
On 3/18/20 5:37 PM, Daniel D. Daugherty wrote:
Patricio,
This is a separate follow up abou
> Inc: http://cr.openjdk.java.net/~pchilanomate/8240902/v2/inc/webrev/
> (not sure why the indent fixes are not highlighted as changes but
the Frames view does show they changed)
By default, webrev ignores leading and trailing whitespace changes. Use:
-b: Do not ignore changes in the am
Greetings,
I have a trivial review for ProblemListing some tests.
We're having some network issues with the new OSX 10.15 machines that
are being addressed. In the mean time, I'm trying to reduce the noise
in the CI in Tier5 and Tier6 so I'm ProblemListing the affected tests:
$ hg diff
diff -r
Thanks for the fast review!
Dan
On 3/24/20 1:03 PM, Christian Tornqvist wrote:
Looks good, thanks for doing this.
Thanks,
Christian
On Mar 24, 2020, at 10:01 AM, Daniel D. Daugherty
wrote:
Greetings,
I have a trivial review for ProblemListing some tests.
We're having some ne
Thumbs up. This is a trivial review, but you didn't qualify it as such
so now you have a second review.
Dan
On 3/26/20 4:41 PM, Christian Tornqvist wrote:
Hi Chris,
Looks good, thanks for fixing this.
Thanks,
Christian
On Mar 26, 2020, at 1:27 PM, Chris Plummer wrote:
Hello,
Please revi
Add Robbin to this thread...
This reminded of the following RFE that Robbin filed:
JDK-8201641 JVMTI: GetThreadListStackTraces should use Thread-Local
Handshakes
https://bugs.openjdk.java.net/browse/JDK-8201641
We could update 8201641 to include everything that Yasumasa-san is
reque
Thumbs up. This is a trivial fix.
Dan
On 4/4/20 4:07 AM, Chris Plummer wrote:
Hi,
I just added this test, but it often fails due to a pre-existing SA
bug on OSX that happens during heap dumps. It needs to be problem listed:
diff --git a/test/hotspot/jtreg/ProblemList.txt
b/test/hotspot/jt
On 4/6/20 4:10 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242235
http://cr.openjdk.java.net/~cjplummer/8242235/webrev.00
test/hotspot/jtreg/ProblemList.txt
No comments.
test/jdk/ProblemList.txt
No comments.
test/lib/jdk/tes
On 4/6/20 5:08 PM, Chris Plummer wrote:
On 4/6/20 1:21 PM, Daniel D. Daugherty wrote:
On 4/6/20 4:10 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs.openjdk.java.net/browse/JDK-8242235
http://cr.openjdk.java.net/~cjplummer/8242235/webrev.00
test/hotspot/jtreg
Is it possible that some logging output that may occur after the key string
("-- listing properties --") is observed will confuse the test? I suspect
not, but I wanted to ask to be sure...
Thumbs up.
Dan
On 4/8/20 2:54 PM, Chris Plummer wrote:
Hello,
Please review the following:
https://bugs
n the tests passing when run in more "normal"
fashion.
Chris
On 4/8/20 12:10 PM, Daniel D. Daugherty wrote:
Is it possible that some logging output that may occur after the key
string
("-- listing properties --") is observed will confuse the test? I
suspect
not, but I want
Also, even though you did not ask for an "RFR(T)", I think this is
a trivial fix. You don't have to wait for 24 hours and can push when
you are happy with your testing.
Dan
On 4/8/20 4:21 PM, Daniel D. Daugherty wrote:
To reiterate:
> Thumbs up.
Dan
On 4/8/20 4:07 PM, C
On 4/7/20 6:39 PM, serguei.spit...@oracle.com wrote:
Please, review a fix for minor JDI enhancement:
https://bugs.openjdk.java.net/browse/JDK-8242241
Webrev:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/8242241-jdi-add-assert.1/
src/jdk.jdi/share/classes/com/sun/tools/jdi/EventSetImpl.jav
On 4/9/20 4:42 PM, Alex Menkov wrote:
Hi all,
Please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8242282
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/jpsTest_ClsNotFound/webrev/
test/jdk/sun/tools/jps/LingeredAppForJps.java
L89: manifestClasspath += " "
Sorry, pressed "send" too soon. There's no information on how this fix
was tested. Right now we're seeing a varying number of failures in almost
every Tier5 CI job set. Please verify that you've tested Tier5.
Dan
On 4/9/20 5:01 PM, Daniel D. Daugherty wrote:
On 4/
On 4/9/20 5:15 PM, Alex Menkov wrote:
On 04/09/2020 14:01, Daniel D. Daugherty wrote:
On 4/9/20 4:42 PM, Alex Menkov wrote:
Hi all,
Please review the fix for
https://bugs.openjdk.java.net/browse/JDK-8242282
webrev:
http://cr.openjdk.java.net/~amenkov/jdk15/jpsTest_ClsNotFound/webrev/
test
On 4/9/20 5:17 PM, Alex Menkov wrote:
On 04/09/2020 14:04, Daniel D. Daugherty wrote:
Sorry, pressed "send" too soon. There's no information on how this fix
was tested. Right now we're seeing a varying number of failures in
almost
every Tier5 CI job set. Please verif
Thumbs up. And I agree that this is a trivial change.
Dan
On 4/28/20 4:57 PM, Chris Plummer wrote:
Hello,
Please review the following trivial change:
diff --git
a/test/hotspot/jtreg/serviceability/sa/TestJmapCoreMetaspace.java
b/test/hotspot/jtreg/serviceability/sa/TestJmapCoreMetaspace.ja
On 5/7/20 1:35 AM, Mikael Vidstedt wrote:
New webrev here:
webrev:
http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/hotspot/open/webrev/
This pretty much says it all:
> Summary of changes: 90904 lines changed: 8 ins; 90725 del; 171
mod; 103780 unchg
My review is focused on
On 6/10/20 7:44 AM, David Holmes wrote:
On 10/06/2020 8:17 pm, Robbin Ehn wrote:
Hi David,
Honestly I think I'd like to see things reverted to the use of
calling_thread as done for the VMOperation previously. We know it is
functionally correct and it should also have the same performance
prof
On 6/10/20 9:57 AM, Robbin Ehn wrote:
Hi David and Serguei, (Dan feel free to chime in)
Honestly I think I'd like to see things reverted to the use of
calling_thread as done for the VMOperation previously. We know it is
functionally correct and it should also have the same performance
profile
Hi Serguei,
Sorry for the late review...
On 5/28/20 7:16 PM, serguei.spit...@oracle.com wrote:
Hi Coleen,
The updated webrev version is:
http://cr.openjdk.java.net/~sspitsyn/webrevs/2020/jvmti-redef.3/
src/hotspot/share/oops/cpCache.cpp
nit - please update copyright year before you push
Hi Ralf,
This looks correct to me, but please wait for one of the GC folks to
chime in on this thread...
Dan
On 6/10/20 5:00 PM, Schmelter, Ralf wrote:
Hi,
https://bugs.openjdk.java.net/browse/JDK-8237354 added a test, which did not
properly protect against explicitly set GCs (for serial, p
Greetings,
It's time to reduce the noise in the CI so I'm ProblemListing tests.
Here's the bug for failure:
JDK-8205957 setfldw001/TestDescription.java fails with bad field value
https://bugs.openjdk.java.net/browse/JDK-8205957
and here's the bug for the ProblemListing:
JDK-824749
Tap, tap, tap... is this thing working?
Anyone out there? This is a trivial 1-liner review...
Dan
On 6/12/20 12:46 PM, Daniel D. Daugherty wrote:
Greetings,
It's time to reduce the noise in the CI so I'm ProblemListing tests.
Here's the bug for failure:
JDK-820
another since JDK7. If someone
decides to fix it, then they can un-ProblemList it.
I'm planning to push it to JDK15 and JDK16. Those two releases are the focus
of my CI noise reduction efforts. I don't monitor the JDK14u CI...
May I proceed with the ProblemListing?
Dan
thanks,
Chris
Yumin,
Thanks for the review!
Dan
On 6/12/20 2:51 PM, Yumin Qi wrote:
Hi, Dan
Looks good to me and it is trivial.
Thanks
Yumin
On 6/12/20 11:40 AM, Daniel D. Daugherty wrote:
Tap, tap, tap... is this thing working?
Anyone out there? This is a trivial 1-liner review...
Dan
On 6/12
On 6/12/20 2:58 PM, Chris Plummer wrote:
On 6/12/20 11:52 AM, Daniel D. Daugherty wrote:
On 6/12/20 2:49 PM, Chris Plummer wrote:
Hi Dan,
What's the criteria for "noise".
There is no specific criteria that I'm aware of.
It popped up in today's JDK15 testing so
On 6/12/20 4:48 PM, Chris Plummer wrote:
On 6/12/20 12:13 PM, Daniel D. Daugherty wrote:
On 6/12/20 2:58 PM, Chris Plummer wrote:
On 6/12/20 11:52 AM, Daniel D. Daugherty wrote:
On 6/12/20 2:49 PM, Chris Plummer wrote:
Hi Dan,
What's the criteria for "noise".
There is no sp
On 6/12/20 5:20 PM, Chris Plummer wrote:
On 6/12/20 1:59 PM, Daniel D. Daugherty wrote:
On 6/12/20 4:48 PM, Chris Plummer wrote:
On 6/12/20 12:13 PM, Daniel D. Daugherty wrote:
On 6/12/20 2:58 PM, Chris Plummer wrote:
On 6/12/20 11:52 AM, Daniel D. Daugherty wrote:
On 6/12/20 2:49 PM, Chris
care about it!
Thanks,
Serguei
On 6/12/20 14:20, Chris Plummer wrote:
On 6/12/20 1:59 PM, Daniel D. Daugherty wrote:
On 6/12/20 4:48 PM, Chris Plummer wrote:
On 6/12/20 12:13 PM, Daniel D. Daugherty wrote:
On 6/12/20 2:58 PM, Chris Plummer wrote:
On 6/12/20 11:52 AM, Daniel D. Daugherty
On 6/15/20 3:26 AM, David Holmes wrote:
On 15/06/2020 4:02 pm, Yasumasa Suenaga wrote:
Hi David,
On 2020/06/15 14:15, David Holmes wrote:
Hi Yasumasa,
On 15/06/2020 2:49 pm, Yasumasa Suenaga wrote:
Hi all,
I wonder why JvmtiEnvBase::get_object_monitor_usage()
(implementation of GetObjectMo
On 6/15/20 10:45 AM, Yasumasa Suenaga wrote:
On 2020/06/15 22:38, Daniel D. Daugherty wrote:
On 6/15/20 3:26 AM, David Holmes wrote:
On 15/06/2020 4:02 pm, Yasumasa Suenaga wrote:
Hi David,
On 2020/06/15 14:15, David Holmes wrote:
Hi Yasumasa,
On 15/06/2020 2:49 pm, Yasumasa Suenaga wrote
On 6/15/20 6:14 PM, David Holmes wrote:
Hi Dan,
On 15/06/2020 11:38 pm, Daniel D. Daugherty wrote:
On 6/15/20 3:26 AM, David Holmes wrote:
On 15/06/2020 4:02 pm, Yasumasa Suenaga wrote:
Hi David,
On 2020/06/15 14:15, David Holmes wrote:
Hi Yasumasa,
On 15/06/2020 2:49 pm, Yasumasa Suenaga
On 6/15/20 7:19 PM, David Holmes wrote:
On 16/06/2020 8:40 am, Daniel D. Daugherty wrote:
On 6/15/20 6:14 PM, David Holmes wrote:
Hi Dan,
On 15/06/2020 11:38 pm, Daniel D. Daugherty wrote:
On 6/15/20 3:26 AM, David Holmes wrote:
On 15/06/2020 4:02 pm, Yasumasa Suenaga wrote:
Hi David,
On
On 6/15/20 9:28 PM, David Holmes wrote:
On 16/06/2020 10:57 am, Daniel D. Daugherty wrote:
On 6/15/20 7:19 PM, David Holmes wrote:
On 16/06/2020 8:40 am, Daniel D. Daugherty wrote:
On 6/15/20 6:14 PM, David Holmes wrote:
Hi Dan,
On 15/06/2020 11:38 pm, Daniel D. Daugherty wrote:
On 6/15/20
David Holmes wrote:
Ok, may I file it to JBS and fix it?
Go for it! :)
Cheers,
David
On 17/06/2020 10:23 am, Yasumasa Suenaga wrote:
On 2020/06/17 8:47, serguei.spit...@oracle.com wrote:
Hi Dan, David and Yasumasa,
On 6/16/20 07:39, Daniel D. Daugherty wrote:
On 6/15/20 9:28 PM, David
On 6/18/20 10:04 AM, David Holmes wrote:
On 18/06/2020 11:55 pm, Daniel D. Daugherty wrote:
On 6/18/20 9:18 AM, David Holmes wrote:
On 18/06/2020 7:07 pm, Yasumasa Suenaga wrote:
On 2020/06/18 17:36, David Holmes wrote:
On 18/06/2020 3:47 pm, Yasumasa Suenaga wrote:
Hi David,
Both
! :)
Cheers,
David
On 17/06/2020 10:23 am, Yasumasa Suenaga wrote:
On 2020/06/17 8:47, serguei.spit...@oracle.com wrote:
Hi Dan, David and Yasumasa,
On 6/16/20 07:39, Daniel D. Daugherty wrote:
On 6/15/20 9:28 PM, David Holmes wrote:
On 16/06/2020 10:57 am, Daniel D. Daugherty wrote:
On 6/15/20 7:19 PM,
On 6/22/20 7:55 PM, Jonathan Gibbons wrote:
Please review a small change to fix an unresolved reference in
`@throws IOException`.
Thumbs up.
Dan
The problem is that the method signature uses a fully-qualified name
for `java.io.IOException` instead of importing it. meaning that the
`@th
On 6/18/20 8:54 PM, Chris Plummer wrote:
[I've added runtime-dev to this SA review since understanding
interpreter invokes (code generated by
TemplateInterpreterGenerator::generate_normal_entry()) and stack
walking is probably more important than understanding SA.]
Hello,
Please help review
oint of view of the person reading the output, they want to
know the values for sp, fp, and pc. But within the code these values
are stored in the "found" variables.
In that case, the code is wrong for the 'fp' and 'pc' outputs
since you changed the labels and not
On 6/23/20 11:04 PM, Chris Plummer wrote:
On 6/23/20 7:07 PM, Daniel D. Daugherty wrote:
Just one more comment on this part:
> L220: System.out.println("CurrentFrameGuess: choosing
interpreter frame: sp = " +
> L221: spFound + &quo
Greetings,
I'm doing another round of reduce-the-noise in the CI in preparation
for the upcoming weekend... So I have another trivial review...
Here's the bug for the failures:
JDK-8247426 ThreadMXBean/ThreadMXBeanStateTest.java still times out
https://bugs.openjdk.java.net/browse/JDK-8
On 6/25/20 1:33 PM, Yumin Qi wrote:
Hi, please review the tiny changes for
bug: https://bugs.openjdk.java.net/browse/JDK-8203005
webrev:http://cr.openjdk.java.net/~minqi/2020/8203005/webrev-00/
src/hotspot/share/interpreter/bytecodes.cpp
No comments.
src/jdk.hotspot.agent/share/classes/s
Igor,
Thanks for the fast review!
Dan
On 6/25/20 1:45 PM, Igor Ignatyev wrote:
Hi Dan,
LGTM
-- Igor
On Jun 25, 2020, at 10:34 AM, Daniel D. Daugherty
wrote:
Greetings,
I'm doing another round of reduce-the-noise in the CI in preparation
for the upcoming weekend... So I have an
Greetings,
I'm doing another round of reduce-the-noise in the CI in preparation
for the upcoming weekend... So I have another trivial review...
Here's the bug for the failures:
JDK-8225354
serviceability/jvmti/ModuleAwareAgents/ThreadStart/MAAThreadStart.java
failed with Di
Greetings,
I'm doing another round of reduce-the-noise in the CI in preparation
for the upcoming weekend... So I have another trivial review...
Here's the bug for the failures:
JDK-8246493 JDI stress/serial/mixed002 "nsk.share.TestBug: There
are more than one(2)
instance o
Thanks for the fast review!
Dan
On 6/25/20 5:50 PM, Chris Plummer wrote:
Looks good. This a new failure as of June 2nd and has failed quite a
bit the past 3 weeks or so.
Chris
On 6/25/20 2:22 PM, Daniel D. Daugherty wrote:
Greetings,
I'm doing another round of reduce-the-noise in t
Any takers? This is a trivial one liner for a single platform here...
Dan
On 6/25/20 4:44 PM, Daniel D. Daugherty wrote:
Greetings,
I'm doing another round of reduce-the-noise in the CI in preparation
for the upcoming weekend... So I have another trivial review...
Here's the b
Thanks Igor!!
Dan
On 6/25/20 6:27 PM, Igor Ignatyev wrote:
LGTM,
-- Igor
On Jun 25, 2020, at 1:44 PM, Daniel D. Daugherty
wrote:
Greetings,
I'm doing another round of reduce-the-noise in the CI in preparation
for the upcoming weekend... So I have another trivial review...
Here&
Greetings,
I have a fix for the following bug:
JDK-8246493 JDI stress/serial/mixed002 needs to use
WhiteBox.deflateIdleMonitors support
https://bugs.openjdk.java.net/browse/JDK-8246493
Here's the webrev URL:
http://cr.openjdk.java.net/~dcubed/8246493-webrev/0_for_jdk16/
The test bug
n the file anymore.
Otherwise the changes look good.
thanks,
Chris
On 6/29/20 12:21 PM, Daniel D. Daugherty wrote:
Greetings,
I have a fix for the following bug:
JDK-8246493 JDI stress/serial/mixed002 needs to use
WhiteBox.deflateIdleMonitors support
https://bugs.openjdk.java.net/browse
Hi Chris,
This one caught my eye just because it was such an old bug number... :-)
On 6/26/20 7:03 PM, Chris Plummer wrote:
Hello,
Please help review the following:
http://cr.openjdk.java.net/~cjplummer/7107012/webrev.00/index.html
src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/C
thing that linked the bug to my
fix for JDK-8153224.
On 6/29/20 3:49 PM, Chris Plummer wrote:
Looks good.
Chris
On 6/29/20 12:45 PM, Daniel D. Daugherty wrote:
Chris and Serguei,
Thanks for the fast reviews!!
I generated the webrev in my "mach5" directory and that was baselined
on t
version: I don't think we want to back port part of a patch from
JDK16 -> JDK15 in order to fix this test bug.
Dan
On 6/29/20 4:41 PM, Chris Plummer wrote:
Hi Dan,
I think you should push it directly to 15 since it's a new issue.
thanks,
Chris
On 6/29/20 12:53 PM, Daniel D.
Thanks for review!
Dan
On 6/29/20 5:16 PM, serguei.spit...@oracle.com wrote:
+1
Thanks,
Serguei
On 6/29/20 12:49, Chris Plummer wrote:
Looks good.
Chris
On 6/29/20 12:45 PM, Daniel D. Daugherty wrote:
Chris and Serguei,
Thanks for the fast reviews!!
I generated the webrev in my
e the
WhiteBox.deflateIdleMonitors() backport.
thanks,
Chris
On 6/29/20 1:53 PM, Daniel D. Daugherty wrote:
The WhiteBox.deflateIdleMonitors() support is not in JDK15. That's
something that added in JDK16 so I'd have to also backport that support.
That support was included with another change (getting rid
On 7/2/20 5:19 AM, Yasumasa Suenaga wrote:
Hi David,
I upload new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8242428/webrev.03/
src/hotspot/share/prims/jvmtiEnv.cpp
L1542: // Get stack trace with handshake
nit - please add a period at the end.
On 7/2/20 7:14 PM, Yasumasa Suenaga wrote:
Hi Dan,
Thanks for your comment!
On 2020/07/03 7:16, Daniel D. Daugherty wrote:
On 7/2/20 5:19 AM, Yasumasa Suenaga wrote:
Hi David,
I upload new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8242428/webrev.03/
src
On 7/2/20 10:50 PM, David Holmes wrote:
Sorry I'm responding here without seeing latest webrev but there is
enough context I think ...
On 3/07/2020 9:14 am, Yasumasa Suenaga wrote:
Hi Dan,
Thanks for your comment!
On 2020/07/03 7:16, Daniel D. Daugherty wrote:
On 7/2/20 5:19 AM, Yas
ent point.
Thanks,
Serguei
On 7/2/20 23:29, Yasumasa Suenaga wrote:
Hi Dan, David,
I uploaded new webrev. Could you review again?
http://cr.openjdk.java.net/~ysuenaga/JDK-8242428/webrev.04/
OneGetThreadListStackTraces.java in this webrev would
wait until thread state is transited to "
Adding serviceability-dev@... since a couple of JVM/TI files are changed
in this RFR. Also, I moved the bug from hotspot/runtime -> hotspot/gc.
Dan
On 7/9/20 2:36 AM, Aleksey Shipilev wrote:
RFE:
https://bugs.openjdk.java.net/browse/JDK-8249137
It was added by JDK-8211270 to support old-st
On 7/9/20 9:07 AM, Jaroslav Bachorík wrote:
Hello,
Recently, after backporting JDK-8233197 to JDK8u I received a report
from Sergey Nazarkin (cc) that the backport broke JVMTI spec basically
emitting JVMTI_EVENT_THREAD_START events in primordial phase while the
spec states that it should be emit
/9/20 3:34 PM, Daniel D. Daugherty wrote:
Adding serviceability-dev@... since a couple of JVM/TI files are changed
in this RFR. Also, I moved the bug from hotspot/runtime -> hotspot/gc.
Dan
On 7/9/20 2:36 AM, Aleksey Shipilev wrote:
RFE:
https://bugs.openjdk.java.net/browse/JDK-8249137
It
1 - 100 of 1805 matches
Mail list logo
