Hi David,
The tests start a couple of external processes and have a procedure of
destroying them if something unexpected happens. But when JVM crashes in the
middle of the execution this procedure is useless and processes are left on
servers. It should be up to framework to do clean-up. Unfortu
On 4/3/14 2:31 AM, Staffan Larsen wrote:
Thanks Serguei,
I don’t think it is necessary to initialize ‘end’ since strtol will always set
it.
Ok.
I still need an official Reviewer for this change.
I'm not an official reviewer yet.
Thanks,
Serguei
Thanks,
/Staffan
On 28 mar 2014, at 0
On 4/6/14 11:13 PM, Staffan Larsen wrote:
Curious: What does NPT stand for?
This is from Kelly:
The original purpose of this library was to provide some generic*native
platform tools*
for dealing with things that will happen BEFORE the JVM is started and Java
code can be called.
Thanks,
Since the testlibrary exists even in the JDK part I would like to add the
Serviceability and Corelibs teams to this discussion.
Thanks,
Katja
- Original Message -
From: [email protected]
To: [email protected]
Sent: Monday, April 7, 2014 3:50:14 AM GMT +01:00 Amsterdam
Hi,
Sorry for the noise but I need to get the fix re-reviewed.
Due to the way jtreg cooperates with TestNG when runnning in agentvm I
can not use package private methods or constructor or fields.
The updated patch -
http://cr.openjdk.java.net/~jbachorik/8039080/webrev.01 - makes the
JInfo co
Looks good, but should we maybe have a comment in JInfo.java about the
structure being needed for testing? Just looking at the code this is not
obvious.
/Staffan
On 7 apr 2014, at 12:46, Jaroslav Bachorik wrote:
> Hi,
>
> Sorry for the noise but I need to get the fix re-reviewed.
> Due to th
Jaroslav,
Is it necessary to add "ValidationException"?
Could we change the constructor JInfo to:
private static boolean validateArgs(String[] args);
the method returns false if the args are illegal, or throw an
IllegalArgumentException
and declare the variables "args" and "useSA" as stati
On 7.4.2014 14:10, shanliang wrote:
Jaroslav,
Is it necessary to add "ValidationException"?
Well, for the implementation when the validation is performed at the
moment a new instance of JInfo is being created it is necessary.
Could we change the constructor JInfo to:
private static bool
shanliang wrote:
Jaroslav,
Is it necessary to add "ValidationException"?
Could we change the constructor JInfo to:
private static boolean validateArgs(String[] args);
the method returns false if the args are illegal, or throw an
IllegalArgumentException
and declare the variables "args" an
On 7.4.2014 14:23, shanliang wrote:
shanliang wrote:
Jaroslav,
Is it necessary to add "ValidationException"?
Could we change the constructor JInfo to:
private static boolean validateArgs(String[] args);
the method returns false if the args are illegal, or throw an
IllegalArgumentException
Jaroslav Bachorik wrote:
On 7.4.2014 14:10, shanliang wrote:
Jaroslav,
Is it necessary to add "ValidationException"?
Well, for the implementation when the validation is performed at the
moment a new instance of JInfo is being created it is necessary.
Could not use an existing Exception? like I
Hi Everybody,
Please review the patch
http://cr.openjdk.java.net/~dsamersoff/JDK-8038392/webrev.02/
it's based on the patch contributed by Carlos Santos (see CR) and all
credentials belong to him.
-Dmitry
--
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would lov
Carlos,
I'd droppend changes in libproc_impl.c as it seems to be not related to
prelink issue.
PS:
(from proposed patch) libproc_impl.c :
+ if (namelen >= sizeof(newlib->name)) {
sizeof(newlib->name) is PATH_MAX + NAME_MAX
Are you able to reproduce the issue with too long library name? if yes
Jaroslav, Staffan, thanks for the reviews!
Jaroslav, could you please be my sponsor and apply the patch attached to
this mail?
Best regards,
Katja
On 04/04/2014 04:04 PM, Jaroslav Bachorik wrote:
No more comments.
-JB-
# HG changeset patch
# User ykantser
# Date 1396880023 -7200
# Node
Carlos,
I might be missing something. Sorry about that.
Looking at openjdk7 code
http://hg.openjdk.java.net/jdk7/hotspot/hotspot/file/9b0ca45cd756/agent/src/os/linux/libproc_impl.c
newlib->base is unconditionally initialized at ll. 157
so if we move it after symtab initialization at ll. 181 it
On 7.4.2014 16:31, Yekaterina Kantserova wrote:
Jaroslav, Staffan, thanks for the reviews!
Jaroslav, could you please be my sponsor and apply the patch attached to
this mail?
Yep, will do that.
-JB-
Best regards,
Katja
On 04/04/2014 04:04 PM, Jaroslav Bachorik wrote:
No more comments.
Might have been native platform toolkit... ;)
-kto
On Apr 7, 2014, at 12:12 AM, [email protected] wrote:
> On 4/6/14 11:13 PM, Staffan Larsen wrote:
>> Curious: What does NPT stand for?
>
> This is from Kelly:
>
> > The original purpose of this library was to provide some generic nati
Keep in mind that there are 3 sets of sources for npt, share/npt, solaris/npt
and windows/npt
it is quite platform specific, using iconv libraries on solaris/linux, and
multi/wide byte strangeness on windows.
So it wasn't just the functionality that drove it into it's own library, the
implement
- Original Message -
> Hi Everybody,
>
> Please review the patch
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8038392/webrev.02/
The fix in agent/src/os/linux/libproc_impl.c contained in my original patch is
missing. Was it included in a separate patch?
Carlos Santos (casantos)
Senio
Dmitry,
You are right. I got confused because a previous version of the patch
incorrectly removed the assignment that existed in line 157, so I added it back
later.
Carlos Santos (casantos)
Senior *Software* Maintenance Engineer
(no, I'm not going to fix your roof)
Red Hat, Inc
- Original
Dmitry,
The main problem in libproc_impl.c is that newlib->base is left uninitialized.
The check for the name length is just a safety measure. We can live without it
but I'd prefer to avoid the risk.
Carlos Santos (casantos)
Senior *Software* Maintenance Engineer
(no, I'm not going to fix your
Carlos,
Are you OK with proposed changes?
-Dmitry
On 2014-04-07 20:17, Carlos Santos wrote:
> Dmitry,
>
> You are right. I got confused because a previous version of the patch
> incorrectly removed the assignment that existed in line 157, so I added it
> back later.
>
> Carlos Santos (casant
Kelly,
Thank you for the reminder.
I'd checked it before posting this letter - platform specific code is
used in two places:
1)
in src/share/back/transport.c
the use of utf-8 here is not consistent e.g.
ll. 621
/* Construct complete command line (all in UTF-8) */
commandLine = jvmtiAlloc
I thought the debugger backend too, you might check src/share/back, inside
util.h and debugInit.h
Grep for gdata->npt
But I've been away from the code for a long time, so my knowledge might be
dusty.
-kto
On Apr 7, 2014, at 10:05 AM, Dmitry Samersoff wrote:
> Kelly,
>
> Thank you for the rem
The problem here is that the code for finding local VMs is not looking for the
data in the correct place.
When a JVM is started it will create the perf-data file in a user-specific
directory inside /tmp (*). The code in the JDK (PerfDataFile.java) that lists
all active JVMs looks for the user-
And the links:
bug: https://bugs.openjdk.java.net/browse/JDK-8033104
webrev: http://cr.openjdk.java.net/~sla/8033104/webrev.00/
Sorry about that,
/Staffan
On 7 apr 2014, at 20:08, Staffan Larsen wrote:
>
> The problem here is that the code for finding local VMs is not looking for
> the data
26 matches
Mail list logo
