Re: RFR: JDK-8242282: Test sun/tools/jps/TestJps.java fails after JDK-8237572

2020-04-09 Thread Chris Plummer
Hi Alex, Please add a newline between lines 70 and 71.   77 // are writen the jar manifest. "writen" -> "written to" No need to see another review. thanks, Chris On 4/9/20 3:50 PM, Alex Menkov wrote: Hi Chris, I tried to describe main idea of the code. updated webrev: http://cr.o

Re: RFR: JDK-8242282: Test sun/tools/jps/TestJps.java fails after JDK-8237572

2020-04-09 Thread Alex Menkov
Hi Chris, I tried to describe main idea of the code. updated webrev: http://cr.openjdk.java.net/~amenkov/jdk15/jpsTest_ClsNotFound/webrev.01/ the only change vs prev. webrev is added comment in LingeredAppForJps.java --alex On 04/09/2020 14:28, Chris Plummer wrote: Hi Alex, The fix looks go

Re: RFR: JDK-8242282: Test sun/tools/jps/TestJps.java fails after JDK-8237572

2020-04-09 Thread Chris Plummer
Hi Alex, The fix looks good, but the test is in need of some commenting. It took a fair amount of staring at the code,  the CR, and the RFR to figure out what it is doing and why. Can you add a few comments? // Add the main class to the jar file. It should only be found in one classpath, the

Re: RFR: JDK-8242282: Test sun/tools/jps/TestJps.java fails after JDK-8237572

2020-04-09 Thread Daniel D. Daugherty
On 4/9/20 5:17 PM, Alex Menkov wrote: On 04/09/2020 14:04, Daniel D. Daugherty wrote: Sorry, pressed "send" too soon. There's no information on how this fix was tested. Right now we're seeing a varying number of failures in almost every Tier5 CI job set. Please verify that you've tested Tier

Re: RFR: JDK-8242282: Test sun/tools/jps/TestJps.java fails after JDK-8237572

2020-04-09 Thread Daniel D. Daugherty
On 4/9/20 5:15 PM, Alex Menkov wrote: On 04/09/2020 14:01, Daniel D. Daugherty wrote: On 4/9/20 4:42 PM, Alex Menkov wrote: Hi all, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8242282 webrev: http://cr.openjdk.java.net/~amenkov/jdk15/jpsTest_ClsNotFound/webrev/ test/

Re: RFR: JDK-8242282: Test sun/tools/jps/TestJps.java fails after JDK-8237572

2020-04-09 Thread Alex Menkov
On 04/09/2020 14:04, Daniel D. Daugherty wrote: Sorry, pressed "send" too soon. There's no information on how this fix was tested. Right now we're seeing a varying number of failures in almost every Tier5 CI job set. Please verify that you've tested Tier5. Tested open/test/jdk/sun/tools/jps/

Re: RFR: JDK-8242282: Test sun/tools/jps/TestJps.java fails after JDK-8237572

2020-04-09 Thread Alex Menkov
On 04/09/2020 14:01, Daniel D. Daugherty wrote: On 4/9/20 4:42 PM, Alex Menkov wrote: Hi all, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8242282 webrev: http://cr.openjdk.java.net/~amenkov/jdk15/jpsTest_ClsNotFound/webrev/ test/jdk/sun/tools/jps/LingeredAppForJps.ja

Re: RFR: JDK-8242282: Test sun/tools/jps/TestJps.java fails after JDK-8237572

2020-04-09 Thread Daniel D. Daugherty
Sorry, pressed "send" too soon. There's no information on how this fix was tested. Right now we're seeing a varying number of failures in almost every Tier5 CI job set. Please verify that you've tested Tier5. Dan On 4/9/20 5:01 PM, Daniel D. Daugherty wrote: On 4/9/20 4:42 PM, Alex Menkov wrot

Re: RFR: JDK-8242282: Test sun/tools/jps/TestJps.java fails after JDK-8237572

2020-04-09 Thread Daniel D. Daugherty
On 4/9/20 4:42 PM, Alex Menkov wrote: Hi all, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8242282 webrev: http://cr.openjdk.java.net/~amenkov/jdk15/jpsTest_ClsNotFound/webrev/ test/jdk/sun/tools/jps/LingeredAppForJps.java     L89:     manifestClasspath += " "

RFR: JDK-8242282: Test sun/tools/jps/TestJps.java fails after JDK-8237572

2020-04-09 Thread Alex Menkov
Hi all, Please review the fix for https://bugs.openjdk.java.net/browse/JDK-8242282 webrev: http://cr.openjdk.java.net/~amenkov/jdk15/jpsTest_ClsNotFound/webrev/ The test creates jar with test classes and run it with "java -jar ". The problem is single "@run Test" tag is executed by JTreg incon