On Tue, 10 May 2022 09:07:44 GMT, Adam Sotona wrote:
>> Please review this patch adding new lint option, **lossy-conversions**, to
>> javac to warn about type casts in compound assignments with possible lossy
>> conversions.
>>
>> The new lint warning is shown if the type of the right-hand ope
On Tue, 10 May 2022 20:03:45 GMT, Alan Bateman wrote:
> I skimmed through the changes and I think they look okay. In the distant past
> there were tools outside of the JDK that used the jvmstat API directly. It's
> possible that VisualVM still does but it would only compile/run if
> --add-expo
On Tue, 10 May 2022 19:59:41 GMT, Alan Bateman wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review comments
>
> src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/file/PerfDataBuffer.java
>
On Tue, 10 May 2022 21:43:44 GMT, Claes Redestad wrote:
>> Ioi Lam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> review comments
>
> src/hotspot/os/windows/perfMemory_windows.cpp line 1781:
>
>> 1779: // address space.
>> 1780: //
>>
> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never
> supported the value `"rw"` since the source code was imported to the openjdk
> repo more than 15 years ago. In fact HotSpot throws
> `IllegalArgumentException` when such a mode is specified.
>
> It's unlikely such a mode
On Tue, 10 May 2022 20:23:01 GMT, Leonid Mesnik wrote:
> 8283001: windows-x86-cmp-baseline fails in some jvmti native libs
Looks good.
Thanks,
Serguei
-
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/8641
On Wed, 27 Apr 2022 23:49:56 GMT, Leonid Mesnik wrote:
> The test failed if GC happens somewhere between
> Class c = Class.forName("TestClass", true, dummyloader);
> and
> OutputAnalyzer output = executor.execute("VM.classloader_stats");
>
> The fix is to make hc static as Chris proposed.
>
>
On Tue, 10 May 2022 19:21:44 GMT, Leonid Mesnik wrote:
>> The test failed if GC happens somewhere between
>> Class c = Class.forName("TestClass", true, dummyloader);
>> and
>> OutputAnalyzer output = executor.execute("VM.classloader_stats");
>>
>> The fix is to make hc static as Chris proposed.
On Tue, 10 May 2022 04:00:29 GMT, Ioi Lam wrote:
> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never
> supported the value `"rw"` since the source code was imported to the openjdk
> repo more than 15 years ago. In fact HotSpot throws
> `IllegalArgumentException` when such a
8283001: windows-x86-cmp-baseline fails in some jvmti native libs
-
Commit messages:
- 8283001
Changes: https://git.openjdk.java.net/jdk/pull/8641/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8641&range=00
Issue: https://bugs.openjdk.java.net/browse/JDK-8283001
S
On Tue, 10 May 2022 04:00:29 GMT, Ioi Lam wrote:
> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never
> supported the value `"rw"` since the source code was imported to the openjdk
> repo more than 15 years ago. In fact HotSpot throws
> `IllegalArgumentException` when such a
On Tue, 10 May 2022 04:00:29 GMT, Ioi Lam wrote:
> The `mode` parameter for ` jdk.internal.perf.Perf.attach()` has never
> supported the value `"rw"` since the source code was imported to the openjdk
> repo more than 15 years ago. In fact HotSpot throws
> `IllegalArgumentException` when such a
> The test failed if GC happens somewhere between
> Class c = Class.forName("TestClass", true, dummyloader);
> and
> OutputAnalyzer output = executor.execute("VM.classloader_stats");
>
> The fix is to make hc static as Chris proposed.
>
> To verfiy fix I add System.gc() before
> executor.execut
On Tue, 10 May 2022 05:14:19 GMT, Alan Bateman wrote:
> I assume you'll remove this test from the-Xcomp exclude list
> (test/hotspot/jtreg/ProblemList-Xcomp.txt) as part of this change,
Sure. The PR reminded me about this. But I need to push problemlist cleanup
first and than merge chnges.
--
On Mon, 9 May 2022 20:35:57 GMT, Leonid Mesnik wrote:
> The default is required only to set the same depth level in the tree on HTML
> page for default and mixed mode.
This pull request has now been integrated.
Changeset: d347fc12
Author:Leonid Mesnik
URL:
https://git.openjdk.java.
Please review this change to the cgroup v1 subsystem which makes it more
resilient on some of the stranger systems. Unfortunately, I wasn't able to
re-create a similar system as the reporter. The idea of using the longest
substring match for the cgroupv1 file paths was based on the fact that on
On Tue, 10 May 2022 11:31:16 GMT, Andrey Turbanov wrote:
>> src/java.desktop/share/classes/javax/imageio/spi/ServiceRegistry.java line
>> 230:
>>
>>> 228: List l = new ArrayList<>();
>>> 229: for (Class c : categoryMap.keySet()) {
>>> 230: if (c.isInstance(provider))
On Tue, 10 May 2022 11:10:50 GMT, Daniel Fuchs wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8280035: Use Class.isInstance instead of Class.isAssignableFrom where
>> applicable
>> apply suggestion to avoid
On Thu, 31 Mar 2022 08:03:23 GMT, Andrey Turbanov wrote:
>> Method `Class.isAssignableFrom` is often used in form of:
>>
>> if (clazz.isAssignableFrom(obj.getClass())) {
>> Such condition could be simplified to more shorter and performarnt code
>>
>> if (clazz.isInstance(obj)) {
>>
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand of a
> compound assignment is not assignment compatibl
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote:
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the right-hand operand o
21 matches
Mail list logo
