RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map

The cache named `signerToCodeSource` is never used now. - Commit messages: - Make signerToCodeSource cache work. Changes: https://git.openjdk.org/jdk/pull/11072/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11072&range=00 Issue: https://bugs.openjdk.org/browse/JDK-829673

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map

On Thu, 10 Nov 2022 16:05:46 GMT, Weijun Wang wrote: > The method is not called since JDK 9, and that's why I set Affected Version/s > to 8-pool. We don't intend to fix this in the current release. Oh. Could you tell me where I should submit this PR? `jdk8u`? - PR: https://git.ope

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map

On Thu, 10 Nov 2022 21:08:34 GMT, Sean Mullan wrote: > If you want to instead do some general cleanup in this class for JDK 20, you > could instead remove this method and several other unused methods from > `JarVerifier`. Before I began to make general cleanup, I looked up from this unused met

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map

On Mon, 14 Nov 2022 18:41:41 GMT, Sean Mullan wrote: > Yes. I believe the `setEagerValidation` method can also be removed and all > code that calls it. OK, I will remove it and all methods that calls it: ![jdk issue 8296734](https://user-images.githubusercontent.com/35672972/202113084-e7308680

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map

On Thu, 17 Nov 2022 19:50:32 GMT, Sean Mullan wrote: > > Because `JarVerifier#setEagerValidation` will be removed, the field > > `eagerValidation` will always be false. > > There are some codes using this field: > > https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/uti

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map [v2]

> The cache named `signerToCodeSource` in `JarVerifier` is never used now. pandaapo has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additio

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map [v3]

> The cache named `signerToCodeSource` in `JarVerifier` is never used now. pandaapo has updated the pull request incrementally with one additional commit since the last revision: Modify as reviews. - Changes: - all: https://git.openjdk.org/jdk/pull/11072/files - new: ht

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map [v2]

On Fri, 18 Nov 2022 15:38:47 GMT, Weijun Wang wrote: >> pandaapo has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains three

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map [v4]

> The cache named `signerToCodeSource` in `JarVerifier` is never used now. pandaapo has updated the pull request incrementally with one additional commit since the last revision: Modify as reviews. - Changes: - all: https://git.openjdk.org/jdk/pull/11072/files - new: ht

Re: RFR: 8296734: JarVerifier:: mapSignersToCodeSource should cache in map [v4]

On Sat, 19 Nov 2022 23:00:44 GMT, Weijun Wang wrote: > since this bug description is about a coding error but you fix is about > cleanup, how about I file another bug and you use it in the title? OK. Thanks. > I am trying to add a noreg-cleanup label to the bug and it does not apply to > the

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v5]

> The cache named `signerToCodeSource` in `JarVerifier` is never used now. pandaapo has updated the pull request incrementally with one additional commit since the last revision: Modify as reviews. - Changes: - all: https://git.openjdk.org/jdk/pull/11072/files - new: ht

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v6]

> The cache named `signerToCodeSource` in `JarVerifier` is never used now. pandaapo has updated the pull request incrementally with one additional commit since the last revision: Modify as review and update copyright. - Changes: - all: https://git.openjdk.org/jdk/pull/11

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v5]

On Sun, 20 Nov 2022 15:37:24 GMT, Weijun Wang wrote: > `codomain`, `VerifierCodeSource`, `isSigningRelated`, and `getUnsignedCS` > also used nowhere. Thanks. I think your `codomain` must mean `csdomain`. - PR: https://git.openjdk.org/jdk/pull/11072

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v7]

> The cache named `signerToCodeSource` in `JarVerifier` is never used now. pandaapo has updated the pull request incrementally with one additional commit since the last revision: Modify as reviews. - Changes: - all: https://git.openjdk.org/jdk/pull/11072/files - new: ht

Re: RFR: 8297301: Cleanup unused methods in JavaUtilJarAccess [v7]

On Tue, 22 Nov 2022 01:44:29 GMT, Weijun Wang wrote: > Everything looks fine now. Thanks so much for the cleanup. It's always nice > to see unused lines removed. Thank you for your review. - PR: https://git.openjdk.org/jdk/pull/11072

Integrated: 8297301: Cleanup unused methods in JavaUtilJarAccess

On Thu, 10 Nov 2022 01:02:00 GMT, pandaapo wrote: > The cache named `signerToCodeSource` in `JarVerifier` is never used now. This pull request has now been integrated. Changeset: f0e99c63 Author: pandaapo <1052156...@qq.com> Committer: Weijun Wang URL: https://git.openjd