Re: RFR: 8339686: java/foreign/TestMappedHandshake.java fails with assert(depth < max_critical_stack_depth) failed: can't have more than 10 critical frames

On Mon, 9 Sep 2024 12:57:17 GMT, Maurizio Cimadamore wrote: > The new test added by https://github.com/openjdk/jdk/pull/20854 fails > spuriously. > While JNI lookup is now moved into the static initializer of the > `MappedMemoryUtils` class, this class might only get initialized while in the

Re: RFR: 8339686: java/foreign/TestMappedHandshake.java fails with assert(depth < max_critical_stack_depth) failed: can't have more than 10 critical frames [v2]

On Mon, 9 Sep 2024 15:30:47 GMT, Maurizio Cimadamore wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Drop spurious change > > src/java.base/share/classes/java/nio/MappedMemoryUtils.java line 128: > >> 126:

Re: RFR: JDK-8295405 : Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests [v2]

On Tue, 18 Oct 2022 14:55:12 GMT, Matthias Baesken wrote: >> We have a number of failing sun/security/pkcs11 test on RHEL 8.6, see >> >> https://bugs.openjdk.org/browse/JDK-8295343 >> 8295343 : sun/security/pkcs11 tests fail on Linux RHEL 8.6 >> >> The exceptions generated by these tests someti

Re: RFR: JDK-8296226: Add constructors (String,Throwable) and (Throwable) to InvalidParameterException [v3]

On Fri, 4 Nov 2022 08:44:34 GMT, Matthias Baesken wrote: >> This change adds constructors (String,Throwable) and (Throwable) to >> InvalidParameterException and uses them at a few places in the jdk coding. > > Matthias Baesken has updated the pull request incrementally with one > additional com

Re: RFR: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls

On Thu, 12 Jan 2023 14:29:34 GMT, Lutz Schmidt wrote: > This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a > message is ciphered in multiple, small (< 16 bytes) segments, the result is > incorrect. > > This is not just a band-aid fix. The issue was taken as a chance to >

Re: RFR: 8299817: [s390] AES-CTR mode intrinsic fails with multiple short update() calls [v4]

On Mon, 20 Feb 2023 12:21:27 GMT, Lutz Schmidt wrote: >> This PR addresses an issue in the AES-CTR mode intrinsic on s390. When a >> message is ciphered in multiple, small (< 16 bytes) segments, the result is >> incorrect. >> >> This is not just a band-aid fix. The issue was taken as a chance

Re: RFR: JDK-8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return

On Tue, 28 Feb 2023 15:17:19 GMT, Matthias Baesken wrote: > We have a (potential) early return in addCertificatesToKeystore in > KeystoreImpl.m . This is implemented by the CHECK_NULL macro. However this > missed a CFRelease call. LGTM. - Marked as reviewed by mdoerr (Reviewer).

Re: RFR: JDK-8303354: addCertificatesToKeystore in KeystoreImpl.m needs CFRelease call in early potential CHECK_NULL return [v2]

On Thu, 2 Mar 2023 09:47:56 GMT, Matthias Baesken wrote: >> We have a (potential) early return in addCertificatesToKeystore in >> KeystoreImpl.m . This is implemented by the CHECK_NULL macro. However this >> missed a CFRelease call. > > Matthias Baesken has updated the pull request incrementall

Re: RFR: JDK-8313764: Offer JVM HS functionality to shared lib load operations done by the JDK codebase

On Mon, 14 Aug 2023 07:48:00 GMT, Matthias Baesken wrote: > Currently there is a number of functionality that would be interesting to > have for shared lib load operations in the JDK C code. > Some examples : > Events::log_dll_message for hs-err files reporting > JFR event NativeLibraryLoad > Th