On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote:
> Before RC we need to update the man pages in the repo from their Markdown
> sources. All pages at a minimum have 23-ea replaced with 23, and publication
> year set to 2024 if needed.
>
> This also picks up the unpublished
On Fri, 19 Jul 2024 08:26:51 GMT, Alan Bateman wrote:
>> Before RC we need to update the man pages in the repo from their Markdown
>> sources. All pages at a minimum have 23-ea replaced with 23, and publication
>> year set to 2024 if needed.
>>
>> This also picks up the unpublished changes to
On Mon, 22 Jul 2024 21:40:15 GMT, Weijun Wang wrote:
> The test sets system properties. Should run in `othervm`.
Seems reasonable. I assume the actual conf file being written will be in the
test's scratch directory so no interference possible with other tests?
-
Marked as reviewed
On Sat, 24 Aug 2024 05:12:42 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Tue, 10 Sep 2024 11:07:30 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Tue, 10 Sep 2024 11:10:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Thu, 7 Jul 2022 20:43:09 GMT, Coleen Phillimore wrote:
> This change uses sed to change sun.hotspot.WhiteBox to
> jdk.test.whitebox.Whitebox, and sun/hotspot/Whitebox similarly. Due to
> indirect inclusions of some of the test libraries, changing a few wasn't a
> reliable option, and I nee
Please review these changes to the nroff manpage files so that they match their
markdown sources that Oracle maintains.
All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022
if needed. Additionally:
The Java manpage was missing updates from:
- [JDK-8282018](https://bugs
On Mon, 18 Jul 2022 15:26:23 GMT, Jonathan Gibbons wrote:
>> Please review these changes to the nroff manpage files so that they match
>> their markdown sources that Oracle maintains.
>>
>> All pages at a minimum have 19-ea replaced with 19, and copyright set to
>> 2022 if needed. Additionall
On Sun, 17 Jul 2022 22:44:02 GMT, David Holmes wrote:
> Please review these changes to the nroff manpage files so that they match
> their markdown sources that Oracle maintains.
>
> All pages at a minimum have 19-ea replaced with 19, and copyright set to 2022
> if needed
On Mon, 18 Jul 2022 23:27:58 GMT, David Holmes wrote:
>> src/java.base/share/man/keytool.1 line 456:
>>
>>> 454: \f[CB]PrivateKeyEntry\f[R] for the signer that already exists in the
>>> 455: keystore.
>>> 456: This option is used to sign the certificate
The version will be 20-ea and the copyright year 2023 (for March 2023 release
date).
Thanks.
-
Commit messages:
- 8290489: Initial nroff manpage generation for JDK 20
Changes: https://git.openjdk.org/jdk/pull/9581/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=9581&range=
On Thu, 21 Jul 2022 01:03:46 GMT, Daniel D. Daugherty
wrote:
>> The version will be 20-ea and the copyright year 2023 (for March 2023
>> release date).
>>
>> Thanks.
>
> Thumbs up. This is a trivial change.
Thanks @dcubed-ojdk !
-
PR: https://git.openjdk.org/jdk/pull/9581
On Thu, 21 Jul 2022 00:34:53 GMT, David Holmes wrote:
> The version will be 20-ea and the copyright year 2023 (for March 2023 release
> date).
>
> Thanks.
This pull request has now been integrated.
Changeset: e9f97b2e
Author:David Holmes
URL:
https://git.openjdk.or
Hi Patrick,
On 6/08/2022 7:05 pm, Patrick Pfeifer wrote:
On Mon, 18 Jul 2022 15:22:01 GMT, Jonathan Gibbons wrote:
Please review these changes to the nroff manpage files so that they match their
markdown sources that Oracle maintains.
Not a problem with this PR as such, but we still have a
Forward port JDK 19 -> JDK 20
-
Commit messages:
- Merge remote-tracking branch 'jdk19/master' into Merge_jdk19
- 8288769: Revert unintentional change to deflate.c
- 8291496: Allocating card table before heap causes underflow asserts in
CardTable::addr_for()
- 8290889: JDK 19 RDP
On Thu, 11 Aug 2022 00:06:35 GMT, David Holmes wrote:
> Forward port JDK 19 -> JDK 20
This pull request has now been integrated.
Changeset: 85a60235
Author: David Holmes
URL:
https://git.openjdk.org/jdk/commit/85a602355ff6e92bb468135d712e0b0b41753db4
Stats: 686 lines in 44
Now that Thread.stop has been degraded to throw `UnsupportedOperationException`
(JDK-8299610) the only direct source of async exceptions is from JVMTI
`StopThread`. We can remove the `JVM_StopThread` code, remove the `stillborn`
field from `java.lang.Thread` and its associated accesses from the
adGroup` - which also no longer
> ignores them so the mirroring behaviour remains the same).
>
> Testing: tiers 1-3
David Holmes has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 16 commits:
- Merge branch 'master' i
On Fri, 23 Sep 2022 06:17:34 GMT, David Holmes wrote:
> Now that Thread.stop has been degraded to throw
> `UnsupportedOperationException` (JDK-8299610) the only direct source of async
> exceptions is from JVMTI `StopThread`. We can remove the `JVM_StopThread`
> code, remove th
On Fri, 23 Sep 2022 18:21:30 GMT, Chris Plummer wrote:
>> David Holmes has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 16 commits:
>>
>> - Merge branch 'master' into 8293592-JVM_StopThread
>
On Mon, 10 Oct 2022 14:15:37 GMT, Julian Waters wrote:
> Some external libraries required by native code are linked via linker
> comments embedded in pragmas. Searching for which libraries are linked can
> then become frustrating and confusing since they may be included in an
> obscure place,
On Thu, 10 Nov 2022 06:20:41 GMT, Julian Waters wrote:
> After [JDK-8292008](https://bugs.openjdk.org/browse/JDK-8292008) and
> [JDK-8247283](https://bugs.openjdk.org/browse/JDK-8247283), some C and C++
> code across the JDK can be replaced and simplified with cleaner language
> features that
On Mon, 14 Nov 2022 01:17:38 GMT, Julian Waters wrote:
>> src/hotspot/os/windows/os_windows.hpp line 35:
>>
>>> 33: class Thread;
>>> 34:
>>> 35: static unsigned __stdcall thread_native_entry(Thread*);
>>
>> Why was this removed? This is needed to correctly specify the call sequence
>> for th
On Mon, 14 Nov 2022 01:39:17 GMT, Julian Waters wrote:
>> src/hotspot/share/utilities/debug.hpp line 172:
>>
>>> 170: int status, const char* detail);
>>> 171: ATTRIBUTE_PRINTF(4, 5)
>>> 172: void report_fatal(VMErrorType error_type, const char* file, int line,
>>> c
On Thu, 17 Nov 2022 22:23:53 GMT, Jonathan Gibbons wrote:
> Please review an update for the troff man pages, following the recent update
> to upgrade to use pandoc 2.19.2
> (See https://bugs.openjdk.org/browse/JDK-8297165)
>
> In conjunction with this, one javadoc test also needs to be updated,
On Thu, 17 Nov 2022 22:23:53 GMT, Jonathan Gibbons wrote:
> Please review an update for the troff man pages, following the recent update
> to upgrade to use pandoc 2.19.2
> (See https://bugs.openjdk.org/browse/JDK-8297165)
>
> In conjunction with this, one javadoc test also needs to be updated,
On Thu, 17 Nov 2022 20:42:27 GMT, Volodymyr Paprotski wrote:
>> Handcrafted x86_64 asm for Poly1305. Main optimization is to process 16
>> message blocks at a time. For more details, left a lot of comments in
>> `macroAssembler_x86_poly.cpp`.
>>
>> - Added new KAT test for Poly1305 and a fuzz
On Tue, 29 Nov 2022 17:07:02 GMT, Julian Waters wrote:
>> Digging into this some more, the friend declaration exists to provide access
>> to the private `os::win32::enum Ept`.
>>
>> One obvious and cheap solution to that would be to make that enum public. I
>> think that would be an improveme
On Fri, 6 Jan 2023 02:20:53 GMT, Archie L. Cobbs wrote:
> This PR adds a new lint warning category `this-escape`.
>
> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
> allow the JDK to continue to compile with `-Xlint:all`.
>
> A 'this' escape warning is generated f
There was one missing update in javac.1 from:
[JDK-8245246](https://bugs.openjdk.org/browse/JDK-8245246): Deprecate -profile
option in javac
otherwise the change is limited to dropping the "-ea".
Thanks.
-
Commit messages:
- Merge branch 'master' into 8290919-manpages
- 8290919:
On Mon, 23 Jan 2023 07:15:08 GMT, Iris Clark wrote:
>> There was one missing update in javac.1 from:
>>
>> [JDK-8245246](https://bugs.openjdk.org/browse/JDK-8245246): Deprecate
>> -profile option in javac
>>
>> otherwise the change is limited to dropping the "-ea".
>>
>> Thanks.
>
> Marked as
On Mon, 23 Jan 2023 02:59:42 GMT, David Holmes wrote:
> There was one missing update in javac.1 from:
>
> [JDK-8245246](https://bugs.openjdk.org/browse/JDK-8245246): Deprecate
> -profile option in javac
>
> otherwise the change is limited to dropping the "-ea".
>
Please review this simple update to the manpage to set the version to 21-ea.
This change also corrects a typo in javac.1 that was manually introduced by
JDK-8300591
Thanks.
-
Commit messages:
- 8290918: Initial nroff manpage generation for JDK 21
Changes: https://git.openjdk.org/
On Mon, 23 Jan 2023 23:24:06 GMT, Lance Andersen wrote:
>> Please review this simple update to the manpage to set the version to 21-ea.
>>
>> This change also corrects a typo in javac.1 that was manually introduced by
>> JDK-8300591
>>
>> Thanks.
>
> Marked as reviewed by lancea (Reviewer).
T
On Tue, 24 Jan 2023 01:28:53 GMT, Iris Clark wrote:
>> Please review this simple update to the manpage to set the version to 21-ea.
>>
>> This change also corrects a typo in javac.1 that was manually introduced by
>> JDK-8300591
>>
>> Thanks.
>
> Marked as reviewed by iris (Reviewer).
Thanks
On Tue, 24 Jan 2023 05:54:44 GMT, Joe Darcy wrote:
>> Please review this simple update to the manpage to set the version to 21-ea.
>>
>> This change also corrects a typo in javac.1 that was manually introduced by
>> JDK-8300591
>>
>> Thanks.
>
> Marked as reviewed by darcy (Reviewer).
Thanks
On Mon, 23 Jan 2023 22:59:22 GMT, David Holmes wrote:
> Please review this simple update to the manpage to set the version to 21-ea.
>
> This change also corrects a typo in javac.1 that was manually introduced by
> JDK-8300591
>
> Thanks.
This pull request has now been inte
On Thu, 4 May 2023 15:50:02 GMT, Adam Sotona wrote:
> Most of the manpages were updated a few years ago but some references remain.
> This patch renames remaining references to "macOS".
>
> Please review.
>
> Thanks,
> Adam
Looks good.
-
Marked as reviewed by dholmes (Reviewer).
Updated the version to 22-ea and year to 2024.
The following unpublished changes will also be included in this update:
- [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
contains a special character
- [JDK-8303928](https://bugs.openjdk.org/browse/JDK-8303928): Update ja
On Wed, 14 Jun 2023 06:08:59 GMT, Alan Bateman wrote:
>> Updated the version to 22-ea and year to 2024.
>>
>> The following unpublished changes will also be included in this update:
>> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool
>> manpage contains a special character
On Wed, 14 Jun 2023 19:21:01 GMT, Archie Cobbs wrote:
> Just curious, since you have access to the secret closed sources, can you not
> backport these changes yourself? Instead of just deleting them and expecting
> someone else to rescue them from oblivion?
@archiecobbs we (Oracle) will take
On Wed, 14 Jun 2023 09:25:14 GMT, Serguei Spitsyn wrote:
>> Updated the version to 22-ea and year to 2024.
>>
>> The following unpublished changes will also be included in this update:
>> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool
>> manpage contains a special charact
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> Updated the version to 22-ea and year to 2024.
>
> The following unpublished changes will also be included in this update:
> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
> contains a sp
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> Updated the version to 22-ea and year to 2024.
>
> The following unpublished changes will also be included in this update:
> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
> contains a sp
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> Updated the version to 22-ea and year to 2024.
>
> The following unpublished changes will also be included in this update:
> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
> contains a sp
code
> - [JDK-8015831](https://bugs.openjdk.org/browse/JDK-8015831): Add lint check
> for calling overridable methods from a constructor
>
> Thanks.
David Holmes has updated the pull request incrementally with one additional
commit since the last revision:
Pick up javac and jshell chan
On Wed, 14 Jun 2023 04:53:58 GMT, David Holmes wrote:
> Updated the version to 22-ea and year to 2024.
>
> The following unpublished changes will also be included in this update:
> - [JDK-8290626](https://bugs.openjdk.org/browse/JDK-8290626): keytool manpage
> contains a sp
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote:
> Microsoft, your C "conformance" is garbage
https://learn.microsoft.com/en-us/cpp/standard-library/cstdalign?view=msvc-170
-
PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606567568
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote:
> Build failure after JDK- 8305341
How was the original change tested? How was this change tested?
-
PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606571300
On Mon, 26 Jun 2023 04:23:58 GMT, Julian Waters wrote:
> as is evident in the tests for this PR
You mean the GHA builds? They don't seem to be building the failing
`jdk.jdwp.agent-static-libs` target.
-
PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606573575
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote:
> Build failure after JDK- 8305341
Okay I have it running through our tier1 builds at the moment. If that passes I
will approve the PR. Thanks
-
PR Comment: https://git.openjdk.org/jdk/pull/14645#issuecomment-1606580347
On Mon, 26 Jun 2023 02:30:06 GMT, Julian Waters wrote:
> Build failure after JDK- 8305341
Our tier 1 builds have passed.
Thanks
-
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/14645#pullrequestreview-1497595990
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Wed, 28 Jun 2023 16:54:51 GMT, Leo Korinth wrote:
> Remove trailing "blank" lines in source files.
>
> I like to use global-whitespace-cleanup-mode, but I can not use it if the
> files are "dirty" to begin with. This fix will make more files "clean". I
> also considered adding a check for t
On Thu, 29 Jun 2023 13:05:58 GMT, Leo Korinth wrote:
> My changes look like this in the diff output
> ```
> }
> -
> ```
Thanks for showing this and other output. To me this looked like the final
newline had been removed. I would have expected to see something that more
obviously showed more
Main changes are to use 21 instead of 21-ea. In addition the following files
contain additional updates from the closed sources:
- src/java.base/share/man/java.1
[JDK-8273131](https://bugs.openjdk.org/browse/JDK-8273131): Update the java
manpage markdown source for JFR filename expansion
[JDK
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote:
> Main changes are to use 21 instead of 21-ea. In addition the following files
> contain additional updates from the closed sources:
>
> - src/java.base/share/man/java.1
>
> [JDK-8273131](https://bugs.openjdk.org/
On Mon, 31 Jul 2023 08:33:07 GMT, David Holmes wrote:
> Main changes are to use 21 instead of 21-ea. In addition the following files
> contain additional updates from the closed sources:
>
> - src/java.base/share/man/java.1
>
> [JDK-8273131](https://bugs.openjdk.org/
On Mon, 7 Aug 2023 06:37:21 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
On Mon, 7 Aug 2023 06:42:41 GMT, Julian Waters wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as
>> was requested by the now backed out
>> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). It can be done
>> with some effort, given that the signific
On Tue, 1 Aug 2023 08:16:41 GMT, Julian Waters wrote:
>> src/hotspot/share/memory/allocation.cpp line 114:
>>
>>> 112: //
>>> 113:
>>> 114: void* AnyObj::operator new(size_t size, Arena *arena) {
>>
>> Please remind us what the issue is with `throw()` as this is a change to
>> shared code and
On Tue, 8 Aug 2023 19:52:08 GMT, Thomas Stuefe wrote:
>> I just checked and the value of the sentinel is ultimately the prvalue 88. I
>> don't know if we'd want to replace all the weird char usages here with
>> explicit values of 0 (and 88 for the sentinel). Maybe future reviews can
>> help wi
On Wed, 23 Aug 2023 15:18:03 GMT, Matthias Baesken wrote:
>> Currently there is a number of functionality that would be interesting to
>> have for shared lib load operations in the JDK C code.
>> Some examples :
>> Events::log_dll_message for hs-err files reporting
>> JFR event NativeLibraryLoad
On Mon, 28 Aug 2023 15:54:08 GMT, Leo Korinth wrote:
> Rename createJavaProcessBuilder so that it is not used by mistake instead of
> createTestJvm.
>
> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
> -i -e
> "s/createJavaProcessBuilder(/createJavaProcessBuilderI
On Tue, 29 Aug 2023 16:45:12 GMT, Roger Riggs wrote:
>> I don't think this is the best change across so many files.
>> It gives a very ugly name to a common test function and affects a very large
>> number of tests.
>
>> @RogerRiggs If it is only the name you want changed, maybe you can offer a
On Wed, 30 Aug 2023 11:31:20 GMT, Mark Sheppard wrote:
> So you could create a single createJavaProcessBuilder with add an additional
> parameter boolean addTestOpts e.g.
createJavaProcessBuilder(List command, boolean addTestOpts) { ... }
@msheppar that is actually where we started, and it was
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Mon, 16 Oct 2023 15:04:51 GMT, Matthias Baesken wrote:
>> Matthias Baesken has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> windows aarch64 build issues
>
> Hello, any comments about the idea of calling into 'os::dll_load' instead ?
>
On Tue, 7 Nov 2023 11:11:31 GMT, Erik Gahlin wrote:
>> Could I have a review of a PR that removes the bytecode instrumentation for
>> the exception events.
>>
>> Testing: jdk/jdk/jfr + tier1 + tier2
>
> Erik Gahlin has updated the pull request incrementally with one additional
> commit since t
Updated the version to 23-ea and year to 2024.
This initial generation also picks up the unpublished changes from:
- [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
jarsigner)
- [JDK-8290702](https://bugs.openjdk.org/browse/JDK-8290702) (javadoc) (JDK 23
backport)
- [JDK-8
On Thu, 14 Dec 2023 09:17:05 GMT, Pavel Rappo wrote:
> Thanks for doing this, David. I only note that the changes for JDK-8321384
> were published in [JDK-8308715](https://bugs.openjdk.org/browse/JDK-8308715),
> which was integrated in the mainline before JDK 22 RDP 1. So they are already
> pr
On Thu, 14 Dec 2023 09:01:17 GMT, Alan Bateman wrote:
> Initially I wondered if JDK-8309981 should be separated but include keeps
> things in sync so I think okay.
Thanks for the review @AlanBateman .
Yeah I was in two minds there myself. I started fixing
[JDK-8309981](https://bugs.openjdk.or
702) (javadoc) (JDK
> 23 backport)
>
> Thanks
David Holmes has updated the pull request incrementally with one additional
commit since the last revision:
Revert "8309981: Remove expired flags in JDK 23"
This reverts commit 0324a90e936ae01e42ae099e7235156326cc3
On Thu, 14 Dec 2023 05:46:01 GMT, David Holmes wrote:
> Updated the version to 23-ea and year to 2024.
>
> This initial generation also picks up the unpublished changes from:
>
> - [JDK-8302233](https://bugs.openjdk.org/browse/JDK-8302233) (keytool &
> jarsigner)
&
This update drops the "ea" from the version string.
We also propagate the following fixes from the markdown sources to the troff
manpage file:
JDK-8322478: Update java manpage for multi-file source-code launcher
JDK-8302233: HSS/LMS: keytool and jarsigner changes
JDK-8318971: Better Error Handli
On Mon, 5 Feb 2024 21:58:23 GMT, Joe Darcy wrote:
>> This update drops the "ea" from the version string.
>>
>> We also propagate the following fixes from the markdown sources to the troff
>> manpage file:
>>
>> JDK-8322478: Update java manpage for multi-file source-code launcher
>> JDK-8302233
On Sun, 4 Feb 2024 22:43:28 GMT, David Holmes wrote:
> This update drops the "ea" from the version string.
>
> We also propagate the following fixes from the markdown sources to the troff
> manpage file:
>
> JDK-8322478: Update java manpage for multi-file source
On Tue, 7 May 2024 11:53:19 GMT, Pavel Rappo wrote:
> Please review this mechanical change to man pages. This PR should be
> integrated after https://github.com/openjdk/jdk/pull/18787.
I think we may have to restore this to a standalone start-of-release change
done after the other start-of-rel
On Tue, 14 May 2024 18:10:28 GMT, Maurizio Cimadamore
wrote:
>> This PR implements [JEP 472](https://openjdk.org/jeps/472), by restricting
>> the use of JNI in the following ways:
>>
>> * `System::load` and `System::loadLibrary` are now restricted methods
>> * `Runtime::load` and `Runtime::loa
On Mon, 13 May 2024 15:32:27 GMT, Alan Bateman wrote:
>> Maurizio Cimadamore has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Fix another typo
>> - Fix typo
>> - Add more comments
>
> src/hotspot/share/runtime/arguments.cpp line 227
Sets the version to 24/24-ea and the copyright year to 2025.
Content changes related to the start of release (e.g. for removed options in
java.1) are handled separately.
This initial generation also picks up the unpublished changes from:
- JDK-8330807: Update Manpage for obsoletion of Scavenge
On Mon, 10 Jun 2024 07:15:51 GMT, Alan Bateman wrote:
>> Sets the version to 24/24-ea and the copyright year to 2025.
>>
>> Content changes related to the start of release (e.g. for removed options in
>> java.1) are handled separately.
>>
>> This initial generation also picks up the unpublishe
0807: Update Manpage for obsoletion of ScavengeBeforeFullGC
> - JDK-8284500: Typo in Supported Named Extensions - BasicContraints
> - JDK-8324342: Doclet should default `@since` for a nested class to that of
> its enclosing class
>
> Thanks
David Holmes has updated the pull request with
0807: Update Manpage for obsoletion of ScavengeBeforeFullGC
> - JDK-8284500: Typo in Supported Named Extensions - BasicContraints
> - JDK-8324342: Doclet should default `@since` for a nested class to that of
> its enclosing class
>
> Thanks
David Holmes has updated the pull request in
On Mon, 10 Jun 2024 17:27:18 GMT, Iris Clark wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Regenerated after merge
>
> Marked as reviewed by iris (Reviewer).
Thanks for the revie
On Mon, 10 Jun 2024 02:31:00 GMT, David Holmes wrote:
> Sets the version to 24/24-ea and the copyright year to 2025.
>
> Content changes related to the start of release (e.g. for removed options in
> java.1) are handled separately.
>
> This initial generation also picks
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote:
> Before RC we need to update the man pages in the repo from their Markdown
> sources. All pages at a minimum have 23-ea replaced with 23, and publication
> year set to 2024 if needed.
>
> This also picks up the unpublished
Before RC we need to update the man pages in the repo from their Markdown
sources. All pages at a minimum have 23-ea replaced with 23, and publication
year set to 2024 if needed.
This also picks up the unpublished changes to java.1 from:
- [JDK-8324836](https://bugs.openjdk.org/browse/JDK-83248
On Mon, 21 Oct 2024 14:34:30 GMT, Julian Waters wrote:
> and whatever team is responsible for HotSpot debugging.
I don't see anything hotspot related here.
I think you would be better off splitting this up into distinct issues and PRs
for different areas. I expect the client team in particular
On Tue, 22 Oct 2024 01:43:50 GMT, Julian Waters wrote:
> Aren't the dt_shmem and jdwp changes related to HotSpot?
Nope. That's core-svc - the non-hotspot side of serviceability. :)
-
PR Comment: https://git.openjdk.org/jdk/pull/21616#issuecomment-2428793636
On Tue, 12 Nov 2024 01:25:16 GMT, Shaojin Wen wrote:
> This PR is a resubmission after PR #21593 was rolled back, and the unsafe
> offset overflow issue has been fixed.
>
> Move getChars methods of StringLatin1 and StringUTF16 to DecimalDigits to
> reduce duplication
>
> HexDigits and OctalDi
On Thu, 31 Oct 2024 19:07:42 GMT, Chris Plummer wrote:
> I do wonder if mutex support can be implemented for Windows with
> Acquire/ReleaseSRWLockExclusive.
A `CriticalSection` is a mutex. A RWLock is not a "mutex".
-
PR Comment: https://git.openjdk.org/jdk/pull/21616#issuecommen
On Thu, 24 Oct 2024 03:33:51 GMT, Julian Waters wrote:
> the way I did it I'd have to force push
That should not be the case. You can just anti-delta changes.
-
PR Comment: https://git.openjdk.org/jdk/pull/21616#issuecomment-2434475849
On Mon, 18 Nov 2024 12:39:32 GMT, Coleen Phillimore wrote:
>> I don't see any difference in the callers in relation to this PR and the
>> function is not presently declared `extern`. ??
>
> There was an extern trace_class_resolution() function that called this _impl
> function that I removed, s
On Fri, 15 Nov 2024 12:04:37 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/prims/jvm.cpp line 154:
>>
>>> 152: */
>>> 153:
>>> 154: extern void trace_class_resolution(Klass* to_class) {
>>
>> why `extern` ?
>
> jni.cpp functions call this.
I don't see any difference in the callers in rel
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Thu, 14 Nov 2024 11:11:54 GMT, Magnus Ihse Bursie wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in te
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote:
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms o
1 - 100 of 115 matches
Mail list logo
