Re: RFR: 8358451: SunJCE PBEKey impl should throw IllegalStateException when getEncoded() is called [v3]

2025-07-14 Thread Valerie Peng
On Thu, 10 Jul 2025 14:21:40 GMT, Sean Mullan wrote: >> Valerie Peng has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Change "key" to "Key" in exception messages. > > src/java.base/share/classes/javax/crypto/SecretKeyFactory.java line 375

Re: RFR: 8356557: Update CodeSource::implies API documentation and deprecate java.net.SocketPermission class for removal [v2]

2025-07-14 Thread Sean Mullan
> `SocketPermission` should be deprecated for removal as has already been done > for many other `Permission` subclasses. However, `CodeSource.implies()` has > specification dependencies on `SocketPermission` which requires additional > changes to decouple those dependencies. > > This change de

Re: RFR: 8350709: [JMH] test ProtectionDomainBench failed for 2 threads config

2025-07-14 Thread Mark Powers
On Mon, 14 Jul 2025 19:25:38 GMT, Mark Powers wrote: > [JDK-8350709](https://bugs.openjdk.org/browse/JDK-8350709) Tested with 10 threads. A one thread benchmark now measures about 10 percent worse than before this change. With 10 threads, the benchmark is much faster than with 1 thead. Totally

RFR: 8356557: Update CodeSource::implies API documentation and deprecate java.net.SocketPermission class for removal

2025-07-14 Thread Sean Mullan
`SocketPermission` should be deprecated for removal as has already been done for many other `Permission` subclasses. However, `CodeSource.implies()` has specification dependencies on `SocketPermission` which requires additional changes to decouple those dependencies. This change deprecates `So

RFR: 8350709: [JMH] test ProtectionDomainBench failed for 2 threads config

2025-07-14 Thread Mark Powers
[JDK-8350709](https://bugs.openjdk.org/browse/JDK-8350709) - Commit messages: - second iteration - first iteration Changes: https://git.openjdk.org/jdk/pull/26301/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26301&range=00 Issue: https://bugs.openjdk.org/browse/JDK-83

RFR: 8361894: sun/security/krb5/config/native/TestDynamicStore.java ensure that the test is run with sudo

2025-07-14 Thread Mikhail Yankelevich
sun/security/krb5/config/native/TestDynamicStore.java is commonly run without sudo, which leads to the access related failure. Added a ui popup reminding to run the test with sudo, making instructions clearer and more noticeable - Commit messages: - JDK-8361894: sun/security/krb5/