Re: RFR: 8359956: Support algorithm constraints and certificate checks in SunX509 key manager [v9]

2025-06-20 Thread Sean Mullan
On Wed, 18 Jun 2025 21:35:47 GMT, Artur Barashev wrote: >> SunX509 key manager should support the same certificate checks that are >> supported by PKIX key manager. >> >> Effectively there should be only 2 differences between 2 key managers: >> - PKIX supports multiple key stores through KeySto

Re: RFR: 8359732: Make standard i/o encoding related system properties `StaticProperty` [v3]

2025-06-20 Thread Roger Riggs
On Wed, 18 Jun 2025 18:24:43 GMT, Naoto Sato wrote: >> Refactored the internal handling of `stdin/out/err.encoding` to allow >> setting them only via command-line options by converting them into >> `StaticProperty`. This change prevents unexpected behavior caused by >> applications modifying t

Withdrawn: 8272875: Change the default key manager to PKIX

2025-06-20 Thread Artur Barashev
On Fri, 18 Apr 2025 17:04:56 GMT, Artur Barashev wrote: > The current key manager is SunX509, which is configured in the java.security. > The SunX509 algorithm does not check the local certificate. The PKIX > algorithm should be preferred now so that the default key manager could be > more rob

Re: RFR: 8359956: Support algorithm constraints and certificate checks in SunX509 key manager [v9]

2025-06-20 Thread Sean Mullan
On Wed, 18 Jun 2025 21:35:47 GMT, Artur Barashev wrote: >> SunX509 key manager should support the same certificate checks that are >> supported by PKIX key manager. >> >> Effectively there should be only 2 differences between 2 key managers: >> - PKIX supports multiple key stores through KeySto

Re: RFR: 8359956: Support algorithm constraints and certificate checks in SunX509 key manager [v10]

2025-06-20 Thread Artur Barashev
> SunX509 key manager should support the same certificate checks that are > supported by PKIX key manager. > > Effectively there should be only 2 differences between 2 key managers: > - PKIX supports multiple key stores through KeyStore.Builder interface while > SunX509 supports only a single ke

Re: RFR: 8359732: Make standard i/o encoding related system properties `StaticProperty` [v3]

2025-06-20 Thread Naoto Sato
On Thu, 19 Jun 2025 11:03:43 GMT, Alan Bateman wrote: > Latest version looks okay but I think better to drop the change to > System.initPhase1. Reverted the changes in the `System` class. Also, there were two sites that used `StaticProperty` class outside the `java.base` module. I replaced the

Re: RFR: 8359956: Support algorithm constraints and certificate checks in SunX509 key manager [v9]

2025-06-20 Thread Artur Barashev
On Fri, 20 Jun 2025 13:58:24 GMT, Sean Mullan wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update system property name in one more test > > test/jdk/sun/security/mscapi/ShortRSAKeyWithinTLS.java line 238: > >

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v5]

2025-06-20 Thread Mikhail Yankelevich
> 8351566: Consolidate third party artifacts used in tests Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 10 commits: - Merge branch 'master' into JDK-8351566 - updated nss version - Merge branch 'master' into

Re: RFR: 8359732: Make standard i/o encoding related system properties `StaticProperty` [v4]

2025-06-20 Thread Naoto Sato
> Refactored the internal handling of `stdin/out/err.encoding` to allow setting > them only via command-line options by converting them into `StaticProperty`. > This change prevents unexpected behavior caused by applications modifying > these properties at runtime using `System.setProperty()`.

Re: RFR: 8351566: Consolidate third party artifacts used in tests [v4]

2025-06-20 Thread Mikhail Yankelevich
> 8351566: Consolidate third party artifacts used in tests Mikhail Yankelevich has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - Merge branch 'master' into JDK-8351566 - Fernando's comments: * cleanup - minor:

Re: RFR: 8359732: Make standard i/o encoding related system properties `StaticProperty` [v4]

2025-06-20 Thread Roger Riggs
On Fri, 20 Jun 2025 18:44:47 GMT, Naoto Sato wrote: >> Refactored the internal handling of `stdin/out/err.encoding` to allow >> setting them only via command-line options by converting them into >> `StaticProperty`. This change prevents unexpected behavior caused by >> applications modifying t

Re: RFR: 8359732: Make standard i/o encoding related system properties `StaticProperty` [v4]

2025-06-20 Thread Alan Bateman
On Fri, 20 Jun 2025 18:44:47 GMT, Naoto Sato wrote: >> Refactored the internal handling of `stdin/out/err.encoding` to allow >> setting them only via command-line options by converting them into >> `StaticProperty`. This change prevents unexpected behavior caused by >> applications modifying t