On Wed, 14 May 2025 14:23:31 GMT, Magnus Ihse Bursie wrote:
> I found a few other places in the code that can be cleaned up after the
> conversion to UTF-8.
This pull request has now been integrated.
Changeset: edf92721
Author:Magnus Ihse Bursie
URL:
https://git.openjdk.org/jdk/com
On Thu, 29 May 2025 19:06:15 GMT, Sean Coffey wrote:
> Removal of the `+thread` and `+timestamp` options that were used to control
> the logging behavior of output from the `java.security.debug` system property.
>
>
> To enhance the security debug logs, the thread and timestamp data should
>
> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding"
> throws NoSuchAlgorithmException.
> This patch restores the behavior by ensuring that empty mode or padding
> strings are interpreted as null.
>
> Testing done for : tier1 - fastdebug level (AIX)
>
> JBS: [JDK-8358159
> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding"
> throws NoSuchAlgorithmException.
> This patch restores the behavior by ensuring that empty mode or padding
> strings are interpreted as null.
>
> Testing done for : tier1 - fastdebug level (AIX)
>
> JBS: [JDK-8358159
On Fri, 23 May 2025 04:54:26 GMT, Koushik Muthukrishnan Thirupattur
wrote:
> Several classes in the `java.security` package lazily compute their hash
> value and store it in a field. These fields can typically be annotated with
> the `@Stable` annotation. Many of the current implementations ar
> The tests included in this PR add code coverage mainly to the following
> classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem,
> EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are
> included for RSAPSS, multithreading, _jdk.epkcs8.defaultAlgorithm_
On Wed, 4 Jun 2025 10:37:28 GMT, Varada M wrote:
>> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding"
>> throws NoSuchAlgorithmException.
>> This patch restores the behavior by ensuring that empty mode or padding
>> strings are interpreted as null.
>>
>> Testing done f
Update the `PBEKey` class of the SunJCE provider which override the
`javax.security.auth.Destroyable` interface to
1. throw `IllegalStateException` if `getEncoded()` is called after key is
destroyed
2. serialization of such destroyed `PBEKey` object will lead to exception.
Also update the `P
On Wed, 4 Jun 2025 10:37:28 GMT, Varada M wrote:
>> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding"
>> throws NoSuchAlgorithmException.
>> This patch restores the behavior by ensuring that empty mode or padding
>> strings are interpreted as null.
>>
>> Testing done f
Add more comment on why `KeyUtil::getKeySize` could return -1. Add a new method
`getNistCategory` to get the NIST security category.
-
Commit messages:
- the fix
Changes: https://git.openjdk.org/jdk/pull/25642/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25642&range=00
On Wed, 4 Jun 2025 03:10:29 GMT, Valerie Peng wrote:
> Update the `PBEKey` class of the SunJCE provider which override the
> `javax.security.auth.Destroyable` interface to
>
> 1. throw `IllegalStateException` if `getEncoded()` is called after key is
> destroyed
> 2. serialization of such dest
On Wed, 4 Jun 2025 03:10:29 GMT, Valerie Peng wrote:
> Update the `PBEKey` class of the SunJCE provider which override the
> `javax.security.auth.Destroyable` interface to
>
> 1. throw `IllegalStateException` if `getEncoded()` is called after key is
> destroyed
> 2. serialization of such dest
> Hi,
>
> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the HTTP
> Client API](https://openjdk.org/jeps/517).
>
> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the HTTP
> Client API](https://bugs.openjdk.org/browse/JDK-8350588)
>
> This JEP propose
On Wed, 4 Jun 2025 14:59:43 GMT, Weijun Wang wrote:
> Add more comment on why `KeyUtil::getKeySize` could return -1. Add a new
> method `getNistCategory` to get the NIST security category.
src/java.base/share/classes/sun/security/util/KeyUtil.java line 56:
> 54: * Traditionally, the key s
On Wed, 4 Jun 2025 14:59:43 GMT, Weijun Wang wrote:
> Add more comment on why `KeyUtil::getKeySize` could return -1. Add a new
> method `getNistCategory` to get the NIST security category.
src/java.base/share/classes/sun/security/util/KeyUtil.java line 62:
> 60: * each standardized parame
On Fri, 16 May 2025 10:26:11 GMT, Daniel Fuchs wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 422 commits:
>>
>> - merge latest changes from master branch
>> - Undo whitespace change
>> - Remove unnecess
> Add more comment on why `KeyUtil::getKeySize` could return -1. Add a new
> method `getNistCategory` to get the NIST security category.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
addressing Mark's comments
-
Change
> The tests included in this PR add code coverage mainly to the following
> classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem,
> EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are
> included for RSAPSS, multithreading, _jdk.epkcs8.defaultAlgorithm_
On Wed, 4 Jun 2025 16:08:31 GMT, Artur Barashev wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> addressing Mark's comments
>
> src/java.base/share/classes/sun/security/util/KeyUtil.java line 62:
>
>> 60: * eac
On Wed, 4 Jun 2025 13:39:50 GMT, Sean Mullan wrote:
> @valeriepeng Can you also review this? Thanks.
Yes, I have started looking at it. Was about to ask for a regression test, and
you beat me to it.
-
PR Comment: https://git.openjdk.org/jdk/pull/25547#issuecomment-2940866076
On Wed, 4 Jun 2025 16:50:41 GMT, Weijun Wang wrote:
>> src/java.base/share/classes/sun/security/util/KeyUtil.java line 62:
>>
>>> 60: * each standardized parameter set. For example, ML-KEM-768 is
>>> assigned to
>>> 61: * category 3, and ML-DSA-87 to category 5.
>>> 62: *
>>
>>
On Wed, 4 Jun 2025 10:37:28 GMT, Varada M wrote:
>> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding"
>> throws NoSuchAlgorithmException.
>> This patch restores the behavior by ensuring that empty mode or padding
>> strings are interpreted as null.
>>
>> Testing done f
On Wed, 4 Jun 2025 15:46:36 GMT, Daniel Fuchs wrote:
>> Hi,
>>
>> Please find here a PR for the implementation of [JEP 517: HTTP/3 for the
>> HTTP Client API](https://openjdk.org/jeps/517).
>>
>> The CSR can be viewed at [JDK-8350588: Implement JEP 517: HTTP/3 for the
>> HTTP Client API](http
On Thu, 22 May 2025 23:03:47 GMT, Matthew Donovan wrote:
> In this PR, I updated the jarsigner compatibility test to handle minor
> differences in the output of jarsigner between versions.
Marked as reviewed by rhalade (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/2540
On Thu, 22 May 2025 23:03:47 GMT, Matthew Donovan wrote:
> In this PR, I updated the jarsigner compatibility test to handle minor
> differences in the output of jarsigner between versions.
This pull request has now been integrated.
Changeset: 5ed246d1
Author:Matthew Donovan
URL:
ht
On Wed, 4 Jun 2025 10:37:28 GMT, Varada M wrote:
>> Omitting the mode/padding in a transformation string eg: "AES/ /NoPadding"
>> throws NoSuchAlgorithmException.
>> This patch restores the behavior by ensuring that empty mode or padding
>> strings are interpreted as null.
>>
>> Testing done f
On Wed, 4 Jun 2025 18:06:33 GMT, Valerie Peng wrote:
>> Varada M has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> whitespace error fix
>
> src/java.base/share/classes/javax/crypto/Cipher.java line 393:
>
>> 391: this.suffix =
On Fri, 30 May 2025 18:19:13 GMT, Koushik Muthukrishnan Thirupattur
wrote:
>> Check Digest-MD5 utilities SecureRandom Usage and update random usage with
>> secure random
>
> Koushik Muthukrishnan Thirupattur has updated the pull request with a new
> target base due to a merge or a rebase. The
On Tue, 3 Jun 2025 16:24:44 GMT, Sean Mullan wrote:
>> Anthony Scarpino has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments
>
> src/java.base/share/classes/java/security/PEMDecoder.java line 127:
>
>> 125: * @implNote An implement
> Hi, I need a review of some PEM updates. `PEMRecord.pem` is renamed to
> `content` to better describe that it is the base64 content and not including
> the header and footer. Additionally, `PEMRecord.getEncoded()` is removed and
> some javadoc clarifications for PEMEncoder and PEMDecoder. Th
> Add more comment on why `KeyUtil::getKeySize` could return -1. Add a new
> method `getNistCategory` to get the NIST security category.
Weijun Wang has updated the pull request incrementally with one additional
commit since the last revision:
enhance test to be exhaustive
-
Cha
On Wed, 4 Jun 2025 16:49:11 GMT, Fernando Guallini
wrote:
>> The tests included in this PR add code coverage mainly to the following
>> classes introduced/updated by JEP 470 (PEM): PEMDecoder, PEMEncoder, Pem,
>> EncryptedPrivateKeyInfo and the Key factories. In addition, more tests are
>> in
32 matches
Mail list logo
