Re: RFR: 8298420: PEM API: Implementation (Preview) [v16]

2025-05-11 Thread Anthony Scarpino
On Fri, 9 May 2025 15:13:29 GMT, Sean Mullan wrote: >> Anthony Scarpino has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - comments >> - toString update >> - non-sealed >>Better X509 KeyPair parsing > > src/java.base/share/classes

Re: RFR: 8298420: PEM API: Implementation (Preview) [v15]

2025-05-11 Thread Anthony Scarpino
On Thu, 8 May 2025 16:12:07 GMT, Weijun Wang wrote: >> Anthony Scarpino has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 66 commits: >> >> - major code review comments update >> - Merge branch 'master' into pem >> - Merge branch

Re: RFR: 8298420: PEM API: Implementation (Preview) [v17]

2025-05-11 Thread Anthony Scarpino
On Fri, 9 May 2025 17:57:30 GMT, Weijun Wang wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> comments on the 11th > > src/java.base/share/classes/java/security/PEMRecord.java line 87: > >> 85: */ >> 86:

Re: RFR: 8298420: PEM API: Implementation (Preview) [v17]

2025-05-11 Thread Anthony Scarpino
> Hi all, > > I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a format > for encoding and decoding cryptographic keys and certificates. It will be > integrated into JDK24 as a Preview Feature. Preview features does not > permanently define the API and it is subject to cha

Re: RFR: 8298420: PEM API: Implementation (Preview) [v15]

2025-05-11 Thread Anthony Scarpino
On Fri, 9 May 2025 15:26:42 GMT, Sean Mullan wrote: >> I split them and reworded it, HTH. > > What I was suggesting was to have an additional sentence first describing > what each of these methods is for. I'll suggest something later. ok - PR Review Comment: https://git.openjdk.or

Re: RFR: 8298420: PEM API: Implementation (Preview) [v16]

2025-05-11 Thread Anthony Scarpino
On Fri, 9 May 2025 18:06:10 GMT, Weijun Wang wrote: >> Anthony Scarpino has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - comments >> - toString update >> - non-sealed >>Better X509 KeyPair parsing > > src/java.base/share/classes