Re: RFR: 8354305: SHAKE128 and SHAKE256 MessageDigest algorithms [v3]

2025-04-28 Thread Valerie Peng
On Mon, 28 Apr 2025 14:48:34 GMT, Weijun Wang wrote: >> Add 2 `MessageDigest` algorithms. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > test alias usage (I thought I clicked the "comment" botton last Friday, not sure what

Re: RFR: 8352728: InternalError loading java.security due to Windows parent folder permissions [v2]

2025-04-28 Thread Francisco Ferrari Bihurriet
On Thu, 17 Apr 2025 04:26:38 GMT, Martin Balao wrote: >> Francisco Ferrari Bihurriet has updated the pull request with a new target >> base due to a merge or a rebase. The incremental webrev excludes the >> unrelated changes brought in by the merge/rebase. The pull request contains >> three ad

Re: RFR: 8298420: PEM API: Implementation (Preview) [v14]

2025-04-28 Thread Weijun Wang
On Sun, 27 Apr 2025 22:18:13 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/java/security/PEMEncoder.java line 287: >> >>> 285: keySpec = null; >>> 286: } catch (GeneralSecurityException e) { >>> 287: throw new SecurityExcepti

Re: RFR: 8298420: PEM API: Implementation (Preview) [v14]

2025-04-28 Thread Weijun Wang
On Sun, 27 Apr 2025 22:20:32 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/java/security/PEMEncoder.java line 300: >> >>> 298: // If `key` is non-null, this is an encoder ready to encrypt. >>> 299: if (key != null) { >>> 300: if (privateBytes == null ||

Re: RFR: 8298420: PEM API: Implementation (Preview) [v14]

2025-04-28 Thread Weijun Wang
On Sun, 27 Apr 2025 21:33:06 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/java/security/PEMEncoder.java line 134: >> >>> 132: private String pemEncoded(PEMRecord pem) { >>> 133: StringBuilder sb = new StringBuilder(1024); >>> 134: sb.append("-BEGIN ").appe

Re: RFR: 8298420: PEM API: Implementation (Preview) [v14]

2025-04-28 Thread Weijun Wang
On Sun, 27 Apr 2025 22:11:57 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/java/security/PEMEncoder.java line 279: >> >>> 277: if (keySpec != null) { >>> 278: // For thread safety >>> 279: lock.lock(); >> >> How much does this lock buy? If someone

Re: RFR: 8298420: PEM API: Implementation (Preview) [v14]

2025-04-28 Thread Weijun Wang
On Sun, 27 Apr 2025 18:36:28 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/java/security/PEMDecoder.java line 60: >> >>> 58: * A specified return class must implement {@link DEREncodable} and be >>> an >>> 59: * appropriate JCE object class for the PEM; otherwise an >>> 60: *

Re: RFR: 8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension [v2]

2025-04-28 Thread Artur Barashev
> Per TLSv1.3 RFC: > > >If no "signature_algorithms_cert" extension is >present, then the "signature_algorithms" extension also applies to >signatures appearing in certificates. > > > When no "signature_algorithms_cert" extension is present in ClientHello we > simply copy "signatur

Re: RFR: 8354305: SHAKE128 and SHAKE256 MessageDigest algorithms [v3]

2025-04-28 Thread Valerie Peng
On Mon, 28 Apr 2025 18:08:22 GMT, Weijun Wang wrote: > I mainly don't like the current [hardcoded > branches](https://github.com/openjdk/jdk/blob/c54fc08aa3c63e4b26dc5edb2436844dfd3bab7c/src/java.base/share/classes/sun/security/pkcs/PKCS7.java#L754) > (and [this > one](https://github.com/openj

RFR: 8355779: When no "signature_algorithms_cert" extension is present we do not apply certificate scope constraints to algorithms in "signature_algorithms" extension

2025-04-28 Thread Artur Barashev
Per TLSv1.3 RFC: If no "signature_algorithms_cert" extension is present, then the "signature_algorithms" extension also applies to signatures appearing in certificates. When no "signature_algorithms_cert" extension is present in ClientHello we simply copy "signature_algorithms" extens

Re: RFR: 8350498: Remove two Camerfirma root CA certificates

2025-04-28 Thread Mark Powers
On Tue, 22 Apr 2025 20:27:04 GMT, Rajan Halade wrote: > The change is to remove two Camerfirma root certificates which are terminated > and no longer in use. These two roots are removed from `cacerts` truststore. > Distrust of these roots is also removed as these roots will no longer be > trus

Re: RFR: 8354305: SHAKE128 and SHAKE256 MessageDigest algorithms [v3]

2025-04-28 Thread Valerie Peng
On Mon, 28 Apr 2025 14:48:34 GMT, Weijun Wang wrote: >> Add 2 `MessageDigest` algorithms. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > test alias usage Changes look fine. However, we should probably caution about these b

[Bug] NPE thrown from SASL GSSAPI impl on Java 11+ when TLS is used with QOP auth-int against Active Directory

2025-04-28 Thread Osipov, Michael (IN IT IN)
Hi folks, Hi Max, please assess the following bug I have found in Java 11+, it does not exist in Java 8. I have tried the following most versions on Azul Zulu/ OpenJDK: 8, 11, 17, 21, 24 on multiple platforms. Searched JBS as well, nothing found. Consider the following code: public static void

Re: RFR: 8354305: SHAKE128 and SHAKE256 MessageDigest algorithms

2025-04-28 Thread Ferenc Rakoczi
On Thu, 10 Apr 2025 15:30:28 GMT, Weijun Wang wrote: > Add 2 `MessageDigest` algorithms. I strongly support the names "SHAKE128-256" and "SHAKE256-512". - PR Comment: https://git.openjdk.org/jdk/pull/24576#issuecomment-2834807368

Re: RFR: 8354305: SHAKE128 and SHAKE256 MessageDigest algorithms [v2]

2025-04-28 Thread Weijun Wang
> Add 2 `MessageDigest` algorithms. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: new algorithm names - Changes: - all: https://git.openjdk.org/jdk/pull/24576/files - new: https://git.openjdk.org/jdk/pull/24576/file

Re: RFR: 8354305: SHAKE128 and SHAKE256 MessageDigest algorithms

2025-04-28 Thread Weijun Wang
On Thu, 10 Apr 2025 15:30:28 GMT, Weijun Wang wrote: > Add 2 `MessageDigest` algorithms. I updated the names. I also changed the names in `KnownOID`. According to https://csrc.nist.gov/Projects/Computer-Security-Objects-Register/Algorithm-Registration#Hash, these OIDs are assigned to "Secure H

Re: RFR: 8354305: SHAKE128 and SHAKE256 MessageDigest algorithms [v3]

2025-04-28 Thread Weijun Wang
> Add 2 `MessageDigest` algorithms. Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: test alias usage - Changes: - all: https://git.openjdk.org/jdk/pull/24576/files - new: https://git.openjdk.org/jdk/pull/24576/files/4

Re: RFR: 8348986: Improve coverage of enhanced exception messages [v8]

2025-04-28 Thread Alan Bateman
On Fri, 25 Apr 2025 14:26:43 GMT, Michael McMahon wrote: >> Hi, >> >> Enhanced exception messages are designed to hide sensitive information such >> as hostnames, IP >> addresses from exception message strings, unless the enhanced mode for the >> specific category >> has been explicitly enab

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API [v2]

2025-04-28 Thread Sean Mullan
On Wed, 23 Apr 2025 13:07:31 GMT, Artur Barashev wrote: >> A lot of (existing) HttpClient tests in `test/jdk/java/net/httpclient` >> currently use this `SimpleSSLContext` construct to read the `testkeys` >> keystore that's available in the JDK repo's test directory. Moving to a >> dynamically

Re: RFR: 8349910: Implement HTTP/3 for the HTTP Client API [v2]

2025-04-28 Thread Sean Mullan
On Thu, 24 Apr 2025 16:59:45 GMT, Daniel Fuchs wrote: >> Hi, >> >> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for >> the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976). >> >> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Clien

New candidate JEP: 470: PEM Encodings of Cryptographic Objects (Preview)

2025-04-28 Thread Mark Reinhold
https://openjdk.org/jeps/470 Summary: Introduce an API for encoding objects that represent cryptographic keys, certificates, and certificate revocation lists into the widely-used Privacy-Enhanced Mail (PEM) transport format, and for decoding from that format back into objects. This is a p

Re: RFR: 8298420: PEM API: Implementation (Preview) [v14]

2025-04-28 Thread Weijun Wang
On Mon, 28 Apr 2025 03:44:43 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line >> 416: >> >>> 414: * {@link PrivateKey} using the {@code encKey} and given >>> parameters. >>> 415: * >>> 416: * If {@code algorithm} is {@co

Re: RFR: 8298420: PEM API: Implementation (Preview) [v14]

2025-04-28 Thread Weijun Wang
On Sat, 26 Apr 2025 07:57:42 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/java/security/PEMRecord.java line 135: >> >>> 133: /** >>> 134: * Returns the binary encoding from the Base64 data contained in >>> 135: * {@code pem}. >> >> The name does not sound correct t

Re: RFR: 8354305: SHAKE128 and SHAKE256 MessageDigest algorithms [v3]

2025-04-28 Thread Weijun Wang
On Mon, 28 Apr 2025 14:48:34 GMT, Weijun Wang wrote: >> Add 2 `MessageDigest` algorithms. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > test alias usage I mainly don't like the current [hardcoded branches](https://github

Integrated: 8354053: Remove unused JavaIOFilePermissionAccess

2025-04-28 Thread Roger Riggs
On Fri, 11 Apr 2025 21:26:08 GMT, Roger Riggs wrote: > The JavaIOFilePermissionAccess interface is removed from SharedSecrets and > its implementation (FilePermCompat.java) used by the test is moved to java.io > FilePermission where cross package access is not needed. > The test FilePermission

Re: RFR: 8355262: Test sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java failed: accept timed out

2025-04-28 Thread Jamil Nimeh
On Thu, 24 Apr 2025 17:57:33 GMT, Artur Barashev wrote: > I wasn't able to reproduce the issue. Most likely it was caused by unusually > high CPU load in test environment. Increasing the server's "accept" call > time-out value from 5 to 10 seconds to make the test more robust. The changes look

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v2]

2025-04-28 Thread Sean Mullan
On Fri, 25 Apr 2025 20:05:07 GMT, Mark Powers wrote: >> [JDK-8351113](https://bugs.openjdk.org/browse/JDK-8351113) > > Mark Powers has updated the pull request incrementally with one additional > commit since the last revision: > > need test test/jdk/java/security/spec/InvalidArrayIndex.java

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v3]

2025-04-28 Thread Mark Powers
> [JDK-8351113](https://bugs.openjdk.org/browse/JDK-8351113) Mark Powers has updated the pull request incrementally with one additional commit since the last revision: comment from Sean - Changes: - all: https://git.openjdk.org/jdk/pull/24854/files - new: https://git.openjdk.

Re: RFR: 8351113: RC2ParameterSpec throws IllegalArgumentException when offset is negative [v2]

2025-04-28 Thread Mark Powers
On Mon, 28 Apr 2025 20:13:47 GMT, Sean Mullan wrote: >> Mark Powers has updated the pull request incrementally with one additional >> commit since the last revision: >> >> need test > > test/jdk/java/security/spec/InvalidArrayIndex.java line 1: > >> 1: /* > > Can you put this test in a new