Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-11 Thread Daniel Jeliński
On Thu, 10 Apr 2025 23:54:03 GMT, Martin Balao wrote: >> Hi, >> >> I would like to request a review for the fix of JDK-8350661. In this fix, we >> translate the native PKCS 11 error code into an >> `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey` >> API. With that s

RFR: 8353642: Deprecate networking permission classes for removal

2025-04-11 Thread Daniel Fuchs
Please find her a patch that deprecate networking permission classes for removal. The method `URL::getPermission` now serves little purpose and is also deprecated. That method was overridden in subclasses and specified to return some of the deprecated permissions. - Commit message

Re: RFR: 8353642: Deprecate networking permission classes for removal

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 09:00:05 GMT, Daniel Fuchs wrote: > Please find her a patch that deprecate networking permission classes for > removal. The method `URL::getPermission` now serves little purpose and is > also deprecated. That method was overridden in subclasses and specified to > return so

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
> Please find her a patch that deprecate networking permission classes for > removal. The method `URL::getPermission` now serves little purpose and is > also deprecated. That method was overridden in subclasses and specified to > return some of the deprecated permissions. Daniel Fuchs has upda

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Jeliński
On Fri, 11 Apr 2025 10:01:26 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> retur

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Jeliński
On Fri, 11 Apr 2025 10:55:10 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Missing white spaces > > src/java.base/share/classes/java/security/CodeSource.java line 468: > >> 466:

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Jeliński
On Fri, 11 Apr 2025 10:01:26 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> retur

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 10:45:20 GMT, Daniel Jeliński wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Missing white spaces > > src/java.base/share/classes/java/net/HttpURLConnection.java line 617: > >> 615: * {@l

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 11:10:10 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/java/security/CodeSource.java line 468: >> >>> 466: } >>> 467: @SuppressWarnings("removal") >>> 468: var result = this.sp.implies(that.sp); >> >> Will we need

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Alan Bateman
On Fri, 11 Apr 2025 11:30:54 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/java/net/HttpURLConnection.java line 617: >> >>> 615: * {@link java.security.AllPermission}. >>> 616: */ >>> 617: @Deprecated(since = "25") >> >> can this (and all other getPermission methods) be

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 11:34:36 GMT, Alan Bateman wrote: >> Possibly. @AlanBateman may have some thoughts on this. > > I think we should at least consider deprecating URLConnection.getPermission > and HttpURLConnection.getPermission for removal, only because I don't > immediately see the advantage

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Jeliński
On Fri, 11 Apr 2025 10:01:26 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> retur

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 12:01:52 GMT, Daniel Jeliński wrote: > The GHA failure (Windows) appears to be related. Yes - I missed one windows specific file in my original patch. I have a test running in the CI and I am waiting for it to pass before updating the PR. - PR Comment: https://

Re: RFR: 8353642: Deprecate networking permission classes for removal [v2]

2025-04-11 Thread Michael McMahon
On Fri, 11 Apr 2025 10:01:26 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> retur

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 12:31:04 GMT, Daniel Fuchs wrote: > The GHA failure (Windows) appears to be related. Should be fixed now - PR Comment: https://git.openjdk.org/jdk/pull/24592#issuecomment-2796995066

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 11:47:21 GMT, Daniel Fuchs wrote: >> I think we should at least consider deprecating URLConnection.getPermission >> and HttpURLConnection.getPermission for removal, only because I don't >> immediately see the advantage of doing it in two steps for these two APIs. > > Thanks

Re: RFR: 8353642: Deprecate networking permission classes for removal [v3]

2025-04-11 Thread Daniel Fuchs
> Please find her a patch that deprecate networking permission classes for > removal. The method `URL::getPermission` now serves little purpose and is > also deprecated. That method was overridden in subclasses and specified to > return some of the deprecated permissions. Daniel Fuchs has upda

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v2]

2025-04-11 Thread Daniel Fuchs
On Fri, 11 Apr 2025 13:47:10 GMT, Michael McMahon wrote: >> Daniel Fuchs has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Missing white spaces > > src/java.base/share/classes/java/security/CodeSource.java line 461: > >> 459:

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v3]

2025-04-11 Thread Michael McMahon
On Fri, 11 Apr 2025 13:56:18 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> retur

Re: RFR: 8350807: Certificates using MD5 algorithm that are disabled by default are incorrectly allowed in TLSv1.3 when re-enabled [v2]

2025-04-11 Thread Artur Barashev
> MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates: > > > Any endpoint receiving any certificate which it would need to > validate using any signature algorithm using an MD5 hash MUST abort > the handshake with a "bad_certificate" alert. > > > > The bug manifests itself wh

Re: RFR: 8325448: Hybrid Public Key Encryption [v14]

2025-04-11 Thread Sean Mullan
On Wed, 2 Apr 2025 20:35:29 GMT, Weijun Wang wrote: >> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/. >> ![hpke](https://github.com/user-attachments/assets/4edc5d08-ef52-44c5-b5d5-e8890c2d2fce) > > Weijun Wang has updated the pull request incrementally with two additional

Re: RFR: 8353642: Deprecate URL::getPermission method and networking permission classes for removal [v3]

2025-04-11 Thread Daniel Jeliński
On Fri, 11 Apr 2025 13:56:18 GMT, Daniel Fuchs wrote: >> Please find her a patch that deprecate networking permission classes for >> removal. The method `URL::getPermission` now serves little purpose and is >> also deprecated. That method was overridden in subclasses and specified to >> retur

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-11 Thread Valerie Peng
On Fri, 11 Apr 2025 00:00:39 GMT, Martin Balao wrote: > What I have found with Tls* keys is that they are in the map but we need to > translate their pseudo-mechanism to a valid one (`CKK_GENERIC_SECRET`). Is > that enough for #24393? What I found is that there are more "TlsXXX" than those def

RFR: 8354449: Remove com/sun/org/apache/xml/internal/security/resource/xmlsecurity_de.properties

2025-04-11 Thread Sean Mullan
Workaround for `sed` issue on MacOS 15.4. See https://bugs.openjdk.org/browse/JDK-8353948 for more details. This is a leftover resource file from long ago which serves no purpose, and has been removed in the next Apache release: https://issues.apache.org/jira/browse/SANTUARIO-624 Running throu

Re: RFR: 8325448: Hybrid Public Key Encryption [v15]

2025-04-11 Thread Weijun Wang
> Implement HPKE as defined in https://datatracker.ietf.org/doc/rfc9180/. > ![hpke](https://github.com/user-attachments/assets/4edc5d08-ef52-44c5-b5d5-e8890c2d2fce) Weijun Wang has updated the pull request incrementally with one additional commit since the last revision: toString, exportData,

Re: RFR: 8354449: Remove com/sun/org/apache/xml/internal/security/resource/xmlsecurity_de.properties

2025-04-11 Thread Weijun Wang
On Fri, 11 Apr 2025 20:34:39 GMT, Sean Mullan wrote: > Workaround for `sed` issue on MacOS 15.4. See > https://bugs.openjdk.org/browse/JDK-8353948 for more details. > > This is a leftover resource file from long ago which serves no purpose, and > has been removed in the next Apache release: >

RFR: 8354053: Remove unused JavaIOFilePermissionAccess

2025-04-11 Thread Roger Riggs
The JavaIOFilePermissionAccess interface is removed from SharedSecrets and its implementation (FilePermCompat.java) used by the test is moved to java.io FilePermission where cross package access is not needed. The test FilePermissionCollectionMerge is updated to access the internal implementati

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-11 Thread Valerie Peng
On Thu, 10 Apr 2025 23:54:03 GMT, Martin Balao wrote: >> Hi, >> >> I would like to request a review for the fix of JDK-8350661. In this fix, we >> translate the native PKCS 11 error code into an >> `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey` >> API. With that s

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-11 Thread Valerie Peng
On Thu, 10 Apr 2025 23:54:03 GMT, Martin Balao wrote: >> Hi, >> >> I would like to request a review for the fix of JDK-8350661. In this fix, we >> translate the native PKCS 11 error code into an >> `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey` >> API. With that s

Re: RFR: 8349400: Improve startup speed via eliminating nested classes [v2]

2025-04-11 Thread Valerie Peng
On Sat, 5 Apr 2025 01:30:49 GMT, Shaojin Wen wrote: >> During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10 >> anonymous classes, which slows down the startup. This PR is to improve >> KnownOIDs and eliminate unnecessary embedded classes. >> >> >> Here's how to reproduce this:

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-11 Thread Martin Balao
On Fri, 11 Apr 2025 21:28:30 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Algorithm and key size checking before derivation. Mechanism >> normalization for TLS. >> - Minor import adjustment

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-11 Thread Martin Balao
On Fri, 11 Apr 2025 19:47:38 GMT, Valerie Peng wrote: > > What I have found with Tls* keys is that they are in the map but we need to > > translate their pseudo-mechanism to a valid one (`CKK_GENERIC_SECRET`). Is > > that enough for #24393? > > What I found is that there are more "TlsXXX" than

Re: RFR: 8350661: PKCS11 HKDF throws ProviderException when requesting a 31-byte AES key [v2]

2025-04-11 Thread Martin Balao
On Fri, 11 Apr 2025 21:32:47 GMT, Valerie Peng wrote: >> Martin Balao has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Algorithm and key size checking before derivation. Mechanism >> normalization for TLS. >> - Minor import adjustment

Withdrawn: 8350134: Support DHKEM with PKCS11

2025-04-11 Thread duke
On Fri, 14 Feb 2025 21:24:37 GMT, Weijun Wang wrote: > This code change adds supports for getting public key from an EC private key > and slicing a secret key in PKCS #11. These are necessary to support DHKEM > for keys in SunPKCS11. The first support is still not complete and there is > no wa