On Wed, 9 Apr 2025 21:26:15 GMT, Justin Lu wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/Encodings.properties
>> line 22:
>>
>>> 20: # Peter Smolik
>>> 21: Cp1250 WINDOWS-1250 0x00FF
>>> 22: # Patch attributed to hava...@underdusken.no (H�vard Wigtil)
>>
>> Th
On Thu, 10 Apr 2025 07:31:37 GMT, Magnus Ihse Bursie wrote:
>> Right, that `å` looks to have been incorrectly converted during the
>> ISO-8859-1 to UTF-8 conversion. (I can't find the script used for conversion
>> as this change is from some time ago.)
>>
>> Since the change occurs in a commen
On Sat, 5 Apr 2025 19:12:23 GMT, Valerie Peng wrote:
>> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
>> for the HKDF support from JCA/JCE providers.
>>
>> This is just code refactoring. Known-answer regression test for the internal
>> JSSE HKDF impl is removed as
On Thu, 10 Apr 2025 13:19:05 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
>> approximately doubled.
>
> Ferenc Rakoczi has updated the pull request incrementally
> Refactored the runNameEquals.sh to java test
Mikhail Yankelevich has updated the pull request with a new target base due to
a merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains six additional
commits since the las
On Tue, 11 Feb 2025 18:46:29 GMT, Mikhail Yankelevich
wrote:
>> Refactored the runNameEquals.sh to java test
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> minor
test/jdk/sun/security/krb5/Krb5NameEquals.java line
> By using the aarch64 vector registers the speed of the computation of the
> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
> approximately doubled.
Ferenc Rakoczi has updated the pull request incrementally with two additional
commits since the last revision:
- Code
On Mon, 7 Apr 2025 18:40:35 GMT, Roger Riggs wrote:
>> Now that the Security Manager is permanently disabled, the following
>> permission classes in the core libraries area can be deprecated for removal
>> as they are no longer useful: FilePermission, LinkPermission,
>> LoggingPermission, Prop
On Mon, 11 Nov 2024 09:51:35 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
Add 2 `MessageDigest` algorithms.
-
Commit messages:
- the change
Changes: https://git.openjdk.org/jdk/pull/24576/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24576&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8354305
Stats: 96 lines in 4 files changed: 93 ins
On Mon, 10 Feb 2025 17:50:21 GMT, Mikhail Yankelevich
wrote:
> Refactored the runNameEquals.sh to java test
This pull request has now been integrated.
Changeset: 0e223f14
Author:Mikhail Yankelevich
Committer: Sean Mullan
URL:
https://git.openjdk.org/jdk/commit/0e223f1456c14efdb423
On Thu, 10 Apr 2025 14:42:22 GMT, Mikhail Yankelevich
wrote:
>> Refactored the runNameEquals.sh to java test
>
> Mikhail Yankelevich has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge
On Thu, 10 Apr 2025 13:19:05 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
>> approximately doubled.
>
> Ferenc Rakoczi has updated the pull request incrementally
On Thu, 10 Apr 2025 13:19:05 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
>> approximately doubled.
>
> Ferenc Rakoczi has updated the pull request incrementally
On Thu, 10 Apr 2025 13:19:05 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
>> approximately doubled.
>
> Ferenc Rakoczi has updated the pull request incrementally
On Thu, 10 Apr 2025 05:52:17 GMT, Alan Bateman wrote:
>> Hi, this is a proposal to fix 8352728.
>>
>> The main idea is to replace
>> [`java.nio.file.Path::toRealPath`](https://docs.oracle.com/en/java/javase/24/docs/api/java.base/java/nio/file/Path.html#toRealPath(java.nio.file.LinkOption...))
>
On Thu, 10 Apr 2025 13:19:05 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
>> approximately doubled.
>
> Ferenc Rakoczi has updated the pull request incrementally
On Thu, 10 Apr 2025 13:36:01 GMT, Sean Mullan wrote:
>> Mikhail Yankelevich has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor
>
> test/jdk/sun/security/krb5/Krb5NameEquals.java line 57:
>
>> 55: final GSSManager mgr = GSSMan
On Thu, 10 Apr 2025 14:42:22 GMT, Mikhail Yankelevich
wrote:
>> Refactored the runNameEquals.sh to java test
>
> Mikhail Yankelevich has updated the pull request with a new target base due
> to a merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the merge
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote:
>> JDK .properties files still use ISO-8859-1 encoding with escape sequences.
>> It would improve readability to see the native characters instead of escape
>> sequences (especially for the L10n process). The majority of files changed
>> are l
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote:
>> JDK .properties files still use ISO-8859-1 encoding with escape sequences.
>> It would improve readability to see the native characters instead of escape
>> sequences (especially for the L10n process). The majority of files changed
>> are l
On Thu, 10 Apr 2025 07:32:18 GMT, Magnus Ihse Bursie wrote:
>> You don't have to do that, I'm working on an omnibus UTF-8 fixing PR right
>> now, where I will include a fix for this as well.
>
> If anything, I might be a bit worried that there are more incorrect
> conversions stemming from this
On Wed, 13 Sep 2023 17:38:28 GMT, Justin Lu wrote:
>> JDK .properties files still use ISO-8859-1 encoding with escape sequences.
>> It would improve readability to see the native characters instead of escape
>> sequences (especially for the L10n process). The majority of files changed
>> are l
On Thu, 10 Apr 2025 08:08:02 GMT, Eirik Bjørsnøs wrote:
>> If anything, I might be a bit worried that there are more incorrect
>> conversions stemming from this PR, that my automated tools and manual
>> scanning has not revealed.
>
> Some observations:
>
> 1: This PR seems to have been abondo
MD5 algorithm is prohibited by TLSv1.3 RFC to be used in certificates:
Any endpoint receiving any certificate which it would need to
validate using any signature algorithm using an MD5 hash MUST abort
the handshake with a "bad_certificate" alert.
The bug manifests itself when older versions of
On Mon, 7 Apr 2025 14:32:26 GMT, Sean Mullan wrote:
> Also, the JBS issue needs an appropriate `noreg` label.
Added `noreg-cleanup`, I think thats the best match (?)
> Can you add a link to JDK-8350459 in the JBS issue?
Its already a subtask of JDK-8350459, so its 'linked' in a way (though the
On Wed, 19 Mar 2025 18:08:40 GMT, Mikhail Yankelevich
wrote:
>> Moved the sh file logic to jtreg java test.
>
> Mikhail Yankelevich has updated the pull request incrementally with one
> additional commit since the last revision:
>
> minor: space at the end
test/jdk/sun/security/pkcs11/Provi
On Mon, 7 Apr 2025 06:34:11 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to address the
> increase in memory footprint of an application that uses signed JAR files,
> signed with `SHA-384` digest algorithm? This addresses
> https://bugs.openjdk.org/browse/
On Thu, 10 Apr 2025 13:19:05 GMT, Ferenc Rakoczi wrote:
>> By using the aarch64 vector registers the speed of the computation of the
>> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be
>> approximately doubled.
>
> Ferenc Rakoczi has updated the pull request incrementally
On Wed, 9 Apr 2025 13:19:45 GMT, Martin Balao wrote:
> Perhaps we can do both: check beforehand and handle the error afterwards.
That sounds reasonable.
Whatever you decide, I think it would be good to make sure P11HKDF,
P11SecretKeyFactory and P11KeyGenerator perform the same checks during k
On Thu, 10 Apr 2025 08:44:28 GMT, Eirik Bjørsnøs wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Replace InputStreamReader with BufferedReader
>
> FWIW, I checked out the revision of the commit previous to this change
On Fri, 4 Apr 2025 12:37:32 GMT, Roger Riggs wrote:
> Now that the Security Manager is permanently disabled, the following
> permission classes in the core libraries area can be deprecated for removal
> as they are no longer useful: FilePermission, LinkPermission,
> LoggingPermission, Property
On Fri, 4 Apr 2025 23:05:01 GMT, Bradford Wetmore wrote:
>> Yes, I am on the fence about this. Given the specified value is the same as
>> the default, it can be removed. I kept it there so the new code matches the
>> original code completely. Not much difference either way I think.
>
> I like
On Mon, 7 Apr 2025 18:48:15 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/sun/security/ssl/Utilities.java line 150:
>>
>>> 148: String sanitizedAlg = digestAlg.replace("-", "");
>>> 149: return switch (sanitizedAlg) {
>>> 150: case "SHA256", "SHA384", "SHA512
On Thu, 3 Apr 2025 18:42:35 GMT, Volodymyr Paprotski
wrote:
> 8353671: Remove dead code missed in JDK-8350459
@vpaprotsk
Your change (at version 6cc25c3373e6dbb18c9d1d37e8cfcb5e08e16ff7) is now ready
to be sponsored by a Committer.
-
PR Comment: https://git.openjdk.org/jdk/pull/
> Hi,
>
> I would like to request a review for the fix of JDK-8350661. In this fix, we
> translate the native PKCS 11 error code into an
> `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey`
> API. With that said, different PKCS 11 libraries may throw different errors
>
> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
> for the HKDF support from JCA/JCE providers.
>
> This is just code refactoring. Known-answer regression test for the internal
> JSSE HKDF impl is removed as the test vectors are already covered by the HKDF
> impl in
On Thu, 10 Apr 2025 03:27:19 GMT, Valerie Peng wrote:
>> Hi,
>>
>> I would like to request a review for the fix of JDK-8350661. In this fix, we
>> translate the native PKCS 11 error code into an
>> `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey`
>> API. With that s
On Tue, 8 Apr 2025 19:35:33 GMT, Chen Liang wrote:
>> Finalize the KDF API.
>
> src/java.base/share/classes/jdk/internal/javac/PreviewFeature.java line 82:
>
>> 80: MODULE_IMPORTS,
>> 81: @JEP(number=478, title="Key Derivation Function API",
>> status="Preview")
>> 82: K
On Fri, 4 Apr 2025 20:44:28 GMT, Artur Barashev wrote:
>> Disable SHA-1 in TLS/DTLS 1.2 handshake signatures (but not in certificate
>> signatures).
>> https://www.rfc-editor.org/rfc/rfc9155.html
>>
>> Also fixing a little TLSv1.3 spec violation bug: ECDSA_SHA1 should not be
>> allowed for han
On Tue, 4 Feb 2025 14:08:05 GMT, Mikhail Yankelevich
wrote:
> Refactor the following to run fully in java:
> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh
> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh
This pull request has now been integrated.
Changes
On Thu, 10 Apr 2025 23:54:03 GMT, Martin Balao wrote:
>> Hi,
>>
>> I would like to request a review for the fix of JDK-8350661. In this fix, we
>> translate the native PKCS 11 error code into an
>> `InvalidAlgorithmParameterException`, as documented in the `KDF::deriveKey`
>> API. With that s
On Tue, 8 Apr 2025 06:41:41 GMT, Alan Bateman wrote:
>> Roger Riggs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits sin
On Thu, 10 Apr 2025 21:26:21 GMT, Michael McMahon wrote:
>> Hi,
>>
>> Enhanced exception messages are designed to hide sensitive information such
>> as hostnames, IP
>> addresses from exception message strings, unless the enhanced mode for the
>> specific category
>> has been explicitly enab
On Wed, 9 Apr 2025 15:06:32 GMT, Magnus Ihse Bursie wrote:
>> Justin Lu has updated the pull request with a new target base due to a merge
>> or a rebase. The pull request now contains 16 commits:
>>
>> - Convert the merged master changes to UTF-8
>> - Merge master and fix conflicts
>> - Clo
On Mon, 7 Apr 2025 16:42:14 GMT, Sean Mullan wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added default deriveData method to SSLKeyDerivation interface and
>> refactored code to remove unused AlgorithmParamete
On Tue, 8 Apr 2025 03:20:31 GMT, Koushik Muthukrishnan Thirupattur
wrote:
>> Test javax/security/auth/x500/X500Principal/NameFormat.java fails after
>> JDK-8349890. The expected results of the failing tests will now change
>> according to the fix in JDK-8349890.
>
> Koushik Muthukrishnan Thiru
On Mon, 7 Apr 2025 16:44:58 GMT, Sean Mullan wrote:
>> Valerie Peng has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added default deriveData method to SSLKeyDerivation interface and
>> refactored code to remove unused AlgorithmParamete
On Sat, 5 Apr 2025 19:12:23 GMT, Valerie Peng wrote:
>> This PR removes the internal JSSE HKDF impl and changes to use the KDF API
>> for the HKDF support from JCA/JCE providers.
>>
>> This is just code refactoring. Known-answer regression test for the internal
>> JSSE HKDF impl is removed as
> Now that the Security Manager is permanently disabled, the following
> permission classes in the core libraries area can be deprecated for removal
> as they are no longer useful: FilePermission, LinkPermission,
> LoggingPermission, PropertyPermission, ReflectPermission, RuntimePermission,
> a
> Hi, this pull request implements the fixes for bugs and inconsistencies
> described in [JDK-8345139](https://bugs.openjdk.org/browse/JDK-8345139 "Fix
> bugs and inconsistencies in the Provider services map").
>
> New services map design
>
> Here is the high-level hierarchy of the new ser
On Tue, 8 Apr 2025 14:23:06 GMT, Sean Mullan wrote:
>> Please review this change to terminally deprecate the following security
>> related permission classes: `java.security.UnresolvedPermission`,
>> `javax.net.ssl.SSLPermission`, `javax.security.auth.AuthPermission`,
>> `javax.security.auth.P
On Thu, 3 Apr 2025 18:42:35 GMT, Volodymyr Paprotski
wrote:
> 8353671: Remove dead code missed in JDK-8350459
This pull request has now been integrated.
Changeset: 885cf0ff
Author:Volodymyr Paprotski
Committer: Sandhya Viswanathan
URL:
https://git.openjdk.org/jdk/commit/885cf0ff8d
> Hi,
>
> Enhanced exception messages are designed to hide sensitive information such
> as hostnames, IP
> addresses from exception message strings, unless the enhanced mode for the
> specific category
> has been explicitly enabled. Enhanced exceptions were first introduced in
> 8204233 in JD
54 matches
Mail list logo
