Re: RFR: 8352277: java.security documentation: incorrect regex syntax describing "usage" algorithm constraint

2025-04-05 Thread Artur Barashev
On Tue, 25 Mar 2025 18:51:36 GMT, Hai-May Chao wrote: >> We have an incorrect regex syntax when describing a "usage" algorithm >> constraint. Current syntax indicates that usage types are optional while >> they are not: at least one usage type should be specified. > > src/java.base/share/conf/s

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v11]

2025-04-05 Thread Jatin Bhateja
On Mon, 31 Mar 2025 11:11:54 GMT, Ferenc Rakoczi wrote: >> src/hotspot/cpu/x86/vm_version_x86.cpp line 1252: >> >>> 1250: // Currently we only have them for AVX512 >>> 1251: #ifdef _LP64 >>> 1252: if (supports_evex() && supports_avx512bw()) { >> >> supports_evex check looks redundant. > > T

Re: RFR: 8350705: [JMH] test security.SSLHandshake failed for 2 threads configuration

2025-04-05 Thread Daniel JeliƄski
On Tue, 25 Mar 2025 15:38:02 GMT, Hai-May Chao wrote: >> Update the SSLHandshake benchmark to enable running in multiple threads. >> >> This PR changes the scope of the state from per-benchmark to per-thread. The >> server SSLContext is still shared across all threads to simulate the >> scenar

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-05 Thread Martin Balao
On Thu, 6 Mar 2025 06:13:22 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8249825: Tests sun/security/ssl/SSLSocketImpl/SetClientMode.java and NonAutoClose.java marked with @ignore [v3]

2025-04-05 Thread Fernando Guallini
On Thu, 20 Mar 2025 18:02:49 GMT, Artur Barashev wrote: >> Fernando Guallini has updated the pull request incrementally with one >> additional commit since the last revision: >> >> latch await > > test/jdk/sun/security/ssl/SSLSocketImpl/SetClientMode.java line 110: > >> 108:

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-05 Thread Martin Balao
On Thu, 6 Mar 2025 07:06:08 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v10]

2025-04-05 Thread Ferenc Rakoczi
On Sat, 22 Mar 2025 16:36:08 GMT, Volodymyr Paprotski wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Fix windows build > > src/hotspot/cpu/x86/stubGenerator_x86_64_dilithium.cpp line 121: > >> 119: static void

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v12]

2025-04-05 Thread Ferenc Rakoczi
On Tue, 1 Apr 2025 22:43:36 GMT, Sandhya Viswanathan wrote: >> Ferenc Rakoczi has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Reacting to comments by Volodymyr. > > src/hotspot/cpu/x86/stubGenerator_x86_64_sha3.cpp line 359: > >> 357:

Re: RFR: 8350459: MontgomeryIntegerPolynomialP256 multiply intrinsic with AVX2 on x86_64 [v4]

2025-04-05 Thread Volodymyr Paprotski
On Wed, 19 Mar 2025 19:00:37 GMT, Anthony Scarpino wrote: >> I was mostly attempting to test 'random paths' through the code, and this >> was a way to pseudo-randomly accomplish that. (i.e. a product of a >> difference, a product of a product.. and so on..) >> >> Since this is looping, we got

Re: RFR: 8349583: Add mechanism to disable signature schemes based on their TLS scope [v21]

2025-04-05 Thread Artur Barashev
On Fri, 28 Mar 2025 20:08:40 GMT, Sean Mullan wrote: >> Artur Barashev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update copyright year > > src/java.base/share/classes/sun/security/ssl/SignatureScheme.java line 221: > >> 219: >> 2

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v12]

2025-04-05 Thread Ferenc Rakoczi
> By using the AVX-512 vector registers the speed of the computation of the > ML-DSA algorithms (key generation, document signing, signature verification) > can be approximately doubled. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-05 Thread Martin Balao
On Tue, 25 Feb 2025 19:40:24 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same ord

Re: RFR: 8351566: Consolidate third party artifacts used in tests

2025-04-05 Thread Mikhail Yankelevich
On Tue, 11 Mar 2025 15:15:39 GMT, Mikhail Yankelevich wrote: > 8351566: Consolidate third party artifacts used in tests test/jdk/sun/security/pkcs11/Provider/MultipleLogins.sh line 31: > 29: #jdk.test.lib.Platform > 30: #jdk.test.lib.Utils > 31: #jdk.test.lib.security.a

Re: RFR: 8298420: PEM API: Implementation (Preview) [v12]

2025-04-05 Thread Anthony Scarpino
On Wed, 12 Mar 2025 20:44:30 GMT, Jamil Nimeh wrote: >> Anthony Scarpino has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 58 commits: >> >> - Merge branch 'pem-merge' into pem >> - merge >> - Merge in PEMRecord as part of the AP

Re: RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v10]

2025-04-05 Thread Hai-May Chao
> The jarsigner -verify command currently performs verification by reading from > JarFile to navigate the central directory (CEN) headers. It is now enhanced > to include cross-validation of entries between JarFile (CEN-based) and > JarInputStream (stream-based) representations of the JAR. It em

Re: RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v4]

2025-04-05 Thread Andrew Dinn
On Tue, 4 Mar 2025 22:04:26 GMT, Ferenc Rakoczi wrote: >> By using the aarch64 vector registers the speed of the computation of the >> ML-KEM algorithms (key generation, encapsulation, decapsulation) can be >> approximately doubled. > > Ferenc Rakoczi has updated the pull request with a new tar

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v11]

2025-04-05 Thread Volodymyr Paprotski
On Sat, 22 Mar 2025 20:02:31 GMT, Ferenc Rakoczi wrote: >> By using the AVX-512 vector registers the speed of the computation of the >> ML-DSA algorithms (key generation, document signing, signature verification) >> can be approximately doubled. > > Ferenc Rakoczi has updated the pull request i

Re: RFR: 8353299: VerifyJarEntryName.java test fails

2025-04-05 Thread Sean Mullan
On Mon, 31 Mar 2025 21:16:42 GMT, Hai-May Chao wrote: > Please review the change for JDK-8353299. Bug needs a `noreg-self` label. Otherwise fix looks fine. - Marked as reviewed by mullan (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24337#pullrequestreview-2730550363

Re: RFR: 8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms

2025-04-05 Thread Andrey Turbanov
On Tue, 1 Apr 2025 21:41:57 GMT, Sergey Kuksenko wrote: > Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms. test/micro/org/openjdk/bench/javax/crypto/full/KEMBench.java line 69: > 67: @OperationsPerInvocation(SET_SIZE) > 68: public void encapsulate(Blackhole bh)

Re: RFR: 8351366: Remove the java.security.debug=scl option [v2]

2025-04-05 Thread Koushik Muthukrishnan Thirupattur
> This option dumped the permissions that the SecureClassLoader assigns to > ProtectionDomains, but with the disabling of the Security Manager in JDK 24, > these permissions are always empty and the debugging has no value. So this > option should be removed. Koushik Muthukrishnan Thirupattur ha

Re: RFR: 8349583: Add mechanism to disable signature schemes based on their TLS scope [v22]

2025-04-05 Thread duke
On Mon, 31 Mar 2025 14:17:50 GMT, Artur Barashev wrote: >> Currently when a signature scheme constraint is specified with >> "jdk.tls.disabledAlgorithms" property we don't differentiate between >> signatures used to sign a TLS handshake exchange and the signatures used in >> TLS certificates:

Re: RFR: 8351034: Add AVX-512 intrinsics for ML-DSA [v9]

2025-04-05 Thread Ferenc Rakoczi
> By using the AVX-512 vector registers the speed of the computation of the > ML-DSA algorithms (key generation, document signing, signature verification) > can be approximately doubled. Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision

Re: RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java [v3]

2025-04-05 Thread Mikhail Yankelevich
On Thu, 6 Mar 2025 11:49:12 GMT, Mikhail Yankelevich wrote: >> Refactor the following to run fully in java: >> test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh >> test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh > > Mikhail Yankelevich has updated the pull requ

Re: RFR: 8315487: Security Providers Filter [v21]

2025-04-05 Thread Xue-Lei Andrew Fan
On Thu, 20 Feb 2025 20:31:40 GMT, Martin Balao wrote: >> In addition to the goals, scope, motivation, specification and requirement >> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we >> would like to describe the most relevant decisions taken during the >> implementatio

Withdrawn: 8347938: Switch to latest ML-KEM private key encoding

2025-04-05 Thread duke
On Thu, 30 Jan 2025 22:00:07 GMT, Weijun Wang wrote: > The private key encoding formats of ML-KEM and ML-DSA are updated to match > the latest IERTF drafts at: > https://datatracker.ietf.org/doc/html/draft-ietf-lamps-dilithium-certificates-06 > and > https://datatracker.ietf.org/doc/html/draf

Re: RFR: 8347067: Load certificates without explicit trust settings in KeyChainStore [v5]

2025-04-05 Thread Sean Mullan
On Mon, 27 Jan 2025 22:43:32 GMT, Tim Jacomb wrote: >> ## The change >> >> Without this change intermediate certificates that don't have explicit trust >> settings are ignored not added to the truststore. >> >> >> >> ## Reproducer >> >> See https://github.com/timja/openjdk-intermediate-ca-r

Re: RFR: 8339280: jarsigner -verify performs cross-checking between CEN and LOC [v14]

2025-04-05 Thread Hai-May Chao
On Wed, 26 Mar 2025 12:34:13 GMT, Sean Mullan wrote: >> Hai-May Chao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updated with Sean's comments > > src/jdk.jartool/share/classes/sun/security/tools/jarsigner/Main.java line > 1138: > >

Re: RFR: 8219408: Tests should handle ${} in the view of jtreg "smart action"

2025-04-05 Thread Matthew Donovan
On Thu, 3 Apr 2025 14:48:20 GMT, Sean Mullan wrote: > Looks ok, but I am wondering ... how did these tests pass in the first place > if the `allowSmartActionArgs` property was false? The underlying code uses `PropertyExpander.expand()` which looks for and expands `${}` values. -

Re: RFR: 8345139: Fix bugs and inconsistencies in the Provider services map [v5]

2025-04-05 Thread Martin Balao
On Tue, 4 Mar 2025 01:59:58 GMT, Valerie Peng wrote: >> Francisco Ferrari Bihurriet has updated the pull request incrementally with >> one additional commit since the last revision: >> >> Clear ServicesMap fields in the declared order >> >> Constructors assign the fields in the same orde

Re: RFR: 8353578: Refactor existing usage of internal HKDF impl to use the KDF API [v2]

2025-04-05 Thread Valerie Peng
> This PR removes the internal JSSE HKDF impl and changes to use the KDF API > for the HKDF support from JCA/JCE providers. > > This is just code refactoring. Known-answer regression test for the internal > JSSE HKDF impl is removed as the test vectors are already covered by the HKDF > impl in

Re: RFR: 8353478: Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms [v2]

2025-04-05 Thread Sergey Kuksenko
> Update crypto microbenchmarks to cover ML-DSA, ML-KEM, and HSS algorithms. Sergey Kuksenko has updated the pull request incrementally with one additional commit since the last revision: Update test/micro/org/openjdk/bench/javax/crypto/full/KEMBench.java Co-authored-by: Andrey Turbanov