Re: RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified [v3]

2025-02-04 Thread Bradford Wetmore
On Tue, 4 Feb 2025 17:18:09 GMT, Daniel Fuchs wrote: >> Bradford Wetmore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Codereview Comments > > src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 668: > >> 666: *

Re: RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified [v3]

2025-02-04 Thread Bradford Wetmore
> Update and clarify the sample code. > > Docs only, no additional testing other than verifying javadoc is correctly > output. Bradford Wetmore has updated the pull request incrementally with one additional commit since the last revision: Codereview Comments - Changes: - all:

Integrated: 8349106: Change ChaCha20 intrinsic to use quarter-round parallel implementation on aarch64

2025-02-04 Thread Jamil Nimeh
On Fri, 31 Jan 2025 16:48:09 GMT, Jamil Nimeh wrote: > This enhancement makes a change to the ChaCha20 block function intrinsic on > aarch64, moving away from the block parallel implementation and to the > quarter-round parallel implementation that was done on x86_64. Assembly > language prof

Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v2]

2025-02-04 Thread Andrew Dinn
On Mon, 3 Feb 2025 18:11:51 GMT, Ferenc Rakoczi wrote: >> @ferakocz I'm afraid you lucked out on getting your change committed before >> my reorganization of the stub generation code. If you are unsure of how to >> do the merge so your new stub is declared and generated following the new >> mo

Re: RFR: 8349106: Change ChaCha20 intrinsic to use quarter-round parallel implementation on aarch64 [v2]

2025-02-04 Thread Andrew Haley
On Mon, 3 Feb 2025 23:56:18 GMT, Jamil Nimeh wrote: >> This enhancement makes a change to the ChaCha20 block function intrinsic on >> aarch64, moving away from the block parallel implementation and to the >> quarter-round parallel implementation that was done on x86_64. Assembly >> language p

Re: RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified

2025-02-04 Thread Daniel Fuchs
On Fri, 31 Jan 2025 01:45:47 GMT, Bradford Wetmore wrote: > Update and clarify the sample code. > > Docs only, no additional testing other than verifying javadoc is correctly > output. src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 668: > 666: * String encodedHukUn

Re: RFR: 8349121: SSLParameters.setApplicationProtocols() ALPN example could be clarified [v2]

2025-02-04 Thread Bradford Wetmore
> Update and clarify the sample code. > > Docs only, no additional testing other than verifying javadoc is correctly > output. Bradford Wetmore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by th

RFR: 8349400: Improve startup speed via eliminating nested classes

2025-02-04 Thread Shaojin Wen
During JVM startup, the class KnownOIDs is loaded. KnownOIDs has 10 anonymous classes, which slows down the startup. This PR is to improve KnownOIDs and eliminate unnecessary embedded classes. Here's how to reproduce this: public class Startup { public static void main(String[] args) {} }

Integrated: 8184352: Remove Sun provider information from KeyPairGenerator javadoc

2025-02-04 Thread Ben Perez
On Thu, 23 Jan 2025 20:56:25 GMT, Ben Perez wrote: > Removed algorithm-specific information from `KeyPairGenerator` class > description and instead linked out to the Sun Provider documentation This pull request has now been integrated. Changeset: 9d23de58 Author:Ben Perez URL: http

Re: RFR: 8348309: MultiNST tests need more debugging and timing

2025-02-04 Thread Hai-May Chao
On Sat, 1 Feb 2025 04:20:36 GMT, Anthony Scarpino wrote: > I need a review of this change that adds new timing controls for the initial > server setup. On rare occasions, more so on certain architectures, the > server may not fully start before the client tries to connect. Additional > debug

Re: RFR: 8348561: Add aarch64 intrinsics for ML-DSA [v2]

2025-02-04 Thread Ferenc Rakoczi
On Mon, 3 Feb 2025 18:11:51 GMT, Ferenc Rakoczi wrote: >> @ferakocz I'm afraid you lucked out on getting your change committed before >> my reorganization of the stub generation code. If you are unsure of how to >> do the merge so your new stub is declared and generated following the new >> mo

Re: RFR: 8184352: Remove Sun provider information from KeyPairGenerator javadoc [v4]

2025-02-04 Thread Ben Perez
> Removed algorithm-specific information from `KeyPairGenerator` class > description and instead linked out to the Sun Provider documentation Ben Perez has updated the pull request incrementally with one additional commit since the last revision: Update copyright date - Changes:

Re: RFR: 8184352: Remove Sun provider information from KeyPairGenerator javadoc [v4]

2025-02-04 Thread Sean Mullan
On Tue, 4 Feb 2025 20:37:52 GMT, Ben Perez wrote: >> Removed algorithm-specific information from `KeyPairGenerator` class >> description and instead linked out to the Sun Provider documentation > > Ben Perez has updated the pull request incrementally with one additional > commit since the last

Re: RFR: 8184352: Remove Sun provider information from KeyPairGenerator javadoc [v3]

2025-02-04 Thread Sean Mullan
On Tue, 28 Jan 2025 20:47:01 GMT, Ben Perez wrote: >> Removed algorithm-specific information from `KeyPairGenerator` class >> description and instead linked out to the Sun Provider documentation > > Ben Perez has updated the pull request incrementally with one additional > commit since the last

RFR: 8349084: Update vectors used in several PQC benchmarks

2025-02-04 Thread Mark Powers
[JDK-8349084](https://bugs.openjdk.org/browse/JDK-8349084) - Commit messages: - first iteration Changes: https://git.openjdk.org/jdk/pull/23452/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=23452&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8349084 Stats: 2310

RFR: 8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java

2025-02-04 Thread Mikhail Yankelevich
Refactor the following to run fully in java: test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh - Commit messages: - JDK-8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java C