Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Peter Firmstone
There are problems with the agent approach, finalizer's must be disabled, but there are other issues, such as replacement of doPrivileged calls and the need to widen permission grants as everything is on the stack. I did consider a mode where there are no privileges unless a privileged call h

RFR: Merge 490d099e234f27adef7d691d3c5a08ebdb550c5d

2024-10-16 Thread Jaikiran Pai
This brings in CPU24_10 changes into master branch. - Commit messages: - 8335713: Enhance vectorization analysis - 8332644: Improve graph optimizations - 8331446: Improve deserialization support - 8307383: Enhance DTLS connections - 8311208: Improve CDS Support - 8328544: Improv

Re: RFR: Merge 490d099e234f27adef7d691d3c5a08ebdb550c5d

2024-10-16 Thread Alan Bateman
On Wed, 16 Oct 2024 10:31:12 GMT, Jaikiran Pai wrote: > This brings in CPU24_10 changes into master branch. Discussed with Jai to confirm testing. All good. - Marked as reviewed by alanb (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/21533#pullrequestreview-2372116298

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Alan Bateman
On Tue, 15 Oct 2024 22:16:27 GMT, Sean Mullan wrote: >> src/java.desktop/share/classes/java/awt/Robot.java line 433: >> >>> 431: * then a {@code SecurityException} may be thrown, >>> 432: * or the content of the returned {@code Color} is undefined. >>> 433: * >> >> This text sho

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Alan Bateman
On Tue, 15 Oct 2024 18:57:11 GMT, Phil Race wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main chan

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread ExE Boss
On Wed, 16 Oct 2024 06:28:03 GMT, Alan Bateman wrote: >> Thanks, will fix. > > SecurityManager::getClassContext hasn't been needed since JDK 9 but we > decided to keep the implementation in case there are older versions of > logging libraries that extend SecurityManager so they can call this me

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Alan Bateman
On Wed, 16 Oct 2024 15:31:49 GMT, ExE Boss wrote: >> SecurityManager::getClassContext hasn't been needed since JDK 9 but we >> decided to keep the implementation in case there are older versions of >> logging libraries that extend SecurityManager so they can call this method. >> What we have c

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Weijun Wang
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote: > This is the implementation of JEP 486: Permanently Disable the Security > Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The > [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the > main change

Re: RFR: 8342211: Insufficient buffer remaining for AEAD cipher fragment [v2]

2024-10-16 Thread Artur Barashev
On Wed, 16 Oct 2024 05:31:23 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> Please review this simple update, which is trying to expose more information >> about the failed decryption. >> >> Here is the JBS: https://bugs.openjdk.org/browse/JDK-8342211 >> >> Best, >> Xuelei > > Xue-Lei Andrew Fan

Integrated: Merge 490d099e234f27adef7d691d3c5a08ebdb550c5d

2024-10-16 Thread Jaikiran Pai
On Wed, 16 Oct 2024 10:31:12 GMT, Jaikiran Pai wrote: > This brings in CPU24_10 changes into master branch. This pull request has now been integrated. Changeset: cf5bb127 Author:Jaikiran Pai URL: https://git.openjdk.org/jdk/commit/cf5bb12731b0eefe53b99281453e40493ddafbe4 Stats:

Re: RFR: Merge 490d099e234f27adef7d691d3c5a08ebdb550c5d

2024-10-16 Thread Jaikiran Pai
On Wed, 16 Oct 2024 10:31:12 GMT, Jaikiran Pai wrote: > This brings in CPU24_10 changes into master branch. Thank you Alan and Daniel for the reviews. - PR Comment: https://git.openjdk.org/jdk/pull/21533#issuecomment-2416550126

Re: RFR: Merge 490d099e234f27adef7d691d3c5a08ebdb550c5d [v2]

2024-10-16 Thread Jaikiran Pai
> This brings in CPU24_10 changes into master branch. Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. - Changes: - all: https://git.openjdk.org/jdk/p

Re: RFR: Merge 490d099e234f27adef7d691d3c5a08ebdb550c5d [v2]

2024-10-16 Thread Daniel Fuchs
On Wed, 16 Oct 2024 11:36:18 GMT, Jaikiran Pai wrote: >> This brings in CPU24_10 changes into master branch. > > Jaikiran Pai has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase.

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Alan Bateman
On Wed, 16 Oct 2024 20:14:07 GMT, Sean Mullan wrote: >> We've had logging library maintainers on the core-libs-dev several times in >> the last 7+ years so I hope there is good awareness of StackWalker. >> SM.getClassContext is legacy, shouldn't be any reason to use it in 2024. > > Ok, I'll als

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v7]

2024-10-16 Thread Xue-Lei Andrew Fan
On Tue, 24 Sep 2024 20:19:58 GMT, Artur Barashev wrote: >> Can’t review it, still don’t understand how the error condition happens. >> (But I do know massive problems with extra messages sent when a broken >> connection is wound down - it might want to use aggressive timeouts for >> those grat

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v20]

2024-10-16 Thread Xue-Lei Andrew Fan
On Fri, 11 Oct 2024 18:36:50 GMT, Artur Barashev wrote: >> Check for unexpected plaintext alert message during TLSv1.3 handshake. This >> can happen if client doesn't receive ServerHello due to network timeout and >> tries to close the connection by sending an alert message. > > Artur Barashev

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v20]

2024-10-16 Thread Xue-Lei Andrew Fan
On Fri, 11 Oct 2024 18:36:50 GMT, Artur Barashev wrote: >> Check for unexpected plaintext alert message during TLSv1.3 handshake. This >> can happen if client doesn't receive ServerHello due to network timeout and >> tries to close the connection by sending an alert message. > > Artur Barashev

Re: RFR: 8298420: PEM API: Implementation (Preview) [v7]

2024-10-16 Thread Anthony Scarpino
> Hi all, > > I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a format > for encoding and decoding cryptographic keys and certificates. It will be > integrated into JDK24 as a Preview Feature. Preview features does not > permanently define the API and it is subject to cha

RFR: 8342442: Static ACVP sample tests

2024-10-16 Thread Weijun Wang
Here we have a launcher and several algorithm-specific tests. Users can populate "internalProjection.json" files generated by NIST's ACVP Server into the `data` directory and test them with the launcher. Currently, only SHA2, SHA3, ML-KEM, and ML-DSA are supported. - Commit message

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Sean Mullan
On Wed, 16 Oct 2024 15:53:33 GMT, Alan Bateman wrote: >> **SLF4J** currently depends on this method when logger name mismatch  >> detection is enabled. >> >> >> >> See also: >> - https://github.com/qos-ch/slf4j/pul

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Sean Mullan
On Wed, 16 Oct 2024 06:58:40 GMT, Alan Bateman wrote: >> Ok, I will revert it. > > The description for the SecurityException thrown by these methods were > adjusted to "if access to the screen is denied by desktop environment". If > you bring back the paragraphs that were removed then you might

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Sean Mullan
On Wed, 16 Oct 2024 13:28:47 GMT, Weijun Wang wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v59]

2024-10-16 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-10-16 Thread Joe Wang
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote: > This is the implementation of JEP 486: Permanently Disable the Security > Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The > [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the > main change

Integrated: 8331959: Update PKCS#11 Cryptographic Token Interface to v3.1

2024-10-16 Thread Valerie Peng
On Mon, 7 Oct 2024 21:44:45 GMT, Valerie Peng wrote: > Could someone please help review this PR? It updates the PKCS#11 headers and > the relevant files to v3.1. > > Thanks! > Valerie This pull request has now been integrated. Changeset: b4ab290f Author:Valerie Peng URL: https://g

RFR: 8331958: Update PC/SC Lite for Suse Linux to 2.3.0

2024-10-16 Thread Valerie Peng
Could someone please help review this PR? It updates the PCSC Lite headers and the relevant files to v2.3.0. Thanks! Valerie - Commit messages: - 8331958: Update PC/SC Lite for Suse Linux to 2.3.0 Changes: https://git.openjdk.org/jdk/pull/21552/files Webrev: https://webrevs.open

Re: RFR: 8342442: Static ACVP sample tests [v2]

2024-10-16 Thread Weijun Wang
> Here we have a launcher and several algorithm-specific tests. Users can > populate "internalProjection.json" files generated by NIST's ACVP Server into > the `data` directory and test them with the launcher. > > Currently, only SHA2, SHA3, ML-KEM, and ML-DSA are supported. Weijun Wang has upd

RFR: 8341927: Remove hardcoded SunJCE provider

2024-10-16 Thread Matthew Donovan
In this PR, I removed hard-coded security providers and replaced them with a system property, test.provider.name. If the property is not specified, the provider originally used in the test is used: Cipher c = Cipher.getInstance("AES/GCM/NoPadding", System.getProperty("test.provider.name", "SunJ

Re: RFR: 8342211: Insufficient buffer remaining for AEAD cipher fragment [v2]

2024-10-16 Thread Xue-Lei Andrew Fan
On Wed, 16 Oct 2024 05:31:23 GMT, Xue-Lei Andrew Fan wrote: >> Hi, >> >> Please review this simple update, which is trying to expose more information >> about the failed decryption. >> >> Here is the JBS: https://bugs.openjdk.org/browse/JDK-8342211 >> >> Best, >> Xuelei > > Xue-Lei Andrew Fan

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v20]

2024-10-16 Thread Xue-Lei Andrew Fan
On Fri, 11 Oct 2024 18:36:50 GMT, Artur Barashev wrote: >> Check for unexpected plaintext alert message during TLSv1.3 handshake. This >> can happen if client doesn't receive ServerHello due to network timeout and >> tries to close the connection by sending an alert message. > > Artur Barashev