Re: RFR: 8341792: Fix ExceptionOccurred in java.security.jgss

2024-10-10 Thread Artur Barashev
On Wed, 9 Oct 2024 16:22:13 GMT, Weijun Wang wrote: > Switch to `ExceptionCheck`. > > This is a part of an umbrella bug [JDK-8341542 JNI uses of > ExceptionOccurred() treated as if function returns a > bool](https://bugs.openjdk.org/browse/JDK-8341542). src/java.security.jgss/macosx/native/li

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v2]

2024-10-10 Thread Andrew Haley
> The fourth preview of scoped values. Andrew Haley has updated the pull request incrementally with one additional commit since the last revision: Fix javadoc - Changes: - all: https://git.openjdk.org/jdk/pull/21456/files - new: https://git.openjdk.org/jdk/pull/21456/files/77

Integrated: 8341792: Fix ExceptionOccurred in java.security.jgss

2024-10-10 Thread Weijun Wang
On Wed, 9 Oct 2024 16:22:13 GMT, Weijun Wang wrote: > Switch to `ExceptionCheck`. > > This is a part of an umbrella bug [JDK-8341542 JNI uses of > ExceptionOccurred() treated as if function returns a > bool](https://bugs.openjdk.org/browse/JDK-8341542). This pull request has now been integrat

Re: RFR: 8298420: PEM API: Implementation (Preview) [v6]

2024-10-10 Thread Anthony Scarpino
On Wed, 9 Oct 2024 18:49:50 GMT, Kevin Driver wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix decoding non-encrypted types > > src/java.base/share/classes/java/security/PEMDecoder.java line 56: > >> 54: *

Re: RFR: 8298420: PEM API: Implementation (Preview) [v6]

2024-10-10 Thread Anthony Scarpino
On Wed, 9 Oct 2024 18:52:32 GMT, Kevin Driver wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix decoding non-encrypted types > > src/java.base/share/classes/java/security/PEMDecoder.java line 91: > >> 89: >

Re: RFR: 8298420: PEM API: Implementation (Preview) [v6]

2024-10-10 Thread Anthony Scarpino
On Wed, 9 Oct 2024 18:54:48 GMT, Kevin Driver wrote: >> src/java.base/share/classes/java/security/PEMDecoder.java line 93: >> >>> 91: * Creates a immutable instance with a specific KeyFactory and/or >>> password. >>> 92: * @param withFactory KeyFactory provider >>> 93: * @param w

Re: RFC: Remove Kerberos CLI tools from OpenJDK bin folder

2024-10-10 Thread Bernd
Hello,I agree that this duplication is quite confusing (I tried to find out before why it’s shipped and if it is related to keycache format, since the native tools in Windows are a bit tricky to understand in that regard if I remember my struggles correctly).So before removing it

Re: RFR: 8341792: Fix ExceptionOccurred in java.security.jgss

2024-10-10 Thread Sean Mullan
On Wed, 9 Oct 2024 16:22:13 GMT, Weijun Wang wrote: > Switch to `ExceptionCheck`. > > This is a part of an umbrella bug [JDK-8341542 JNI uses of > ExceptionOccurred() treated as if function returns a > bool](https://bugs.openjdk.org/browse/JDK-8341542). Marked as reviewed by mullan (Reviewer)

Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v3]

2024-10-10 Thread Weijun Wang
On Tue, 8 Oct 2024 18:16:47 GMT, Ben Perez wrote: >> Java implementation of ML-DSA, the FIPS 204 post-quantum signature scheme >> https://nvlpubs.nist.gov/nistpubs/FIPS/NIST.FIPS.204.pdf. Depends on >> https://github.com/openjdk/jdk/pull/21167 > > Ben Perez has updated the pull request incremen

Re: RFR: 8298387: Implementing ML-DSA signature algorithm [v3]

2024-10-10 Thread Ben Perez
On Tue, 8 Oct 2024 14:25:40 GMT, Weijun Wang wrote: >> Ben Perez has updated the pull request incrementally with one additional >> commit since the last revision: >> >> renamed internal keyGen/sign/verify functions to be same as spec > > src/java.base/share/classes/sun/security/provider/ML_DS

RFR: 8341903: Implementation of Scoped Values (Fourth Preview)

2024-10-10 Thread Andrew Haley
The fourth preview of scoped values. - Commit messages: - Scoped Values API changes - Scoped Values API changes - Scoped Values API changes Changes: https://git.openjdk.org/jdk/pull/21456/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21456&range=00 Issue: https://bugs

Re: RFR: 8341792: Fix ExceptionOccurred in java.security.jgss

2024-10-10 Thread Mark Powers
On Wed, 9 Oct 2024 16:22:13 GMT, Weijun Wang wrote: > Switch to `ExceptionCheck`. > > This is a part of an umbrella bug [JDK-8341542 JNI uses of > ExceptionOccurred() treated as if function returns a > bool](https://bugs.openjdk.org/browse/JDK-8341542). Looks good to me. - PR Co

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v19]

2024-10-10 Thread Artur Barashev
> Check for unexpected plaintext alert message during TLSv1.3 handshake. This > can happen if client doesn't receive ServerHello due to network timeout and > tries to close the connection by sending an alert message. Artur Barashev has updated the pull request incrementally with one additional

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v2]

2024-10-10 Thread Alan Bateman
On Thu, 10 Oct 2024 16:37:24 GMT, Andrew Haley wrote: >> The fourth preview of scoped values. > > Andrew Haley has updated the pull request incrementally with one additional > commit since the last revision: > > Fix javadoc @theRealAph The update to src/java.base/share/classes/jdk/internal/

Re: RFR: 8341903: Implementation of Scoped Values (Fourth Preview) [v2]

2024-10-10 Thread Alan Bateman
On Thu, 10 Oct 2024 17:02:00 GMT, Alan Bateman wrote: >> Andrew Haley has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix javadoc > > src/java.base/share/classes/java/lang/ScopedValue.java line 163: > >> 161: * // @link substri

Re: RFC: Remove Kerberos CLI tools from OpenJDK bin folder

2024-10-10 Thread Bruno Borges
Perhaps a simpler solution is not to remove them, but to rename these tools so they remain available but without conflicting with potentially system-available tools. Any thoughts in renaming them to: * jkinit.exe * jklist.exe * jktab.exe From: security-de