Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v9]

2024-09-25 Thread Artur Barashev
> https://bugs.openjdk.org/browse/JDK-8331682 Artur Barashev has updated the pull request incrementally with one additional commit since the last revision: Use 'useTLS13PlusSpec()' instead of comparing the version to TLS13. This improves the odds that we won't need to fix this issue again whe

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v3]

2024-09-25 Thread Weijun Wang
> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only > named standardized parameter sets, a common framework is introduced. > > A example of EdDSA implementation using this framework is included as a test. Weijun Wang has updated the pull request incrementally with one

Re: RFR: 8339560: Unaddressed comments during code review of JDK-8337664

2024-09-25 Thread duke
On Wed, 11 Sep 2024 09:07:15 GMT, Fernando Guallini wrote: > During the code review of > [JDK-8337664](https://bugs.openjdk.org/browse/JDK-8337664), several > non-critical comments were raised but not addressed due to time constraints. > This PR includes the following changes: > > 1. Symante

Re: RFR: 8331682: Slow networks/Impatient clients can potentially send unencrypted TLSv1.3 alerts that won't parse on the server [v8]

2024-09-25 Thread Artur Barashev
> https://bugs.openjdk.org/browse/JDK-8331682 Artur Barashev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains nine additional commits since the last rev

Re: RFR: 8340327: A common framework to support public key algorithms with standard parameter sets [v2]

2024-09-25 Thread Weijun Wang
> To prepare for new PQC algorithms like ML-KEM and ML-DSA where there are only > named standardized parameter sets, a common framework is introduced. > > A example of EdDSA implementation using this framework is included as a test. Weijun Wang has updated the pull request incrementally with one

Re: RFR: 8298420: PEM API: Implementation (Preview) [v6]

2024-09-25 Thread Anthony Scarpino
> Hi all, > > I need a code review of the PEM API. Privacy-Enhanced Mail (PEM) is a format > for encoding and decoding cryptographic keys and certificates. It will be > integrated into JDK24 as a Preview Feature. Preview features does not > permanently define the API and it is subject to cha