On Fri, 20 Sep 2024 21:35:53 GMT, Artur Barashev wrote:
>> https://bugs.openjdk.org/browse/JDK-8331682
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> - Switch server to use plaintext after getting the unexpected plaintex
On Fri, 20 Sep 2024 12:30:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in `JarFile` class'
> javadoc?
Marked as reviewed by lancea (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21108#pullrequestreview-2318248221
Can I please get a review of this trivial typo fix in `JarFile` class' javadoc?
-
Commit messages:
- 8340537: Typo in javadoc of java.util.jar.JarFile
Changes: https://git.openjdk.org/jdk/pull/21108/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21108&range=00
Issue: htt
On Fri, 20 Sep 2024 12:30:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in `JarFile` class'
> javadoc?
Marked as reviewed by mullan (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21108#pullrequestreview-2318183860
On Wed, 4 Sep 2024 09:45:01 GMT, Sean Coffey wrote:
>> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation
>> was introduced many years ago.
>>
>> Where "ssl" was previously a value to obtain all TLS debug traces (except
>> network type dumps, verbose data), it now pri
On Fri, 20 Sep 2024 12:30:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in `JarFile` class'
> javadoc?
This pull request has now been integrated.
Changeset: 90d3a64b
Author:Jaikiran Pai
URL:
https://git.openjdk.org/jdk/commit/90d3a64b0afd581098128
On Fri, 20 Sep 2024 15:47:14 GMT, Jamil Nimeh wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add assertions. Add the final server wrap
>
> src/java.base/share/classes/sun/security/ssl/SSLTransport.java line 133:
On Fri, 20 Sep 2024 16:16:24 GMT, Artur Barashev wrote:
>> test/jdk/javax/net/ssl/TLSv13/SSLEngineNoServerHelloClientShutdown.java line
>> 239:
>>
>>> 237:
>>> 238: /* TODO: Final client unwrap fails because server doesn't send
>>> an alert to terminate
>>> 239:the handsha
On Thu, 19 Sep 2024 21:33:11 GMT, Artur Barashev wrote:
>> https://bugs.openjdk.org/browse/JDK-8331682
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add assertions. Add the final server wrap
The change involves handlin
On Fri, 20 Sep 2024 12:30:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in `JarFile` class'
> javadoc?
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21108#pullrequestreview-2318683971
On Thu, 19 Sep 2024 21:33:11 GMT, Artur Barashev wrote:
>> https://bugs.openjdk.org/browse/JDK-8331682
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add assertions. Add the final server wrap
src/java.base/share/classes
On Thu, 19 Sep 2024 21:33:11 GMT, Artur Barashev wrote:
>> https://bugs.openjdk.org/browse/JDK-8331682
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add assertions. Add the final server wrap
src/java.base/share/classes
On Fri, 20 Sep 2024 15:59:23 GMT, Hai-May Chao wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add assertions. Add the final server wrap
>
> src/java.base/share/classes/sun/security/ssl/SSLTransport.java line 135
On Fri, 20 Sep 2024 16:41:13 GMT, Daniel Jeliński wrote:
>> Not yet. I'm currently learning the internals of TLS code and going through
>> TLS RFC in order to understand if it's an expected behavior or not. What do
>> you think?
>
> you can't clear the sTOc buffer if you want this to work; TLS
On Fri, 20 Sep 2024 16:58:19 GMT, Artur Barashev wrote:
>> you can't clear the sTOc buffer if you want this to work; TLS is running
>> over TCP, and TCP never loses data. So, the final client unwrap is expected
>> to deal with serverHello and all handshake messages before receiving the
>> encr
On Tue, 17 Sep 2024 20:54:28 GMT, Kevin Driver wrote:
>> (Also, it could be an `int[]` instead of `Integer[]` in that case)
>
> @viktorklang-ora: I went with your proposal:
> https://github.com/openjdk/jdk/pull/20301/commits/ed6132c8db761e8dfdba6a6689c3ed5141c9e148.
Superseded by
https://githu
On Wed, 18 Sep 2024 21:49:14 GMT, Valerie Peng wrote:
>> src/java.base/share/classes/com/sun/crypto/provider/HKDFKeyDerivation.java
>> line 92:
>>
>>> 90: }
>>> 91: this.hmacAlgName = hmacAlgName;
>>> 92: this.hmacLen = hmacLen;
>>
>> Instead of doing a binary search wh
On Wed, 18 Sep 2024 21:47:22 GMT, Valerie Peng wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refinement of addIKM and addSalt specifications
>
> src/java.base/share/classes/com/sun/crypto/provider/HKDFKeyDerivati
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic
> algorithms for deriving additional keys from a secret key and other data. See
> [JEP 478](https://openjdk.org/jeps/478).
>
> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
Kevin Driver
On Fri, 20 Sep 2024 20:08:05 GMT, Kevin Driver wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are
>> cryptographic algorithms for deriving additional keys from a secret key and
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>>
>> Work was begun in [another P
On Wed, 18 Sep 2024 14:33:55 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refinement of addIKM and addSalt specifications
>
> src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java
On Thu, 19 Sep 2024 19:46:05 GMT, Weijun Wang wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> DPS refactor to re-enable some declared exceptions in getInstance
>> signatures
>
> src/java.base/share/classes/javax/c
On Fri, 20 Sep 2024 19:04:32 GMT, Bernd wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add assertions. Add the final server wrap
>
> test/jdk/javax/net/ssl/TLSv13/SSLEngineNoServerHelloClientShutdown.java line
On Fri, 20 Sep 2024 20:07:31 GMT, Artur Barashev wrote:
>> @djelinski I see, thanks! But here is the exception I'm getting, it's not
>> about unexpected command. Can we get it because server is using TLSv1.3 and
>> client is using plaintext? How do we switch server to plaintext after
>> encoun
On Fri, 20 Sep 2024 19:03:37 GMT, Bernd wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add assertions. Add the final server wrap
>
> test/jdk/javax/net/ssl/TLSv13/SSLEngineNoServerHelloClientShutdown.java line
> https://bugs.openjdk.org/browse/JDK-8331682
Artur Barashev has updated the pull request incrementally with one additional
commit since the last revision:
- Switch server to use plaintext after getting the unexpected plaintext alert
message during TLSv1.3 handshake
- Always send user_cance
On Thu, 19 Sep 2024 21:33:11 GMT, Artur Barashev wrote:
>> https://bugs.openjdk.org/browse/JDK-8331682
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add assertions. Add the final server wrap
src/java.base/share/classes
On Fri, 20 Sep 2024 12:30:00 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial typo fix in `JarFile` class'
> javadoc?
Thank you all for the reviews.
-
PR Comment: https://git.openjdk.org/jdk/pull/21108#issuecomment-2364052197
On Thu, 19 Sep 2024 21:33:11 GMT, Artur Barashev wrote:
>> https://bugs.openjdk.org/browse/JDK-8331682
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add assertions. Add the final server wrap
See the actual comment at t
On Thu, 19 Sep 2024 21:33:11 GMT, Artur Barashev wrote:
>> https://bugs.openjdk.org/browse/JDK-8331682
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add assertions. Add the final server wrap
Sorry the review dropped my
On Fri, 20 Sep 2024 19:18:25 GMT, Bernd wrote:
> Sorry the review dropped my actual comment, what I wanted to comment is that
> the “maybe plaintext connection” is a red herring in the exception message,
> the only time when it should asume plaintext bytes being the reason for a
> corrupt mess
On Thu, 19 Sep 2024 21:33:11 GMT, Artur Barashev wrote:
>> https://bugs.openjdk.org/browse/JDK-8331682
>
> Artur Barashev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add assertions. Add the final server wrap
test/jdk/javax/net/ssl/TLSv
On Fri, 20 Sep 2024 15:33:05 GMT, Hai-May Chao wrote:
> The change involves handling an unusual situation, and to help with
> debugging, I’d like to suggest to log a message when server continues
> processing an unencrypted alert.
Will add the logging, thanks!
> src/java.base/share/classes/su
33 matches
Mail list logo
