Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v4]

2024-09-04 Thread Sean Coffey
On Wed, 4 Sep 2024 03:18:33 GMT, Bradford Wetmore wrote: >> Sean Coffey has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains nine additional >> commi

Re: RFR: 8044609: javax.net.debug options not working and documented as expected [v5]

2024-09-04 Thread Sean Coffey
> The `javax.net.debug` TLS debug option is buggy since TLSv1.3 implementation > was introduced many years ago. > > Where "ssl" was previously a value to obtain all TLS debug traces (except > network type dumps, verbose data), it now prints only a few lines for a > standard client TLS connectio

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v22]

2024-09-04 Thread Kevin Driver
On Tue, 3 Sep 2024 20:39:00 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change impl class to use byte arrays rather than SecretKey objects where >> possible > > test/jdk/com/sun/crypto/provide

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v15]

2024-09-04 Thread Kevin Driver
On Tue, 3 Sep 2024 22:14:29 GMT, Weijun Wang wrote: >> Addressed in >> https://github.com/openjdk/jdk/pull/20301/commits/e4400b6edaf69d08726a63e2a705784c731648db. >> Please confirm if resolved. > > In the `catch (NoSuchAlgorithmException e)` block, you assign a brand new > exception to `lastEx

RFR: 8339347: keytool -importpass insists prompting the user even if there is no terminal

2024-09-04 Thread Hai-May Chao
Given the changes to the System.console() behavior, where it no longer returns null when a write pipe is connected to the Java process, keytool needs to be updated to determine whether an interactive terminal is attached. - Commit messages: - 8339347: keytool -importpass insists pr

Re: RFR: 8319332: Security properties files inclusion [v20]

2024-09-04 Thread Martin Balao
On Mon, 26 Aug 2024 18:53:58 GMT, Sean Mullan wrote: >> I think throwing IAE is the cleanest approach and less likely there may be >> unexpected behavior if we are not worried about backporting. It would break >> any app previously using this as a property, but at least the behavior would >> b

Re: RFR: 8298420: PEM API: Implementation (Preview) [v4]

2024-09-04 Thread Anthony Scarpino
On Thu, 29 Aug 2024 19:35:25 GMT, Sean Mullan wrote: >> Anthony Scarpino has updated the pull request incrementally with one >> additional commit since the last revision: >> >> pemrecord whitespace > > src/java.base/share/classes/java/security/PEMEncoder.java line 183: > >> 181:

RFR: 8339285: test fails with assert(depth < max_critical_stack_depth) failed: can't have more than 10 critical frames

2024-09-04 Thread Maurizio Cimadamore
Scoped methods are critical methods in the FFM API where memory is accessed in a potentially unsafe way. When closing shared arenas, we look at threads in the middle of a scoped operation involving that arena, and if we find one, we make it fail (by installing an async handshake on that thread).

Re: RFR: 8339347: keytool -importpass insists prompting the user even if there is no terminal

2024-09-04 Thread Weijun Wang
On Wed, 4 Sep 2024 16:10:50 GMT, Hai-May Chao wrote: > Given the changes to the System.console() behavior, where it no longer > returns null when a write pipe is connected to the Java process, keytool > needs to be updated to determine whether an interactive terminal is attached. Do you need t

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v22]

2024-09-04 Thread Valerie Peng
On Fri, 30 Aug 2024 23:26:12 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another P

Re: RFR: 8339347: keytool -importpass insists prompting the user even if there is no terminal

2024-09-04 Thread Hai-May Chao
On Wed, 4 Sep 2024 16:10:50 GMT, Hai-May Chao wrote: > Given the changes to the System.console() behavior, where it no longer > returns null when a write pipe is connected to the Java process, keytool > needs to be updated to determine whether an interactive terminal is attached. The `Password