Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v3]

2024-08-02 Thread Daniel JeliƄski
On Thu, 1 Aug 2024 20:40:12 GMT, Anthony Scarpino wrote: >> src/java.base/share/classes/sun/security/util/Cache.java line 280: >> >>> 278: // Locking is to protect QueueCacheEntry's from being removed from >>> the >>> 279: // cacheMap while another thread is adding new queue entries. >>

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-02 Thread Kevin Driver
> Introduce an API for Key Derivation Functions (KDFs), which are cryptographic > algorithms for deriving additional keys from a secret key and other data. See > [JEP 478](https://openjdk.org/jeps/478). > > Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). Kevin Driver

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v8]

2024-08-02 Thread Kevin Driver
On Fri, 26 Jul 2024 16:40:08 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - update code snippet type in KDF >> - add preview annotation to KDFParameters > > Couple of comments so far. @seanjmu

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-02 Thread Kevin Driver
On Thu, 1 Aug 2024 20:47:21 GMT, Weijun Wang wrote: >> The existing sentence seems to cover this scenario. Let me know if you >> disagree. >> >> `In some cases the WithPRF portion of the algorithm field may be omitted if >> the KDF algorithm has a fixed or default PRF.` >> >> However, if Arg

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-02 Thread Weijun Wang
On Fri, 2 Aug 2024 19:16:59 GMT, Kevin Driver wrote: >> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-02 Thread Weijun Wang
On Wed, 31 Jul 2024 21:07:49 GMT, Kevin Driver wrote: >> src/java.base/share/classes/javax/crypto/KDF.java line 51: >> >>> 49: * >>> 50: * {@code KDF} objects are instantiated with the {@code getInstance} >>> family of >>> 51: * methods. KDF algorithm names follow a naming convention of >>

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-02 Thread Kevin Driver
On Wed, 31 Jul 2024 19:28:33 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits si

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v10]

2024-08-02 Thread Weijun Wang
On Wed, 31 Jul 2024 19:26:09 GMT, Weijun Wang wrote: >> Kevin Driver has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 16 additional >> commits si

Re: RFR: 8331008: Implement JEP 478: Key Derivation Function API (Preview) [v9]

2024-08-02 Thread Kevin Driver
On Mon, 29 Jul 2024 19:01:08 GMT, Sean Mullan wrote: >> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> review comments > > src/java.base/share/classes/javax/crypto/spec/HKDFParameterSpec.java line 328: > >> 326: }

Re: RFR: 8328608: Multiple NewSessionTicket support for TLS [v4]

2024-08-02 Thread Anthony Scarpino
> Hi > > This change is to improve TLS 1.3 session resumption by allowing a TLS server > to send more than one resumption ticket per connection and clients to store > more. Resumption is a quick way to use an existing TLS session to establish > another session by avoiding the long TLS full han

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v2]

2024-08-02 Thread Hai-May Chao
On Tue, 30 Jul 2024 22:13:08 GMT, Weijun Wang wrote: >> Thanks to verify the exit code is not 32. Is it doable to have a test for >> aliasNotInStore which is not emitting a non-zero exit code? > > There is a chainNotValidated error here. But I can add the check in an > earlier check. See my nex

Re: RFR: 8330217: Spurious warning from jarsigner -verify when keystore with intermediate CA is used [v4]

2024-08-02 Thread Hai-May Chao
On Tue, 30 Jul 2024 22:24:04 GMT, Weijun Wang wrote: >> There is an error in `jarsigner` on the "This JAR contains signed entries >> that aren't signed by alias in this keystore" warning. The exit code is >> determined by >> [`notSignedByAlias`](https://github.com/openjdk/jdk/blob/0a60b0f99efb